You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/17 22:38:46 UTC
[GitHub] [airflow] turbaszek opened a new pull request #11624: Expose flower port in breeze
turbaszek opened a new pull request #11624:
URL: https://github.com/apache/airflow/pull/11624
This definitely helps with debugging CeleryExecutor.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #11624: Expose flower port in breeze
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #11624:
URL: https://github.com/apache/airflow/pull/11624#discussion_r506991373
##########
File path: scripts/ci/docker-compose/base.yml
##########
@@ -72,3 +72,4 @@ services:
- /dev/urandom:/dev/random # Required to get non-blocking entropy source
ports:
- "${WEBSERVER_HOST_PORT}:8080"
+ - "5555:5555" # Flower default port
Review comment:
@potiuk not sure if we need to make it configurable or not
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gigkokman commented on a change in pull request #11624: Expose flower port in breeze
Posted by GitBox <gi...@apache.org>.
gigkokman commented on a change in pull request #11624:
URL: https://github.com/apache/airflow/pull/11624#discussion_r507007999
##########
File path: scripts/ci/docker-compose/base.yml
##########
@@ -72,3 +72,4 @@ services:
- /dev/urandom:/dev/random # Required to get non-blocking entropy source
ports:
- "${WEBSERVER_HOST_PORT}:8080"
+ - "5555:5555" # Flower default port
Review comment:
It's flexible for user when port's in use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #11624: Expose flower and redis ports in breeze
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11624:
URL: https://github.com/apache/airflow/pull/11624
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #11624: Expose flower and redis ports in breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #11624:
URL: https://github.com/apache/airflow/pull/11624#discussion_r507066333
##########
File path: scripts/ci/docker-compose/base.yml
##########
@@ -72,3 +72,4 @@ services:
- /dev/urandom:/dev/random # Required to get non-blocking entropy source
ports:
- "${WEBSERVER_HOST_PORT}:8080"
+ - "5555:5555" # Flower default port
Review comment:
Yep. Those are default ports, but you can always override them via the variables if for whatever reason you cannot use the default ones. That was the main reason why they are set as variables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #11624: Expose flower port in breeze
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #11624:
URL: https://github.com/apache/airflow/pull/11624#discussion_r507035982
##########
File path: scripts/ci/docker-compose/base.yml
##########
@@ -72,3 +72,4 @@ services:
- /dev/urandom:/dev/random # Required to get non-blocking entropy source
ports:
- "${WEBSERVER_HOST_PORT}:8080"
+ - "5555:5555" # Flower default port
Review comment:
True, same is for webserver port but we are still hardcoding it. I think this is ok for the development environment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org