You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@htrace.apache.org by Stack <st...@duboce.net> on 2014/12/31 22:01:24 UTC
[VOTE] htrace-3.1.0, fifth release candidate
I've posted our fifth release candidate here (Thanks all for finding issues
in previous RCs):
http://people.apache.org/~stack/htrace-3.1.0RC4/
Maven artifacts are available here:
https://repository.apache.org/content/repositories/orgapachehtrace-1006
RC4 has 4 fixes beyond RC3.
It is a src-only tarball for now. Later we can add binary bundles to our
release after we have better sense of what we as a project would like to
deliver.
This release is mainly a change of packaging from org.htrace to
org.apache.htrace to suit our new home here in Apache Incubator but it does
also includes 32 resolved issues [1] including the beginnings of an htrace
daemon whose intent is to make it so there is a low barrier collecting
cluster traces as well as a new flume receiver.
Beware that Apache Incubator, org.apache.htrace is not compatible with its
former self, org.htrace: the package name has changed but so has the JSON
serialization format.
Shall we make this release candidate our first incubator release?
Lets keep the vote period short (We'll have to run another vote over in
incubator general after this one if I understand the process properly).
Please vote +1/0/-1 by Friday, January 2nd, 2015.
Thanks,
St.Ack
1.
https://issues.apache.org/jira/issues/?jql=project%20%3D%20HTRACE%20AND%20status%20%3D%20resolved%20AND%20fixVersion%20%3D%203.1.0%20ORDER%20BY%20issuetype%20DESC
Re: [VOTE] htrace-3.1.0, fifth release candidate
Posted by Billie Rinaldi <bi...@apache.org>.
On Mon, Jan 5, 2015 at 9:40 AM, Stack <st...@duboce.net> wrote:
> On Mon, Jan 5, 2015 at 9:27 AM, Billie Rinaldi <bi...@apache.org> wrote:
>
> > I have 796e2438fafac3510938c1f987fadd27eef6c063, but it doesn't appear to
> > be tagged. Maybe the tag still needs to be pushed or something?
> >
>
> Its pushed. See tags here:
> https://git-wip-us.apache.org/repos/asf?p=incubator-htrace.git
>
>
> > Regarding the binary files, I don't think they can be included in a
> > src-only tarball.
> >
> >
> You are right. I misread it as you asking about the top-level bin dir.
> Clean must not be removing them or I need to add an exclude to the
> assembly.
>
>
>
> > Going down the release checklist (
> > http://incubator.apache.org/guides/releasemanagement.html#check-list),
> it
> > looks as though we're okay on most of the points, but we're missing the
> > disclaimer,
>
>
> You are right.
>
>
>
>
>
> > the filenames don't have "incubating" in them (I've seen other
> > podlings handle this by adding -incubating to the version number, e.g.
> > 3.1.0-incubating), and the release doesn't consist only of source code.
> >
>
> Sorry, what you saying in the last bit Billie ("... and the release doesn't
> consist only of source code") Are you saying we should do a binary tarball
> too?
>
No, a source tarball is fine. I was just referring to the compiled files
in htrace-core/src/go/bin. If those are removed I think we'll be able to
check off this item.
>
>
>
> > good - 1.1 Checksums and PGP signatures are valid.
> > good - 2.1 Build is successful including automated tests.
> > still need to address - 3.1 DISCLAIMER is correct, filenames include
> > "incubating".
> > see below - 3.2 Top-level LICENSE and NOTICE are correct for each
> > distribution.
> > good - 3.3 All source files have license headers where appropriate.
> > good - 3.4 The provenance of all source files is clear (ASF or software
> > grants).
> > good - 3.5 Dependencies licenses are ok as per http://apache.org/legal/
> > release contains compiled code - 3.6 Release consists of source code
> only,
> > no binaries.
> >
> > Regarding the LICENSE and NOTICE, in htrace-hbase/src/main/webapps/static
> > we have d3.min.js, bootstrap-theme.min.css and bootstrap.min.css. d3 is
> > BSD-licensed and bootstrap is MIT-licensed, so these should be mentioned
> in
> > the LICENSE file, presumably with the entire text of their licenses since
> > we're using the minimized versions (
> > http://www.apache.org/dev/licensing-howto.html#permissive-deps).
> >
> >
> Thanks. Will do.
>
>
>
> > In htrace-zipkin/src/main/thrift we have scribe.thrift and
> > zipkinCore.thrift that seem to be from Zipkin. Since Zipkin is
> > Apache-licensed and has a NOTICE file, I think we need to copy the first
> > couple of lines to our NOTICE (e.g. Zipkin is a distributed tracing
> system.
> > Copyright 2012 Twitter, Inc. -- we can leave out the optional
> dependencies
> > listed in their NOTICE).
> >
> >
> Will do.
>
>
>
> > Regarding the projects currently mentioned in the NOTICE file:
> > junit - we don't actually bundle this, do we? can we remove it from the
> > notice?
> > levigo and kingpin - MIT licensed, so should be mentioned in LICENSE
> > instead of NOTICE
> > units - I'm a little concerned about this one since the license is
> > undetermined -- what if it's made GPL?
> >
> >
> Thanks for the thorough review Billie. Will address and post new RC.
>
> Thanks,
> St.Ack
>
>
>
> >
> > On Mon, Jan 5, 2015 at 7:45 AM, Stack <st...@duboce.net> wrote:
> >
> > > On Sun, Jan 4, 2015 at 5:32 PM, Billie Rinaldi <bi...@apache.org>
> > wrote:
> > >
> > > > Sorry for the delay; I'm just getting back from vacation and am
> taking
> > a
> > > > look now. Do we have a KEYS file?
> > >
> > >
> > > No. Was thinking this a TODO for when we move RC to release.
> > >
> > >
> > >
> > > > Is there a tag for the release
> > > >
> > >
> > > Yes (Pull down tags to your local repo and see its tagged 3.1.0RC4 at
> > > 796e2438fafac3510938c1f987fadd27eef6c063 We made a 3.1 branch soon
> > after).
> > >
> > >
> > > > candidate? The tarball doesn't quite match what is in git, so how is
> > the
> > > > tarball created from the tag?
> > >
> > >
> > > Checkout the tag and then do:
> > >
> > > $ mvn clean install assembly:single
> > >
> > > I'll write up how-to-RC soon.
> > >
> > >
> > > > Also are the binary files in
> > > > htrace-core/src/go/bin intended to be in the tarball? I'll check
> over
> > > the
> > > > license and notice information as well.
> > > >
> > > >
> > > Yes. They are there right?
> > >
> > > Thanks Billie,
> > > St.Ack
> > >
> >
>
Re: [VOTE] htrace-3.1.0, fifth release candidate
Posted by Stack <st...@duboce.net>.
On Mon, Jan 5, 2015 at 9:27 AM, Billie Rinaldi <bi...@apache.org> wrote:
> I have 796e2438fafac3510938c1f987fadd27eef6c063, but it doesn't appear to
> be tagged. Maybe the tag still needs to be pushed or something?
>
Its pushed. See tags here:
https://git-wip-us.apache.org/repos/asf?p=incubator-htrace.git
> Regarding the binary files, I don't think they can be included in a
> src-only tarball.
>
>
You are right. I misread it as you asking about the top-level bin dir.
Clean must not be removing them or I need to add an exclude to the assembly.
> Going down the release checklist (
> http://incubator.apache.org/guides/releasemanagement.html#check-list), it
> looks as though we're okay on most of the points, but we're missing the
> disclaimer,
You are right.
> the filenames don't have "incubating" in them (I've seen other
> podlings handle this by adding -incubating to the version number, e.g.
> 3.1.0-incubating), and the release doesn't consist only of source code.
>
Sorry, what you saying in the last bit Billie ("... and the release doesn't
consist only of source code") Are you saying we should do a binary tarball
too?
> good - 1.1 Checksums and PGP signatures are valid.
> good - 2.1 Build is successful including automated tests.
> still need to address - 3.1 DISCLAIMER is correct, filenames include
> "incubating".
> see below - 3.2 Top-level LICENSE and NOTICE are correct for each
> distribution.
> good - 3.3 All source files have license headers where appropriate.
> good - 3.4 The provenance of all source files is clear (ASF or software
> grants).
> good - 3.5 Dependencies licenses are ok as per http://apache.org/legal/
> release contains compiled code - 3.6 Release consists of source code only,
> no binaries.
>
> Regarding the LICENSE and NOTICE, in htrace-hbase/src/main/webapps/static
> we have d3.min.js, bootstrap-theme.min.css and bootstrap.min.css. d3 is
> BSD-licensed and bootstrap is MIT-licensed, so these should be mentioned in
> the LICENSE file, presumably with the entire text of their licenses since
> we're using the minimized versions (
> http://www.apache.org/dev/licensing-howto.html#permissive-deps).
>
>
Thanks. Will do.
> In htrace-zipkin/src/main/thrift we have scribe.thrift and
> zipkinCore.thrift that seem to be from Zipkin. Since Zipkin is
> Apache-licensed and has a NOTICE file, I think we need to copy the first
> couple of lines to our NOTICE (e.g. Zipkin is a distributed tracing system.
> Copyright 2012 Twitter, Inc. -- we can leave out the optional dependencies
> listed in their NOTICE).
>
>
Will do.
> Regarding the projects currently mentioned in the NOTICE file:
> junit - we don't actually bundle this, do we? can we remove it from the
> notice?
> levigo and kingpin - MIT licensed, so should be mentioned in LICENSE
> instead of NOTICE
> units - I'm a little concerned about this one since the license is
> undetermined -- what if it's made GPL?
>
>
Thanks for the thorough review Billie. Will address and post new RC.
Thanks,
St.Ack
>
> On Mon, Jan 5, 2015 at 7:45 AM, Stack <st...@duboce.net> wrote:
>
> > On Sun, Jan 4, 2015 at 5:32 PM, Billie Rinaldi <bi...@apache.org>
> wrote:
> >
> > > Sorry for the delay; I'm just getting back from vacation and am taking
> a
> > > look now. Do we have a KEYS file?
> >
> >
> > No. Was thinking this a TODO for when we move RC to release.
> >
> >
> >
> > > Is there a tag for the release
> > >
> >
> > Yes (Pull down tags to your local repo and see its tagged 3.1.0RC4 at
> > 796e2438fafac3510938c1f987fadd27eef6c063 We made a 3.1 branch soon
> after).
> >
> >
> > > candidate? The tarball doesn't quite match what is in git, so how is
> the
> > > tarball created from the tag?
> >
> >
> > Checkout the tag and then do:
> >
> > $ mvn clean install assembly:single
> >
> > I'll write up how-to-RC soon.
> >
> >
> > > Also are the binary files in
> > > htrace-core/src/go/bin intended to be in the tarball? I'll check over
> > the
> > > license and notice information as well.
> > >
> > >
> > Yes. They are there right?
> >
> > Thanks Billie,
> > St.Ack
> >
>
Re: [VOTE] htrace-3.1.0, fifth release candidate
Posted by Billie Rinaldi <bi...@apache.org>.
I have 796e2438fafac3510938c1f987fadd27eef6c063, but it doesn't appear to
be tagged. Maybe the tag still needs to be pushed or something?
Regarding the binary files, I don't think they can be included in a
src-only tarball.
Going down the release checklist (
http://incubator.apache.org/guides/releasemanagement.html#check-list), it
looks as though we're okay on most of the points, but we're missing the
disclaimer, the filenames don't have "incubating" in them (I've seen other
podlings handle this by adding -incubating to the version number, e.g.
3.1.0-incubating), and the release doesn't consist only of source code.
good - 1.1 Checksums and PGP signatures are valid.
good - 2.1 Build is successful including automated tests.
still need to address - 3.1 DISCLAIMER is correct, filenames include
"incubating".
see below - 3.2 Top-level LICENSE and NOTICE are correct for each
distribution.
good - 3.3 All source files have license headers where appropriate.
good - 3.4 The provenance of all source files is clear (ASF or software
grants).
good - 3.5 Dependencies licenses are ok as per http://apache.org/legal/
release contains compiled code - 3.6 Release consists of source code only,
no binaries.
Regarding the LICENSE and NOTICE, in htrace-hbase/src/main/webapps/static
we have d3.min.js, bootstrap-theme.min.css and bootstrap.min.css. d3 is
BSD-licensed and bootstrap is MIT-licensed, so these should be mentioned in
the LICENSE file, presumably with the entire text of their licenses since
we're using the minimized versions (
http://www.apache.org/dev/licensing-howto.html#permissive-deps).
In htrace-zipkin/src/main/thrift we have scribe.thrift and
zipkinCore.thrift that seem to be from Zipkin. Since Zipkin is
Apache-licensed and has a NOTICE file, I think we need to copy the first
couple of lines to our NOTICE (e.g. Zipkin is a distributed tracing system.
Copyright 2012 Twitter, Inc. -- we can leave out the optional dependencies
listed in their NOTICE).
Regarding the projects currently mentioned in the NOTICE file:
junit - we don't actually bundle this, do we? can we remove it from the
notice?
levigo and kingpin - MIT licensed, so should be mentioned in LICENSE
instead of NOTICE
units - I'm a little concerned about this one since the license is
undetermined -- what if it's made GPL?
On Mon, Jan 5, 2015 at 7:45 AM, Stack <st...@duboce.net> wrote:
> On Sun, Jan 4, 2015 at 5:32 PM, Billie Rinaldi <bi...@apache.org> wrote:
>
> > Sorry for the delay; I'm just getting back from vacation and am taking a
> > look now. Do we have a KEYS file?
>
>
> No. Was thinking this a TODO for when we move RC to release.
>
>
>
> > Is there a tag for the release
> >
>
> Yes (Pull down tags to your local repo and see its tagged 3.1.0RC4 at
> 796e2438fafac3510938c1f987fadd27eef6c063 We made a 3.1 branch soon after).
>
>
> > candidate? The tarball doesn't quite match what is in git, so how is the
> > tarball created from the tag?
>
>
> Checkout the tag and then do:
>
> $ mvn clean install assembly:single
>
> I'll write up how-to-RC soon.
>
>
> > Also are the binary files in
> > htrace-core/src/go/bin intended to be in the tarball? I'll check over
> the
> > license and notice information as well.
> >
> >
> Yes. They are there right?
>
> Thanks Billie,
> St.Ack
>
Re: [VOTE] htrace-3.1.0, fifth release candidate
Posted by Stack <st...@duboce.net>.
On Sun, Jan 4, 2015 at 5:32 PM, Billie Rinaldi <bi...@apache.org> wrote:
> Sorry for the delay; I'm just getting back from vacation and am taking a
> look now. Do we have a KEYS file?
No. Was thinking this a TODO for when we move RC to release.
> Is there a tag for the release
>
Yes (Pull down tags to your local repo and see its tagged 3.1.0RC4 at
796e2438fafac3510938c1f987fadd27eef6c063 We made a 3.1 branch soon after).
> candidate? The tarball doesn't quite match what is in git, so how is the
> tarball created from the tag?
Checkout the tag and then do:
$ mvn clean install assembly:single
I'll write up how-to-RC soon.
> Also are the binary files in
> htrace-core/src/go/bin intended to be in the tarball? I'll check over the
> license and notice information as well.
>
>
Yes. They are there right?
Thanks Billie,
St.Ack
Re: [VOTE] htrace-3.1.0, fifth release candidate
Posted by Billie Rinaldi <bi...@apache.org>.
Sorry for the delay; I'm just getting back from vacation and am taking a
look now. Do we have a KEYS file? Is there a tag for the release
candidate? The tarball doesn't quite match what is in git, so how is the
tarball created from the tag? Also are the binary files in
htrace-core/src/go/bin intended to be in the tarball? I'll check over the
license and notice information as well.
On Sat, Jan 3, 2015 at 12:11 PM, Stack <st...@duboce.net> wrote:
> Any chance of a few mentor votes on this thread before I go to the
> incubator general list soliciting IPMC votes?
> Thanks,
> St.Ack
>
> On Thu, Jan 1, 2015 at 11:38 PM, Colin McCabe <cm...@alumni.cmu.edu>
> wrote:
>
> > +1. Thanks for putting this together, st.ack.
> >
> > C.
> > On Dec 31, 2014 2:44 PM, "Colin McCabe" <cm...@alumni.cmu.edu> wrote:
> >
> > > I verified the signature, untarred, ran mvn test with no problems. I
> > > did see that we are leaking a few jackson classes on to the CLASSPATH
> > > in htrace-core:
> > >
> > > jar tvf ./htrace-core/target/htrace-core-3.1.0.jar
> > > ....
> > > 2487 Wed Dec 31 14:29:18 PST 2014
> > >
> org/apache/htrace/fasterxml/jackson/core/util/MinimalPrettyPrinter.class
> > > 8621 Wed Dec 31 14:29:18 PST 2014
> > > org/apache/htrace/fasterxml/jackson/core/util/TextBuffer.class
> > > 6419 Wed Dec 31 14:29:18 PST 2014
> > > org/apache/htrace/fasterxml/jackson/core/util/VersionUtil.class
> > > 0 Wed Dec 31 14:29:18 PST 2014 com/
> > > 0 Wed Dec 31 14:29:18 PST 2014 com/fasterxml/
> > > 0 Wed Dec 31 14:29:18 PST 2014 com/fasterxml/jackson/
> > > 0 Wed Dec 31 14:29:18 PST 2014 com/fasterxml/jackson/databind/
> > > 801 Wed Dec 31 14:29:18 PST 2014
> > > com/fasterxml/jackson/databind/AbstractTypeResolver.class
> > > 1506 Wed Dec 31 14:29:18 PST 2014
> > >
> > >
> >
> com/fasterxml/jackson/databind/AnnotationIntrospector$ReferenceProperty$Type.class
> > > ...
> > >
> > > This could potentially be an issue because some of our users want to
> > > use a different version of jackson than what we're using. I posted a
> > > fix at https://issues.apache.org/jira/browse/HTRACE-46. Not sure if
> > > this is worth spinning a new RC over.
> > >
> > > Colin
> > >
> > > On Wed, Dec 31, 2014 at 1:32 PM, Elliott Clark <ec...@apache.org>
> > wrote:
> > > > +1
> > > > Verified sig.
> > > > un-tar'd the src tar.
> > > > Verified that all tests pass
> > > > mvn package creates go binaries.
> > > > Those binaries run and listen on a port
> > > > maven repository looks good and has the needed jars.
> > > >
> > > > On Wed, Dec 31, 2014 at 1:01 PM, Stack <st...@duboce.net> wrote:
> > > >
> > > >> I've posted our fifth release candidate here (Thanks all for finding
> > > issues
> > > >> in previous RCs):
> > > >>
> > > >> http://people.apache.org/~stack/htrace-3.1.0RC4/
> > > >>
> > > >> Maven artifacts are available here:
> > > >>
> > > >>
> > >
> https://repository.apache.org/content/repositories/orgapachehtrace-1006
> > > >>
> > > >> RC4 has 4 fixes beyond RC3.
> > > >>
> > > >> It is a src-only tarball for now. Later we can add binary bundles to
> > our
> > > >> release after we have better sense of what we as a project would
> like
> > to
> > > >> deliver.
> > > >>
> > > >> This release is mainly a change of packaging from org.htrace to
> > > >> org.apache.htrace to suit our new home here in Apache Incubator but
> it
> > > does
> > > >> also includes 32 resolved issues [1] including the beginnings of an
> > > htrace
> > > >> daemon whose intent is to make it so there is a low barrier
> collecting
> > > >> cluster traces as well as a new flume receiver.
> > > >>
> > > >> Beware that Apache Incubator, org.apache.htrace is not compatible
> with
> > > its
> > > >> former self, org.htrace: the package name has changed but so has the
> > > JSON
> > > >> serialization format.
> > > >>
> > > >> Shall we make this release candidate our first incubator release?
> > > >>
> > > >> Lets keep the vote period short (We'll have to run another vote over
> > in
> > > >> incubator general after this one if I understand the process
> > properly).
> > > >>
> > > >> Please vote +1/0/-1 by Friday, January 2nd, 2015.
> > > >>
> > > >> Thanks,
> > > >> St.Ack
> > > >>
> > > >> 1.
> > > >>
> > > >>
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20HTRACE%20AND%20status%20%3D%20resolved%20AND%20fixVersion%20%3D%203.1.0%20ORDER%20BY%20issuetype%20DESC
> > > >>
> > >
> >
>
Re: [VOTE] htrace-3.1.0, fifth release candidate
Posted by Stack <st...@duboce.net>.
Any chance of a few mentor votes on this thread before I go to the
incubator general list soliciting IPMC votes?
Thanks,
St.Ack
On Thu, Jan 1, 2015 at 11:38 PM, Colin McCabe <cm...@alumni.cmu.edu>
wrote:
> +1. Thanks for putting this together, st.ack.
>
> C.
> On Dec 31, 2014 2:44 PM, "Colin McCabe" <cm...@alumni.cmu.edu> wrote:
>
> > I verified the signature, untarred, ran mvn test with no problems. I
> > did see that we are leaking a few jackson classes on to the CLASSPATH
> > in htrace-core:
> >
> > jar tvf ./htrace-core/target/htrace-core-3.1.0.jar
> > ....
> > 2487 Wed Dec 31 14:29:18 PST 2014
> > org/apache/htrace/fasterxml/jackson/core/util/MinimalPrettyPrinter.class
> > 8621 Wed Dec 31 14:29:18 PST 2014
> > org/apache/htrace/fasterxml/jackson/core/util/TextBuffer.class
> > 6419 Wed Dec 31 14:29:18 PST 2014
> > org/apache/htrace/fasterxml/jackson/core/util/VersionUtil.class
> > 0 Wed Dec 31 14:29:18 PST 2014 com/
> > 0 Wed Dec 31 14:29:18 PST 2014 com/fasterxml/
> > 0 Wed Dec 31 14:29:18 PST 2014 com/fasterxml/jackson/
> > 0 Wed Dec 31 14:29:18 PST 2014 com/fasterxml/jackson/databind/
> > 801 Wed Dec 31 14:29:18 PST 2014
> > com/fasterxml/jackson/databind/AbstractTypeResolver.class
> > 1506 Wed Dec 31 14:29:18 PST 2014
> >
> >
> com/fasterxml/jackson/databind/AnnotationIntrospector$ReferenceProperty$Type.class
> > ...
> >
> > This could potentially be an issue because some of our users want to
> > use a different version of jackson than what we're using. I posted a
> > fix at https://issues.apache.org/jira/browse/HTRACE-46. Not sure if
> > this is worth spinning a new RC over.
> >
> > Colin
> >
> > On Wed, Dec 31, 2014 at 1:32 PM, Elliott Clark <ec...@apache.org>
> wrote:
> > > +1
> > > Verified sig.
> > > un-tar'd the src tar.
> > > Verified that all tests pass
> > > mvn package creates go binaries.
> > > Those binaries run and listen on a port
> > > maven repository looks good and has the needed jars.
> > >
> > > On Wed, Dec 31, 2014 at 1:01 PM, Stack <st...@duboce.net> wrote:
> > >
> > >> I've posted our fifth release candidate here (Thanks all for finding
> > issues
> > >> in previous RCs):
> > >>
> > >> http://people.apache.org/~stack/htrace-3.1.0RC4/
> > >>
> > >> Maven artifacts are available here:
> > >>
> > >>
> > https://repository.apache.org/content/repositories/orgapachehtrace-1006
> > >>
> > >> RC4 has 4 fixes beyond RC3.
> > >>
> > >> It is a src-only tarball for now. Later we can add binary bundles to
> our
> > >> release after we have better sense of what we as a project would like
> to
> > >> deliver.
> > >>
> > >> This release is mainly a change of packaging from org.htrace to
> > >> org.apache.htrace to suit our new home here in Apache Incubator but it
> > does
> > >> also includes 32 resolved issues [1] including the beginnings of an
> > htrace
> > >> daemon whose intent is to make it so there is a low barrier collecting
> > >> cluster traces as well as a new flume receiver.
> > >>
> > >> Beware that Apache Incubator, org.apache.htrace is not compatible with
> > its
> > >> former self, org.htrace: the package name has changed but so has the
> > JSON
> > >> serialization format.
> > >>
> > >> Shall we make this release candidate our first incubator release?
> > >>
> > >> Lets keep the vote period short (We'll have to run another vote over
> in
> > >> incubator general after this one if I understand the process
> properly).
> > >>
> > >> Please vote +1/0/-1 by Friday, January 2nd, 2015.
> > >>
> > >> Thanks,
> > >> St.Ack
> > >>
> > >> 1.
> > >>
> > >>
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20HTRACE%20AND%20status%20%3D%20resolved%20AND%20fixVersion%20%3D%203.1.0%20ORDER%20BY%20issuetype%20DESC
> > >>
> >
>
Re: [VOTE] htrace-3.1.0, fifth release candidate
Posted by Colin McCabe <cm...@alumni.cmu.edu>.
+1. Thanks for putting this together, st.ack.
C.
On Dec 31, 2014 2:44 PM, "Colin McCabe" <cm...@alumni.cmu.edu> wrote:
> I verified the signature, untarred, ran mvn test with no problems. I
> did see that we are leaking a few jackson classes on to the CLASSPATH
> in htrace-core:
>
> jar tvf ./htrace-core/target/htrace-core-3.1.0.jar
> ....
> 2487 Wed Dec 31 14:29:18 PST 2014
> org/apache/htrace/fasterxml/jackson/core/util/MinimalPrettyPrinter.class
> 8621 Wed Dec 31 14:29:18 PST 2014
> org/apache/htrace/fasterxml/jackson/core/util/TextBuffer.class
> 6419 Wed Dec 31 14:29:18 PST 2014
> org/apache/htrace/fasterxml/jackson/core/util/VersionUtil.class
> 0 Wed Dec 31 14:29:18 PST 2014 com/
> 0 Wed Dec 31 14:29:18 PST 2014 com/fasterxml/
> 0 Wed Dec 31 14:29:18 PST 2014 com/fasterxml/jackson/
> 0 Wed Dec 31 14:29:18 PST 2014 com/fasterxml/jackson/databind/
> 801 Wed Dec 31 14:29:18 PST 2014
> com/fasterxml/jackson/databind/AbstractTypeResolver.class
> 1506 Wed Dec 31 14:29:18 PST 2014
>
> com/fasterxml/jackson/databind/AnnotationIntrospector$ReferenceProperty$Type.class
> ...
>
> This could potentially be an issue because some of our users want to
> use a different version of jackson than what we're using. I posted a
> fix at https://issues.apache.org/jira/browse/HTRACE-46. Not sure if
> this is worth spinning a new RC over.
>
> Colin
>
> On Wed, Dec 31, 2014 at 1:32 PM, Elliott Clark <ec...@apache.org> wrote:
> > +1
> > Verified sig.
> > un-tar'd the src tar.
> > Verified that all tests pass
> > mvn package creates go binaries.
> > Those binaries run and listen on a port
> > maven repository looks good and has the needed jars.
> >
> > On Wed, Dec 31, 2014 at 1:01 PM, Stack <st...@duboce.net> wrote:
> >
> >> I've posted our fifth release candidate here (Thanks all for finding
> issues
> >> in previous RCs):
> >>
> >> http://people.apache.org/~stack/htrace-3.1.0RC4/
> >>
> >> Maven artifacts are available here:
> >>
> >>
> https://repository.apache.org/content/repositories/orgapachehtrace-1006
> >>
> >> RC4 has 4 fixes beyond RC3.
> >>
> >> It is a src-only tarball for now. Later we can add binary bundles to our
> >> release after we have better sense of what we as a project would like to
> >> deliver.
> >>
> >> This release is mainly a change of packaging from org.htrace to
> >> org.apache.htrace to suit our new home here in Apache Incubator but it
> does
> >> also includes 32 resolved issues [1] including the beginnings of an
> htrace
> >> daemon whose intent is to make it so there is a low barrier collecting
> >> cluster traces as well as a new flume receiver.
> >>
> >> Beware that Apache Incubator, org.apache.htrace is not compatible with
> its
> >> former self, org.htrace: the package name has changed but so has the
> JSON
> >> serialization format.
> >>
> >> Shall we make this release candidate our first incubator release?
> >>
> >> Lets keep the vote period short (We'll have to run another vote over in
> >> incubator general after this one if I understand the process properly).
> >>
> >> Please vote +1/0/-1 by Friday, January 2nd, 2015.
> >>
> >> Thanks,
> >> St.Ack
> >>
> >> 1.
> >>
> >>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20HTRACE%20AND%20status%20%3D%20resolved%20AND%20fixVersion%20%3D%203.1.0%20ORDER%20BY%20issuetype%20DESC
> >>
>
Re: [VOTE] htrace-3.1.0, fifth release candidate
Posted by Colin McCabe <cm...@alumni.cmu.edu>.
I verified the signature, untarred, ran mvn test with no problems. I
did see that we are leaking a few jackson classes on to the CLASSPATH
in htrace-core:
jar tvf ./htrace-core/target/htrace-core-3.1.0.jar
....
2487 Wed Dec 31 14:29:18 PST 2014
org/apache/htrace/fasterxml/jackson/core/util/MinimalPrettyPrinter.class
8621 Wed Dec 31 14:29:18 PST 2014
org/apache/htrace/fasterxml/jackson/core/util/TextBuffer.class
6419 Wed Dec 31 14:29:18 PST 2014
org/apache/htrace/fasterxml/jackson/core/util/VersionUtil.class
0 Wed Dec 31 14:29:18 PST 2014 com/
0 Wed Dec 31 14:29:18 PST 2014 com/fasterxml/
0 Wed Dec 31 14:29:18 PST 2014 com/fasterxml/jackson/
0 Wed Dec 31 14:29:18 PST 2014 com/fasterxml/jackson/databind/
801 Wed Dec 31 14:29:18 PST 2014
com/fasterxml/jackson/databind/AbstractTypeResolver.class
1506 Wed Dec 31 14:29:18 PST 2014
com/fasterxml/jackson/databind/AnnotationIntrospector$ReferenceProperty$Type.class
...
This could potentially be an issue because some of our users want to
use a different version of jackson than what we're using. I posted a
fix at https://issues.apache.org/jira/browse/HTRACE-46. Not sure if
this is worth spinning a new RC over.
Colin
On Wed, Dec 31, 2014 at 1:32 PM, Elliott Clark <ec...@apache.org> wrote:
> +1
> Verified sig.
> un-tar'd the src tar.
> Verified that all tests pass
> mvn package creates go binaries.
> Those binaries run and listen on a port
> maven repository looks good and has the needed jars.
>
> On Wed, Dec 31, 2014 at 1:01 PM, Stack <st...@duboce.net> wrote:
>
>> I've posted our fifth release candidate here (Thanks all for finding issues
>> in previous RCs):
>>
>> http://people.apache.org/~stack/htrace-3.1.0RC4/
>>
>> Maven artifacts are available here:
>>
>> https://repository.apache.org/content/repositories/orgapachehtrace-1006
>>
>> RC4 has 4 fixes beyond RC3.
>>
>> It is a src-only tarball for now. Later we can add binary bundles to our
>> release after we have better sense of what we as a project would like to
>> deliver.
>>
>> This release is mainly a change of packaging from org.htrace to
>> org.apache.htrace to suit our new home here in Apache Incubator but it does
>> also includes 32 resolved issues [1] including the beginnings of an htrace
>> daemon whose intent is to make it so there is a low barrier collecting
>> cluster traces as well as a new flume receiver.
>>
>> Beware that Apache Incubator, org.apache.htrace is not compatible with its
>> former self, org.htrace: the package name has changed but so has the JSON
>> serialization format.
>>
>> Shall we make this release candidate our first incubator release?
>>
>> Lets keep the vote period short (We'll have to run another vote over in
>> incubator general after this one if I understand the process properly).
>>
>> Please vote +1/0/-1 by Friday, January 2nd, 2015.
>>
>> Thanks,
>> St.Ack
>>
>> 1.
>>
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20HTRACE%20AND%20status%20%3D%20resolved%20AND%20fixVersion%20%3D%203.1.0%20ORDER%20BY%20issuetype%20DESC
>>
Re: [VOTE] htrace-3.1.0, fifth release candidate
Posted by Elliott Clark <ec...@apache.org>.
+1
Verified sig.
un-tar'd the src tar.
Verified that all tests pass
mvn package creates go binaries.
Those binaries run and listen on a port
maven repository looks good and has the needed jars.
On Wed, Dec 31, 2014 at 1:01 PM, Stack <st...@duboce.net> wrote:
> I've posted our fifth release candidate here (Thanks all for finding issues
> in previous RCs):
>
> http://people.apache.org/~stack/htrace-3.1.0RC4/
>
> Maven artifacts are available here:
>
> https://repository.apache.org/content/repositories/orgapachehtrace-1006
>
> RC4 has 4 fixes beyond RC3.
>
> It is a src-only tarball for now. Later we can add binary bundles to our
> release after we have better sense of what we as a project would like to
> deliver.
>
> This release is mainly a change of packaging from org.htrace to
> org.apache.htrace to suit our new home here in Apache Incubator but it does
> also includes 32 resolved issues [1] including the beginnings of an htrace
> daemon whose intent is to make it so there is a low barrier collecting
> cluster traces as well as a new flume receiver.
>
> Beware that Apache Incubator, org.apache.htrace is not compatible with its
> former self, org.htrace: the package name has changed but so has the JSON
> serialization format.
>
> Shall we make this release candidate our first incubator release?
>
> Lets keep the vote period short (We'll have to run another vote over in
> incubator general after this one if I understand the process properly).
>
> Please vote +1/0/-1 by Friday, January 2nd, 2015.
>
> Thanks,
> St.Ack
>
> 1.
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20HTRACE%20AND%20status%20%3D%20resolved%20AND%20fixVersion%20%3D%203.1.0%20ORDER%20BY%20issuetype%20DESC
>
Re: [VOTE] htrace-3.1.0, fifth release candidate
Posted by Masatake Iwasaki <iw...@oss.nttdata.co.jp>.
+1
verified signature
checked sha1 checksum
built on CentOS7, apache-maven-3.2.5, java-1.7.0-openjdk-1.7.0.71, go1.4
ran "mvn test" and passed all tests
Masatake Iwasaki
On 1/1/15 06:01, Stack wrote:
> I've posted our fifth release candidate here (Thanks all for finding issues
> in previous RCs):
>
> http://people.apache.org/~stack/htrace-3.1.0RC4/
>
> Maven artifacts are available here:
>
> https://repository.apache.org/content/repositories/orgapachehtrace-1006
>
> RC4 has 4 fixes beyond RC3.
>
> It is a src-only tarball for now. Later we can add binary bundles to our
> release after we have better sense of what we as a project would like to
> deliver.
>
> This release is mainly a change of packaging from org.htrace to
> org.apache.htrace to suit our new home here in Apache Incubator but it does
> also includes 32 resolved issues [1] including the beginnings of an htrace
> daemon whose intent is to make it so there is a low barrier collecting
> cluster traces as well as a new flume receiver.
>
> Beware that Apache Incubator, org.apache.htrace is not compatible with its
> former self, org.htrace: the package name has changed but so has the JSON
> serialization format.
>
> Shall we make this release candidate our first incubator release?
>
> Lets keep the vote period short (We'll have to run another vote over in
> incubator general after this one if I understand the process properly).
>
> Please vote +1/0/-1 by Friday, January 2nd, 2015.
>
> Thanks,
> St.Ack
>
> 1.
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20HTRACE%20AND%20status%20%3D%20resolved%20AND%20fixVersion%20%3D%203.1.0%20ORDER%20BY%20issuetype%20DESC
>
Re: [VOTE] htrace-3.1.0, fifth release candidate
Posted by Stack <st...@duboce.net>.
+1
Verified sig and md5.
Undid tar and was able to build new tarball from it.
St.Ack
On Wed, Dec 31, 2014 at 1:01 PM, Stack <st...@duboce.net> wrote:
> I've posted our fifth release candidate here (Thanks all for finding
> issues in previous RCs):
>
> http://people.apache.org/~stack/htrace-3.1.0RC4/
>
> Maven artifacts are available here:
>
> https://repository.apache.org/content/repositories/orgapachehtrace-1006
>
> RC4 has 4 fixes beyond RC3.
>
> It is a src-only tarball for now. Later we can add binary bundles to our
> release after we have better sense of what we as a project would like to
> deliver.
>
> This release is mainly a change of packaging from org.htrace to
> org.apache.htrace to suit our new home here in Apache Incubator but it does
> also includes 32 resolved issues [1] including the beginnings of an htrace
> daemon whose intent is to make it so there is a low barrier collecting
> cluster traces as well as a new flume receiver.
>
> Beware that Apache Incubator, org.apache.htrace is not compatible with its
> former self, org.htrace: the package name has changed but so has the JSON
> serialization format.
>
> Shall we make this release candidate our first incubator release?
>
> Lets keep the vote period short (We'll have to run another vote over in
> incubator general after this one if I understand the process properly).
>
> Please vote +1/0/-1 by Friday, January 2nd, 2015.
>
> Thanks,
> St.Ack
>
> 1.
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20HTRACE%20AND%20status%20%3D%20resolved%20AND%20fixVersion%20%3D%203.1.0%20ORDER%20BY%20issuetype%20DESC
>