You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "David Marston (JIRA)" <xa...@xml.apache.org> on 2005/05/18 21:21:55 UTC
[jira] Created: (XALANC-519) HTML serialization should reduce "boolean attributes" regardless of how created
HTML serialization should reduce "boolean attributes" regardless of how created
-------------------------------------------------------------------------------
Key: XALANC-519
URL: http://issues.apache.org/jira/browse/XALANC-519
Project: XalanC
Type: Bug
Components: XalanC
Reporter: David Marston
Priority: Minor
The situation illustrated in test case attribset17...
<Input Type="checkbox">
<xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
</Input>
should be emitted as
<Input Type="checkbox" CHECKED>
and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed for me on <td nowrap>. I think one of the XalanC commiters should advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
Brian Minchau and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled, ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANC-519) HTML serialization should reduce "boolean attributes" regardless of how created
Posted by "David Marston (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANC-519?page=comments#action_65757 ]
David Marston commented on XALANC-519:
--------------------------------------
Yes, we pass the existing test cases. The issue is that the test cases don't cover all possible ways to create an attribute. The problem showed up in a stylesheet that uses xsl:copy-of on the enclosing element.
> HTML serialization should reduce "boolean attributes" regardless of how created
> -------------------------------------------------------------------------------
>
> Key: XALANC-519
> URL: http://issues.apache.org/jira/browse/XALANC-519
> Project: XalanC
> Type: Bug
> Components: XalanC
> Reporter: David Marston
> Priority: Minor
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed for me on <td nowrap>. I think one of the XalanC commiters should advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Brian Minchau and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled, ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANC-519) HTML serialization should reduce "boolean attributes" regardless of how created
Posted by "David Bertoni (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANC-519?page=comments#action_65707 ]
David Bertoni commented on XALANC-519:
--------------------------------------
I don't know which version of Xalan-C you're testing, but with 1.9, I get the following result with attribset17
<HTML>
<Form>Zoneone
<Input Type="checkbox" CHECKED>
</Form>
</HTML>
So, can you please be more explicit about what the bug is, and what output you're seeing?
> HTML serialization should reduce "boolean attributes" regardless of how created
> -------------------------------------------------------------------------------
>
> Key: XALANC-519
> URL: http://issues.apache.org/jira/browse/XALANC-519
> Project: XalanC
> Type: Bug
> Components: XalanC
> Reporter: David Marston
> Priority: Minor
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed for me on <td nowrap>. I think one of the XalanC commiters should advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Brian Minchau and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled, ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANC-519) HTML serialization should reduce "boolean attributes" regardless of how created
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANC-519?page=comments#action_65730 ]
Brian Minchau commented on XALANC-519:
--------------------------------------
In case the person who fixes this is looking, the complete list of valueless attributes, and which HTML element they can appear on is in bug XALANJ-2121. (at least Henry, Dave and I think it is complete).
> HTML serialization should reduce "boolean attributes" regardless of how created
> -------------------------------------------------------------------------------
>
> Key: XALANC-519
> URL: http://issues.apache.org/jira/browse/XALANC-519
> Project: XalanC
> Type: Bug
> Components: XalanC
> Reporter: David Marston
> Priority: Minor
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed for me on <td nowrap>. I think one of the XalanC commiters should advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Brian Minchau and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled, ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Assigned: (XALANC-519) HTML serialization should reduce "boolean attributes" regardless of how created
Posted by "David Bertoni (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANC-519?page=all ]
David Bertoni reassigned XALANC-519:
------------------------------------
Assign To: David Bertoni
> HTML serialization should reduce "boolean attributes" regardless of how created
> -------------------------------------------------------------------------------
>
> Key: XALANC-519
> URL: http://issues.apache.org/jira/browse/XALANC-519
> Project: XalanC
> Type: Bug
> Components: XalanC
> Reporter: David Marston
> Assignee: David Bertoni
> Priority: Minor
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed for me on <td nowrap>. I think one of the XalanC commiters should advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Brian Minchau and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled, ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANC-519) HTML serialization should reduce "boolean attributes" regardless of how created
Posted by "David Marston (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANC-519?page=comments#action_65882 ]
David Marston commented on XALANC-519:
--------------------------------------
I am using 1.9.0.
=========== stylesheet:
<?xml version="1.0" encoding="utf-8"?>
<xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
version="1.0">
<xsl:output method="html" encoding="ascii" indent="yes"/>
<xsl:template match="/">
<html>
<body bgcolor="#FFFFFF">
<xsl:copy-of select="*" />
</body>
</html>
</xsl:template>
</xsl:stylesheet>
=========== input:
<!-- copy a td with nowrap -->
<a><td nowrap="nowrap"></td></a>
=========== produces this output:
<html>
<body bgcolor="#FFFFFF">
<a><td nowrap="nowrap"></td></a>
</body>
</html>
> HTML serialization should reduce "boolean attributes" regardless of how created
> -------------------------------------------------------------------------------
>
> Key: XALANC-519
> URL: http://issues.apache.org/jira/browse/XALANC-519
> Project: XalanC
> Type: Bug
> Components: XalanC
> Reporter: David Marston
> Priority: Minor
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed for me on <td nowrap>. I think one of the XalanC commiters should advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Brian Minchau and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled, ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Updated: (XALANC-519) HTML serialization should reduce "boolean attributes" regardless of how created
Posted by "David Bertoni (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANC-519?page=all ]
David Bertoni updated XALANC-519:
---------------------------------
Attachment: test1.xml
> HTML serialization should reduce "boolean attributes" regardless of how created
> -------------------------------------------------------------------------------
>
> Key: XALANC-519
> URL: http://issues.apache.org/jira/browse/XALANC-519
> Project: XalanC
> Type: Bug
> Components: XalanC
> Reporter: David Marston
> Assignee: David Bertoni
> Priority: Minor
> Attachments: patch.txt, test1.xml
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed for me on <td nowrap>. I think one of the XalanC commiters should advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Brian Minchau and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled, ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Updated: (XALANC-519) HTML serialization should reduce "boolean attributes" regardless of how created
Posted by "David Bertoni (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANC-519?page=all ]
David Bertoni updated XALANC-519:
---------------------------------
Attachment: patch.txt
> HTML serialization should reduce "boolean attributes" regardless of how created
> -------------------------------------------------------------------------------
>
> Key: XALANC-519
> URL: http://issues.apache.org/jira/browse/XALANC-519
> Project: XalanC
> Type: Bug
> Components: XalanC
> Reporter: David Marston
> Assignee: David Bertoni
> Priority: Minor
> Attachments: patch.txt, test1.xml
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed for me on <td nowrap>. I think one of the XalanC commiters should advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Brian Minchau and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled, ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANC-519) HTML serialization should reduce "boolean attributes" regardless of how created
Posted by "David Bertoni (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANC-519?page=comments#action_65802 ]
David Bertoni commented on XALANC-519:
--------------------------------------
OK, so I ran the following inputs using Xalan-C 1.9:
<?xml version="1.0"?>
<xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" version="1.0">
<xsl:output method="html" indent="no" />
<xsl:template match="doc">
<HTML>
<xsl:copy-of select="Input"/>
<Input Type="checkbox">
<xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
</Input>
</HTML>
</xsl:template>
</xsl:stylesheet>
<?xml version="1.0"?>
<doc>
<Input Type="checkbox" CHECKED="" />
</doc>
The result I get is:
<HTML><Input Type="checkbox" CHECKED><Input Type="checkbox" CHECKED></HTML>
which what I expect. Can you please attach the set of inputs that reproduces the problem you're seeing?
> HTML serialization should reduce "boolean attributes" regardless of how created
> -------------------------------------------------------------------------------
>
> Key: XALANC-519
> URL: http://issues.apache.org/jira/browse/XALANC-519
> Project: XalanC
> Type: Bug
> Components: XalanC
> Reporter: David Marston
> Priority: Minor
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed for me on <td nowrap>. I think one of the XalanC commiters should advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Brian Minchau and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled, ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Updated: (XALANC-519) HTML serialization should reduce "boolean attributes" regardless of how created
Posted by "David Bertoni (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANC-519?page=all ]
David Bertoni updated XALANC-519:
---------------------------------
Attachment: test1.xsl
I have attached a patch and a set of inputs for testing. Committers, can you please review?
> HTML serialization should reduce "boolean attributes" regardless of how created
> -------------------------------------------------------------------------------
>
> Key: XALANC-519
> URL: http://issues.apache.org/jira/browse/XALANC-519
> Project: XalanC
> Type: Bug
> Components: XalanC
> Reporter: David Marston
> Assignee: David Bertoni
> Priority: Minor
> Attachments: patch.txt, test1.xml, test1.xsl
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed for me on <td nowrap>. I think one of the XalanC commiters should advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Brian Minchau and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled, ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Resolved: (XALANC-519) HTML serialization should reduce "boolean attributes" regardless of how created
Posted by "David Bertoni (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANC-519?page=all ]
David Bertoni resolved XALANC-519:
----------------------------------
Resolution: Fixed
Fix Version: CurrentCVS
> HTML serialization should reduce "boolean attributes" regardless of how created
> -------------------------------------------------------------------------------
>
> Key: XALANC-519
> URL: http://issues.apache.org/jira/browse/XALANC-519
> Project: XalanC
> Type: Bug
> Components: XalanC
> Reporter: David Marston
> Assignee: David Bertoni
> Priority: Minor
> Fix For: CurrentCVS
> Attachments: patch.txt, test1.xml, test1.xsl
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed for me on <td nowrap>. I think one of the XalanC commiters should advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Brian Minchau and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled, ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org