You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "mrproliu (via GitHub)" <gi...@apache.org> on 2024/08/19 00:13:40 UTC
[PR] Support sort queries on metrics generated by eBPF receiver [skywalking]
mrproliu opened a new pull request, #12539:
URL: https://github.com/apache/skywalking/pull/12539
For now, the metrics generated by the eBPF receiver cannot be using `top_n` queries in MQE, so I updated the sources to support this feature. And delete the useless endpoint relation.
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support sort queries on metrics generated by eBPF receiver [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12539:
URL: https://github.com/apache/skywalking/pull/12539#discussion_r1721106906
##########
docs/en/concepts-and-designs/scope-definitions.md:
##########
@@ -529,9 +529,9 @@ following **package**/**protocol** level metric contents.
| destServiceInstanceName | The dest pod name in kubernetes. | | string |
| destLayer | The dest layer service in kubernetes. | | string |
-#### Endpoint and Endpoint Relation
+#### Endpoint
Review Comment:
`DefaultScopeDefine#K8S_ENDPOINT_REALATION(ID=77)` should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support sort queries on metrics generated by eBPF receiver [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12539:
URL: https://github.com/apache/skywalking/pull/12539#discussion_r1721107421
##########
oap-server/server-receiver-plugin/skywalking-ebpf-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/ebpf/provider/handler/AccessLogServiceHandler.java:
##########
@@ -648,26 +647,6 @@ public K8SEndpoint toEndpoint(String endpointName, boolean success, long duratio
return endpoint;
}
- public K8SEndpointRelation toEndpointRelation(String endpointName, boolean success) {
Review Comment:
What was this building? API between client side and server side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support sort queries on metrics generated by eBPF receiver [skywalking]
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu merged PR #12539:
URL: https://github.com/apache/skywalking/pull/12539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support sort queries on metrics generated by eBPF receiver [skywalking]
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on code in PR #12539:
URL: https://github.com/apache/skywalking/pull/12539#discussion_r1721109713
##########
oap-server/server-receiver-plugin/skywalking-ebpf-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/ebpf/provider/handler/AccessLogServiceHandler.java:
##########
@@ -648,26 +647,6 @@ public K8SEndpoint toEndpoint(String endpointName, boolean success, long duratio
return endpoint;
}
- public K8SEndpointRelation toEndpointRelation(String endpointName, boolean success) {
Review Comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support sort queries on metrics generated by eBPF receiver [skywalking]
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on code in PR #12539:
URL: https://github.com/apache/skywalking/pull/12539#discussion_r1721109500
##########
docs/en/concepts-and-designs/scope-definitions.md:
##########
@@ -529,9 +529,9 @@ following **package**/**protocol** level metric contents.
| destServiceInstanceName | The dest pod name in kubernetes. | | string |
| destLayer | The dest layer service in kubernetes. | | string |
-#### Endpoint and Endpoint Relation
+#### Endpoint
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org