[jira] [Commented] (HADOOP-9669) There are multiple array creations and array copies for a single nfs rpc reply

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-9669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767174#comment-13767174 ] 

Hadoop QA commented on HADOOP-9669:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12603124/HADOOP-9669.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The following test timeouts occurred in hadoop-common-project/hadoop-nfs:

org.apache.hadoop.oncrpc.TestFrameDecoder

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3096//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3096//console

This message is automatically generated.
                
> There are multiple array creations and array copies for a single nfs rpc reply
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-9669
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9669
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: nfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Haohui Mai
>         Attachments: HADOOP-9669.patch
>
>
> XDR.writeXxx(..) methods ultimately use the static XDR.append(..) for writing each data type.  The static append creates a new array and copy data.  Therefore, for a singe reply such as RpcAcceptedReply.voidReply(..), there are multiple array creations and array copies.  For example, there are at least 6 array creations and array copies for RpcAcceptedReply.voidReply(..).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira