You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "ShauryaChauhan1411 (via GitHub)" <gi...@apache.org> on 2026/03/07 19:34:03 UTC
[PR] [WIP][Table Model] Support DESCRIBE QUERY for relational metadata extraction [iotdb]
ShauryaChauhan1411 opened a new pull request, #17270:
URL: https://github.com/apache/iotdb/pull/17270
Hi @JackieTien97,
I have implemented the initial framework for DESCRIBE QUERY in the Table Model. This PR includes:
Grammar Support: Added DESCRIBE QUERY syntax in RelationalSql.g4.
AST Node: Created the DescribeQuery class to represent the statement.
Analyzer Integration: Updated StatementAnalyzer to handle DescribeQuery. It now correctly extracts the output symbols and types from the underlying query.
Validation: Verified the logic with debug logs; it correctly identifies columns and their types for relational queries.
The local build is successful (BUILD SUCCESS).
Next Steps:
1. Implement DescribeOperator to return the metadata in a tabular format.
2. Integrate the operator into the LogicalPlanner.
Please let me know your initial thoughts on this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP][Table Model] Support DESCRIBE QUERY for relational metadata extraction [iotdb]
Posted by "ShauryaChauhan1411 (via GitHub)" <gi...@apache.org>.
ShauryaChauhan1411 commented on PR #17270:
URL: https://github.com/apache/iotdb/pull/17270#issuecomment-4018414744
Hi @JackieTien97, thank you so much for the detailed guidance! I'm glad to know I can use TableModelStatementMemorySourceVisitor instead of creating a new operator. I will look into QueryExecution.start() and the skipExecute logic as you suggested. I'll also send an email to the dev mail list right away. Thanks for the support!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP][Table Model] Support DESCRIBE QUERY for relational metadata extraction [iotdb]
Posted by "ShauryaChauhan1411 (via GitHub)" <gi...@apache.org>.
ShauryaChauhan1411 commented on PR #17270:
URL: https://github.com/apache/iotdb/pull/17270#issuecomment-4026109935
Hi @JackieTien97 , I have Updated the PR based on the feedback:
-Syntax Update: Changed the syntax to DESCRIBE <selectStatement> (removed the redundant QUERY keyword) to align with standard patterns.
-Code Cleanup: Removed all System.out.println debug statements and refined comments to remove AI-generated artifacts.
-Formatting: Ran mvn spotless:apply to ensure code style compliance.
-Verification: Verified the build with mvn clean install -DskipTests.
Ready for final review. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP][Table Model] Support DESCRIBE QUERY for relational metadata extraction [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 commented on PR #17270:
URL: https://github.com/apache/iotdb/pull/17270#issuecomment-4017844846
Hi @ShauryaChauhan1411 , thx for your contribution, just want to remind you that it's better to send an email in dev mail list to notify others in community before you start to work on this task.
And BTW, there is no need to add `DescribeOperator`, you can refer to `TableModelStatementMemorySourceVisitor`, and you should skip execution(including logical plan) after analyze phase. The first `skipExecute` call in QueryExecution.start() should return `true`, then the result should be constructed through constructResultForMemorySource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP][Table Model] Support DESCRIBE QUERY for relational metadata extraction [iotdb]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #17270:
URL: https://github.com/apache/iotdb/pull/17270#discussion_r2928344727
##########
iotdb-core/antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/IoTDBSqlParser.g4:
##########
@@ -1239,6 +1240,11 @@ explain
: EXPLAIN (ANALYZE VERBOSE?)? selectStatement?
;
+// ---- Describe
+describe
+ : DESCRIBE selectStatement
Review Comment:
`DESCRIBE selectStatement` is added to the grammar, but there is no corresponding handling in the statement AST construction (e.g., `org.apache.iotdb.db.queryengine.plan.parser.ASTVisitor` has no `visitDescribe(...)`). With the current visitor defaults, `DESCRIBE <select>` will be visited as just the inner `selectStatement`, effectively ignoring `DESCRIBE` and executing the query normally. Please add a dedicated Statement node + visitor handling so the DESCRIBE behavior is actually applied.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/memory/TableModelStatementMemorySourceVisitor.java:
##########
@@ -130,6 +130,61 @@ public StatementMemorySource visitCountDevice(
node.getTsBlock(context.getAnalysis()), node.getDataSetHeader());
}
+ @Override
+ public StatementMemorySource visitDescribeQuery(
+ org.apache.iotdb.db.queryengine.plan.relational.sql.ast.DescribeQuery node,
+ TableModelStatementMemorySourceContext context) {
+
Review Comment:
This `visitDescribeQuery` implementation uses many fully-qualified type names, which makes the code hard to read and is likely to violate the repository’s 100-char Checkstyle `LineLength` rule for non-import/package lines. Please switch to normal imports (as done elsewhere in this file) and rewrap long expressions to keep lines <= 100 chars.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/memory/TableModelStatementMemorySourceVisitor.java:
##########
@@ -130,6 +130,61 @@ public StatementMemorySource visitCountDevice(
node.getTsBlock(context.getAnalysis()), node.getDataSetHeader());
}
+ @Override
+ public StatementMemorySource visitDescribeQuery(
+ org.apache.iotdb.db.queryengine.plan.relational.sql.ast.DescribeQuery node,
+ TableModelStatementMemorySourceContext context) {
+
+ java.util.List<org.apache.iotdb.commons.schema.column.ColumnHeader> columnHeaders =
+ new java.util.ArrayList<>();
+ columnHeaders.add(
+ new org.apache.iotdb.commons.schema.column.ColumnHeader(
+ "Column", org.apache.tsfile.enums.TSDataType.TEXT));
+ columnHeaders.add(
+ new org.apache.iotdb.commons.schema.column.ColumnHeader(
+ "Type", org.apache.tsfile.enums.TSDataType.TEXT));
+
+ org.apache.iotdb.db.queryengine.common.header.DatasetHeader datasetHeader =
+ new org.apache.iotdb.db.queryengine.common.header.DatasetHeader(columnHeaders, true);
+
+ java.util.List<String> columnNames = new java.util.ArrayList<>();
+ java.util.List<String> columnTypes = new java.util.ArrayList<>();
+
+ context
+ .getAnalysis()
+ .getOutputDescriptor()
+ .getVisibleFields()
+ .forEach(
+ field -> {
+ columnNames.add(field.getName().orElse("unknown"));
+ columnTypes.add(field.getType().toString());
+ });
+
+ org.apache.tsfile.read.common.block.TsBlockBuilder builder =
+ new org.apache.tsfile.read.common.block.TsBlockBuilder(
+ java.util.Arrays.asList(
+ org.apache.tsfile.enums.TSDataType.TEXT, org.apache.tsfile.enums.TSDataType.TEXT));
+
+ for (int i = 0; i < columnNames.size(); i++) {
+ builder.getTimeColumnBuilder().writeLong(0);
+
+ builder
+ .getColumnBuilder(0)
+ .writeBinary(
+ new org.apache.tsfile.utils.Binary(
+ columnNames.get(i).getBytes(java.nio.charset.StandardCharsets.UTF_8)));
+ builder
+ .getColumnBuilder(1)
+ .writeBinary(
+ new org.apache.tsfile.utils.Binary(
+ columnTypes.get(i).getBytes(java.nio.charset.StandardCharsets.UTF_8)));
Review Comment:
When building the TsBlock here, you manually convert `String` to `byte[]` with `StandardCharsets.UTF_8` and then wrap it in `Binary`. Elsewhere in the codebase, memory-source blocks typically use `new Binary(str, TSFileConfig.STRING_CHARSET)` (avoids an extra allocation and keeps charset consistent). Please align with that pattern here.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/DescribeQuery.java:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License"); you may not use this file except in compliance
Review Comment:
The ASF license header is malformed: it currently reads `Version 2.0 (the` followed by `License");` (missing the opening quote before License). Please fix the header to match the standard form used in the rest of the project.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/QueryExecution.java:
##########
@@ -252,7 +252,7 @@ private ExecutionResult retry() {
}
private boolean skipExecute() {
- return analysis.canSkipExecute(context);
+ return analysis.isFailed() || analysis.isFinishQueryAfterAnalyze();
Review Comment:
`skipExecute()` no longer delegates to `analysis.canSkipExecute(context)`. This drops the non-relational analysis logic that skips execution for queries without a data source (see `org.apache.iotdb.db.queryengine.plan.analyze.Analysis#canSkipExecute`), and may cause unnecessary planning/execution work (or behavior changes) for such queries. Please keep using `analysis.canSkipExecute(context)` (or re-implement the missing conditions here) so the skip semantics remain consistent across analysis implementations.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/datastructure/tv/ElasticSerializableTVList.java:
##########
@@ -284,4 +285,15 @@ public SerializableTVList get(int targetIndex) throws IOException {
return internalTVList.get(targetIndex);
}
}
+
+ private Column ensureTimeColumn(Column column) {
+ if (column instanceof TimeColumn) {
+ return column;
+ }
+ long[] times = new long[column.getPositionCount()];
+ for (int i = 0; i < times.length; i++) {
+ times[i] = column.getLong(i);
+ }
+ return new TimeColumn(column.getPositionCount(), times);
+ }
Review Comment:
`ensureTimeColumn` copies the entire column by calling `getLong(i)` in a loop. If this is only needed to satisfy `TsBlock`/serde requiring a concrete `TimeColumn`, consider documenting that requirement here (and ideally keep the return type as `TimeColumn`) so callers understand why a copy is necessary and don’t accidentally introduce extra copies elsewhere.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/AstVisitor.java:
##########
@@ -449,6 +449,10 @@ protected R visitDescribeTable(DescribeTable node, C context) {
return visitStatement(node, context);
}
+ protected R visitDescribeQuery(DescribeQuery node, C context) {
+ return visitStatement(node, context);
+ }
Review Comment:
Adding `visitDescribeQuery` to `AstVisitor` is not sufficient on its own: visitors like `SqlFormatter` have a `visitNode` fallback that throws `UnsupportedOperationException`, and there is currently no `visitDescribeQuery` override there. Without adding formatter/traversal support, formatting/logging a `DescribeQuery` will crash at runtime. Please implement `visitDescribeQuery` in `SqlFormatter` (and any traversal visitors) to process/print the wrapped query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP][Table Model] Support DESCRIBE QUERY for relational metadata extraction [iotdb]
Posted by "ShauryaChauhan1411 (via GitHub)" <gi...@apache.org>.
ShauryaChauhan1411 commented on PR #17270:
URL: https://github.com/apache/iotdb/pull/17270#issuecomment-4069441409
Hi @JackieTien97,
I have addressed all the feedback and aligned the implementation with the project standards. Here is a summary of the changes:
1.Header Alignment: Aligned DESCRIBE TABLE headers with DuckDB standard (column_name, column_type) in ColumnHeaderConstant and Visitor.
2.Binary Constructor: Fixed the Binary object creation pattern to use TSFileConfig.STRING_CHARSET instead of .getBytes(), as requested.
3.Integration Test: Added a new IT class IoTDBDescribeTableIT in the integration-test module to verify the fix.
4.Cleanup: Reverted unrelated changes in grammar and other utility files to keep the PR clean.
Local mvn clean compile and spotless:apply are passing successfully. Ready for your final review and merge.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP][Table Model] Support DESCRIBE QUERY for relational metadata extraction [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 commented on code in PR #17270:
URL: https://github.com/apache/iotdb/pull/17270#discussion_r2928334169
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/QueryExecution.java:
##########
@@ -252,7 +252,7 @@ private ExecutionResult retry() {
}
private boolean skipExecute() {
- return analysis.canSkipExecute(context);
+ return analysis.isFailed() || analysis.isFinishQueryAfterAnalyze();
Review Comment:
why do this change?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/memory/TableModelStatementMemorySourceVisitor.java:
##########
@@ -130,6 +130,61 @@ public StatementMemorySource visitCountDevice(
node.getTsBlock(context.getAnalysis()), node.getDataSetHeader());
}
+ @Override
+ public StatementMemorySource visitDescribeQuery(
+ org.apache.iotdb.db.queryengine.plan.relational.sql.ast.DescribeQuery node,
+ TableModelStatementMemorySourceContext context) {
+
+ java.util.List<org.apache.iotdb.commons.schema.column.ColumnHeader> columnHeaders =
+ new java.util.ArrayList<>();
+ columnHeaders.add(
+ new org.apache.iotdb.commons.schema.column.ColumnHeader(
+ "Column", org.apache.tsfile.enums.TSDataType.TEXT));
+ columnHeaders.add(
+ new org.apache.iotdb.commons.schema.column.ColumnHeader(
+ "Type", org.apache.tsfile.enums.TSDataType.TEXT));
Review Comment:
you should read more about duckdb's definition, `column_name` and `column_type` should be the column headers. And their type should be `STRING`.
And these constants should be defined in `ColumnHeaderConstant` class
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/datastructure/tv/ElasticSerializableTVList.java:
##########
Review Comment:
changes to this class is unrelated to this feature, don't include them.
##########
iotdb-core/antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/IoTDBSqlParser.g4:
##########
@@ -1239,6 +1240,11 @@ explain
: EXPLAIN (ANALYZE VERBOSE?)? selectStatement?
;
+// ---- Describe
+describe
+ : DESCRIBE selectStatement
+ ;
+
Review Comment:
we only need to support it in table model, this g4 file is for tree model
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP][Table Model] Support DESCRIBE QUERY for relational metadata extraction [iotdb]
Posted by "ShauryaChauhan1411 (via GitHub)" <gi...@apache.org>.
ShauryaChauhan1411 commented on PR #17270:
URL: https://github.com/apache/iotdb/pull/17270#issuecomment-4019170323
Hi @JackieTien, I have updated the PR with the final integration logic.
Key Changes:
1. Implemented skipExecute() in QueryExecution to bypass full execution for DescribeQuery.
2. Integrated TableModelStatementMemorySourceVisitor to return metadata in TsBlock format.
3. Verified the implementation with mvn clean install -DskipTests (Build Successful).
Looking forward to your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP][Table Model] Support DESCRIBE QUERY for relational metadata extraction [iotdb]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #17270:
URL: https://github.com/apache/iotdb/pull/17270#discussion_r2901003444
##########
iotdb-core/relational-grammar/src/main/antlr4/org/apache/iotdb/db/relational/grammar/sql/RelationalSql.g4:
##########
@@ -914,6 +914,7 @@ queryStatement
: query #statementDefault
| EXPLAIN query #explain
| EXPLAIN ANALYZE VERBOSE? query #explainAnalyze
+ | DESCRIBE QUERY query #describeQuery
Review Comment:
`DESCRIBE QUERY` is added to the grammar, but there is no corresponding AST builder override (e.g., in `AstBuilder`) to construct a `DescribeQuery` node. With the default ANTLR visitor behavior, this alternative will likely return the inner `query` AST directly, causing `DESCRIBE QUERY ...` to execute the query instead of describing it. Add an `AstBuilder#visitDescribeQuery(...)` that wraps the parsed `query` in the new `DescribeQuery` statement.
```suggestion
```
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java:
##########
@@ -850,6 +851,22 @@ protected Scope visitExplain(Explain node, Optional<Scope> context) {
return visitQuery((Query) node.getStatement(), context);
}
+ @Override
+ protected Scope visitDescribeQuery(DescribeQuery node, Optional<Scope> context) {
+ analysis.setFinishQueryAfterAnalyze();
+ Scope scope = visitQuery(node.getQuery(), context);
+
+ RelationType outputDescriptor = analysis.getOutputDescriptor();
+ for (Field field : outputDescriptor.getVisibleFields()) {
+ String name = field.getName().orElse("unknown");
+ String type = field.getType().toString();
+ System.out.println("DESCRIBE_DEBUG: Column=" + name + ", Type=" + type);
+ }
+
Review Comment:
`visitDescribeQuery` calls `analysis.getOutputDescriptor()` after analyzing the inner query, but the analysis scope is set on `node.getQuery()` (see `visitQuery`), not on the `DescribeQuery` statement node. This will throw when `Analysis` tries to resolve the root scope. Use `analysis.getOutputDescriptor(node.getQuery())` (or the returned `scope`) and also assign a scope to the `DescribeQuery` node if it is the root statement.
```suggestion
// Retrieve output descriptor for the analyzed inner query
RelationType outputDescriptor = analysis.getOutputDescriptor(node.getQuery());
for (Field field : outputDescriptor.getVisibleFields()) {
String name = field.getName().orElse("unknown");
String type = field.getType().toString();
System.out.println("DESCRIBE_DEBUG: Column=" + name + ", Type=" + type);
}
// Assign a scope to the DescribeQuery node when it is the root statement
if (!context.isPresent()) {
analysis.setScope(node, scope);
}
```
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/DescribeQuery.java:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.queryengine.plan.relational.sql.ast;
+
+import com.google.common.collect.ImmutableList;
+import org.apache.tsfile.utils.RamUsageEstimator;
+
+import java.util.List;
+import java.util.Objects;
+
+import static java.util.Objects.requireNonNull;
+
+public class DescribeQuery extends Statement {
+
+ private static final long INSTANCE_SIZE =
+ RamUsageEstimator.shallowSizeOfInstance(DescribeQuery.class);
+
+ private final Query query;
+
+ public DescribeQuery(NodeLocation location, Query query) {
+ super(requireNonNull(location, "location is null"));
+ this.query = requireNonNull(query, "query is null");
+ }
+
+ public Query getQuery() {
+ return query;
+ }
+
+ @Override
+ public <R, C> R accept(AstVisitor<R, C> visitor, C context) {
+ return visitor.visitDescribeQuery(this, context);
+ }
+
+ @Override
+ public List<Node> getChildren() {
+ return ImmutableList.of(query);
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (this == obj) return true;
+ if (obj == null || getClass() != obj.getClass()) return false;
Review Comment:
`equals` uses single-line `if` statements without braces (e.g., `if (this == obj) return true;`). This violates the repo Checkstyle `NeedBraces` rule and will fail style checks. Add braces for these conditionals.
```suggestion
if (this == obj) {
return true;
}
if (obj == null || getClass() != obj.getClass()) {
return false;
}
```
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java:
##########
@@ -850,6 +851,22 @@ protected Scope visitExplain(Explain node, Optional<Scope> context) {
return visitQuery((Query) node.getStatement(), context);
}
+ @Override
+ protected Scope visitDescribeQuery(DescribeQuery node, Optional<Scope> context) {
+ analysis.setFinishQueryAfterAnalyze();
+ Scope scope = visitQuery(node.getQuery(), context);
+
+ RelationType outputDescriptor = analysis.getOutputDescriptor();
+ for (Field field : outputDescriptor.getVisibleFields()) {
+ String name = field.getName().orElse("unknown");
+ String type = field.getType().toString();
+ System.out.println("DESCRIBE_DEBUG: Column=" + name + ", Type=" + type);
+ }
Review Comment:
Avoid `System.out.println` in the analyzer path. This will write to stdout for every DESCRIBE and can be noisy in production; use the project logger at an appropriate level or store the extracted column metadata in `Analysis` for the planner/operator to consume instead of printing.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/DescribeQuery.java:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License"); you may not use this file except in compliance
Review Comment:
The Apache license header looks malformed: it currently reads `Version 2.0 (the` followed by `License");` (missing the opening quote before License). Please fix the header to match the standard `... (the "License"); ...` form used elsewhere in the codebase.
```suggestion
* "License"); you may not use this file except in compliance
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP][Table Model] Support DESCRIBE QUERY for relational metadata extraction [iotdb]
Posted by "ShauryaChauhan1411 (via GitHub)" <gi...@apache.org>.
ShauryaChauhan1411 commented on PR #17270:
URL: https://github.com/apache/iotdb/pull/17270#issuecomment-4056248391
Hi @JackieTien97, thank you for the detailed review! I've noted the points regarding DuckDB compatibility for column headers and the need for IT/UT.
I will:
1- Add the required Integration and Unit tests.
2- Fix the column header constants and types.
3- Revert the unrelated changes in IoTDBSqlParser.g4 and ElasticSerializableTVList.
I'll update the PR once these changes are ready. Thanks for the guidance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org