[GitHub] [superset] graceguo-supercat commented on pull request #17604: feat(alerts): Column for select tabs to send

[GitBox <gi...@apache.org>]

graceguo-supercat commented on pull request #17604:
URL: https://github.com/apache/superset/pull/17604#issuecomment-984197866


   @m-ajay Thanks for the work! 
   Currently, we want to enrich the email report feature with dashboard tab selection. But in the very near future, we might want to enrich the report with filter set selection, or dashboard_owners etc. So i think all these extra configuration for a report, could be stored in the same column that you will add today.
   
   So how about name this column as `extra_config`, column type `Text` is good, and will populate an empty json `{}` text as default data?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org