You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ah...@apache.org on 2017/06/07 05:19:58 UTC
[1/3] git commit: [flex-asjs] [refs/heads/release0.8.0] - fix up last
commit so binding works
Repository: flex-asjs
Updated Branches:
refs/heads/release0.8.0 66d37b078 -> 66cae512d
fix up last commit so binding works
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/66cae512
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/66cae512
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/66cae512
Branch: refs/heads/release0.8.0
Commit: 66cae512dae912686fbc679899e42c99f6755aed
Parents: b659ff4
Author: Alex Harui <ah...@apache.org>
Authored: Tue Jun 6 22:20:09 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Tue Jun 6 22:20:16 2017 -0700
----------------------------------------------------------------------
.../org/apache/flex/html/beads/NumericStepperView.as | 2 +-
.../html/beads/controllers/SliderMouseController.as | 12 ++++++------
.../html/beads/controllers/SpinnerMouseController.as | 4 ++--
.../org/apache/flex/html/beads/models/RangeModel.as | 4 ++--
.../apache/flex/html/beads/models/RangeModelExtended.as | 2 +-
.../apache/flex/html/beads/models/ToggleButtonModel.as | 2 +-
.../flex/html/beads/models/ValueToggleButtonModel.as | 2 +-
7 files changed, 14 insertions(+), 14 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/66cae512/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/NumericStepperView.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/NumericStepperView.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/NumericStepperView.as
index 5ad42dc..807eef0 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/NumericStepperView.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/NumericStepperView.as
@@ -148,7 +148,7 @@ package org.apache.flex.html.beads
{
input.text = String(spinner.value);
- var newEvent:ValueChangeEvent = new ValueChangeEvent(event.type, false, false, event.oldValue, event.newValue);
+ var newEvent:ValueChangeEvent = ValueChangeEvent.createUpdateEvent(_strand, "value", event.oldValue, event.newValue);
IEventDispatcher(_strand).dispatchEvent(newEvent);
}
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/66cae512/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/controllers/SliderMouseController.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/controllers/SliderMouseController.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/controllers/SliderMouseController.as
index 9663aff..23942d0 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/controllers/SliderMouseController.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/controllers/SliderMouseController.as
@@ -141,7 +141,7 @@ package org.apache.flex.html.beads.controllers
UIBase(_strand).topMostEventDispatcher.removeEventListener(MouseEvent.MOUSE_MOVE, thumbMoveHandler);
UIBase(_strand).topMostEventDispatcher.removeEventListener(MouseEvent.MOUSE_UP, thumbUpHandler);
- var vce:ValueChangeEvent = new ValueChangeEvent("valueChange", false, false, oldValue, rangeModel.value);
+ var vce:ValueChangeEvent = ValueChangeEvent.createUpdateEvent(_strand, "value", oldValue, rangeModel.value);
IEventDispatcher(_strand).dispatchEvent(vce);
}
@@ -165,7 +165,7 @@ package org.apache.flex.html.beads.controllers
var p:Number = newX/sliderView.track.width;
var n:Number = p*(rangeModel.maximum - rangeModel.minimum) + rangeModel.minimum;
- var vce:ValueChangeEvent = new ValueChangeEvent("valueChange", false, false, rangeModel.value, n);
+ var vce:ValueChangeEvent = ValueChangeEvent.createUpdateEvent(_strand, "value", rangeModel.value, n);
rangeModel.value = n;
IEventDispatcher(_strand).dispatchEvent(vce);
@@ -185,7 +185,7 @@ package org.apache.flex.html.beads.controllers
var p:Number = xloc/sliderView.track.width;
var n:Number = p*(rangeModel.maximum - rangeModel.minimum) + rangeModel.minimum;
- var vce:ValueChangeEvent = new ValueChangeEvent("valueChange", false, false, rangeModel.value, n);
+ var vce:ValueChangeEvent = ValueChangeEvent.createUpdateEvent(_strand, "value", rangeModel.value, n);
rangeModel.value = n;
IEventDispatcher(_strand).dispatchEvent(vce);
@@ -202,7 +202,7 @@ package org.apache.flex.html.beads.controllers
var n:Number = p * (host.maximum - host.minimum) +
host.minimum;
- var vce:ValueChangeEvent = new ValueChangeEvent("valueChange", false, false, host.value, n);
+ var vce:ValueChangeEvent = ValueChangeEvent.createUpdateEvent(_strand, "value", host.value, n);
host.value = n;
origin = parseInt(thumb.element.style.left, 10);
@@ -247,7 +247,7 @@ package org.apache.flex.html.beads.controllers
handleThumbMove, false, this);
calcValFromMousePosition(event, false);
- var vce:ValueChangeEvent = new ValueChangeEvent("valueChange", false, false, oldValue, rangeModel.value);
+ var vce:ValueChangeEvent = ValueChangeEvent.createUpdateEvent(_strand, "value", oldValue, rangeModel.value);
host.dispatchEvent(vce);
}
@@ -262,7 +262,7 @@ package org.apache.flex.html.beads.controllers
var lastValue:Number = rangeModel.value;
calcValFromMousePosition(event, false);
- var vce:ValueChangeEvent = new ValueChangeEvent("valueChange", false, false, lastValue, rangeModel.value);
+ var vce:ValueChangeEvent = ValueChangeEvent.createUpdateEvent(_strand, "value", lastValue, rangeModel.value);
host.dispatchEvent(vce);
}
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/66cae512/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/controllers/SpinnerMouseController.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/controllers/SpinnerMouseController.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/controllers/SpinnerMouseController.as
index b228980..50b3997 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/controllers/SpinnerMouseController.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/controllers/SpinnerMouseController.as
@@ -111,7 +111,7 @@ package org.apache.flex.html.beads.controllers
{
var oldValue:Number = rangeModel.value;
rangeModel.value = Math.max(rangeModel.minimum, rangeModel.value - rangeModel.stepSize);
- var vce:ValueChangeEvent = new ValueChangeEvent("valueChange", false, false, oldValue, rangeModel.value);
+ var vce:ValueChangeEvent = ValueChangeEvent.createUpdateEvent(_strand, "value", oldValue, rangeModel.value);
IEventDispatcher(_strand).dispatchEvent(vce);
}
@@ -122,7 +122,7 @@ package org.apache.flex.html.beads.controllers
{
var oldValue:Number = rangeModel.value;
rangeModel.value = Math.min(rangeModel.maximum, rangeModel.value + rangeModel.stepSize);
- var vce:ValueChangeEvent = new ValueChangeEvent("valueChange", false, false, oldValue, rangeModel.value);
+ var vce:ValueChangeEvent = ValueChangeEvent.createUpdateEvent(_strand, "value", oldValue, rangeModel.value);
IEventDispatcher(_strand).dispatchEvent(vce);
}
}
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/66cae512/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/RangeModel.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/RangeModel.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/RangeModel.as
index ab86d03..24e2a3a 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/RangeModel.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/RangeModel.as
@@ -48,7 +48,7 @@ package org.apache.flex.html.beads.models
{
}
- private var _strand:IStrand;
+ protected var _strand:IStrand;
/**
* @copy org.apache.flex.core.IBead#strand
@@ -197,7 +197,7 @@ package org.apache.flex.html.beads.models
newValue = Math.min(maximum, newValue);
var oldValue:Number = _value;
_value = snap(newValue);
- dispatchEvent(new ValueChangeEvent("valueChange", false, false, oldValue, _value));
+ dispatchEvent(ValueChangeEvent.createUpdateEvent(_strand, "value", oldValue, _value));
}
}
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/66cae512/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/RangeModelExtended.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/RangeModelExtended.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/RangeModelExtended.as
index fad333e..54d268d 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/RangeModelExtended.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/RangeModelExtended.as
@@ -59,7 +59,7 @@ package org.apache.flex.html.beads.models
{
if (_value != newValue)
{
- var vce:ValueChangeEvent = new ValueChangeEvent("valueChange", false, false, _value, newValue);
+ var vce:ValueChangeEvent = ValueChangeEvent.createUpdateEvent(_strand, "value", _value, newValue);
_value = newValue;
dispatchEvent(vce);
}
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/66cae512/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/ToggleButtonModel.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/ToggleButtonModel.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/ToggleButtonModel.as
index a4c1a91..5273ffe 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/ToggleButtonModel.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/ToggleButtonModel.as
@@ -49,7 +49,7 @@ package org.apache.flex.html.beads.models
super();
}
- private var _strand:IStrand;
+ protected var _strand:IStrand;
/**
* @copy org.apache.flex.core.IBead#strand
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/66cae512/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/ValueToggleButtonModel.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/ValueToggleButtonModel.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/ValueToggleButtonModel.as
index e8fbc76..5fe9b99 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/ValueToggleButtonModel.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/models/ValueToggleButtonModel.as
@@ -69,7 +69,7 @@ package org.apache.flex.html.beads.models
{
if( newValue != _value )
{
- var vce:ValueChangeEvent = new ValueChangeEvent("valueChange", false, false, _value, newValue);
+ var vce:ValueChangeEvent = ValueChangeEvent.createUpdateEvent(_strand, "value", _value, newValue);
_value = newValue;
dispatchEvent(vce);
}
[3/3] git commit: [flex-asjs] [refs/heads/release0.8.0] - add binding
as well
Posted by ah...@apache.org.
add binding as well
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/3636ebbc
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/3636ebbc
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/3636ebbc
Branch: refs/heads/release0.8.0
Commit: 3636ebbc2b65fe1c00b8c737e2b629e1650f87fb
Parents: 66d37b0
Author: Alex Harui <ah...@apache.org>
Authored: Tue Jun 6 22:18:59 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Tue Jun 6 22:20:16 2017 -0700
----------------------------------------------------------------------
manualtests/FlexJSTest_Panel/src/MyInitialView.mxml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/3636ebbc/manualtests/FlexJSTest_Panel/src/MyInitialView.mxml
----------------------------------------------------------------------
diff --git a/manualtests/FlexJSTest_Panel/src/MyInitialView.mxml b/manualtests/FlexJSTest_Panel/src/MyInitialView.mxml
index 9909dda..aa431f8 100644
--- a/manualtests/FlexJSTest_Panel/src/MyInitialView.mxml
+++ b/manualtests/FlexJSTest_Panel/src/MyInitialView.mxml
@@ -132,7 +132,9 @@ limitations under the License.
}
</fx:Style>
-
+ <js:beads>
+ <js:ViewDataBinding />
+ </js:beads>
<js:Panel title="Example" x="300" width="300" y="50" height="250" className="panel1" showCloseButton="true">
<js:beads>
<js:VerticalLayout />
@@ -149,6 +151,7 @@ limitations under the License.
stepSize="10"/>
<js:Spacer height="10" />
<js:Label id="slideMe" text="slider value" />
+ <js:Label id="slideMe2" text="{slider.value}" />
<js:Slider id="slider" width="200"
valueChange="sliderChanged(slider)"
minimum="0"
[2/3] git commit: [flex-asjs] [refs/heads/release0.8.0] - Slider
wasn't supporting binding
Posted by ah...@apache.org.
Slider wasn't supporting binding
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/b659ff49
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/b659ff49
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/b659ff49
Branch: refs/heads/release0.8.0
Commit: b659ff49862889abca94cf438f0458f60a067a90
Parents: 3636ebb
Author: Alex Harui <ah...@apache.org>
Authored: Tue Jun 6 22:19:33 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Tue Jun 6 22:20:16 2017 -0700
----------------------------------------------------------------------
.../projects/Basic/src/main/flex/org/apache/flex/html/Slider.as | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/b659ff49/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/Slider.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/Slider.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/Slider.as
index fc2889b..c980fde 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/Slider.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/Slider.as
@@ -76,6 +76,7 @@ package org.apache.flex.html
* @playerversion AIR 2.6
* @productversion FlexJS 0.0
*/
+ [Bindable("valueChange")]
public function get value():Number
{
return IRangeModel(model).value;