[GitHub] [incubator-ratis] adoroszlai commented on a change in pull request #419: RATIS-1311. Upgrade Java for Sonar check

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #419:
URL: https://github.com/apache/incubator-ratis/pull/419#discussion_r572759158



##########
File path: .github/workflows/post-commit.yml
##########
@@ -151,3 +146,28 @@ jobs:
         - name: Delete temporary build artifacts
           run: rm -rf ~/.m2/repository/org/apache/ratis
           if: always()
+  sonar:
+    name: sonar
+    runs-on: ubuntu-18.04
+    if: github.repository == 'apache/incubator-ratis' && github.event_name != 'pull_request'

Review comment:
       Thanks @amaliujia for the review.  Yes, this will need to be updated if the repo is renamed to `ratis`.  Please note however, that this hard-coded name is already present on `master`:
   
   https://github.com/apache/incubator-ratis/blob/aa6c5ff4bad6425a7e1dd10a1f3e4f2f93f4050c/.github/workflows/post-commit.yml#L93-L94




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org