You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/09 09:52:46 UTC
[GitHub] [superset] villebro commented on a change in pull request #18633: fix(csv-export): pivot v2 with verbose names
villebro commented on a change in pull request #18633:
URL: https://github.com/apache/superset/pull/18633#discussion_r802475200
##########
File path: superset/charts/post_processing.py
##########
@@ -254,9 +269,9 @@ def pivot_table(df: pd.DataFrame, form_data: Dict[str, Any]) -> pd.DataFrame:
return pivot_df(
df,
- rows=form_data.get("groupby") or [],
- columns=form_data.get("columns") or [],
- metrics=[get_metric_name(m) for m in form_data["metrics"]],
+ rows=get_column_names(form_data.get("groupby"), verbose_map),
+ columns=get_column_names(form_data.get("columns"), verbose_map),
+ metrics=get_metric_names(form_data["metrics"]),
Review comment:
😱 Thanks for catching!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org