[GitHub] [kafka] mimaison commented on a diff in pull request #12965: KAFKA-14448 Let ZK brokers register with KRaft controller

[GitBox <gi...@apache.org>]

mimaison commented on code in PR #12965:
URL: https://github.com/apache/kafka/pull/12965#discussion_r1044340329


##########
metadata/src/main/java/org/apache/kafka/metadata/BrokerRegistration.java:
##########
@@ -234,6 +277,7 @@ public String toString() {
         bld.append(", rack=").append(rack);
         bld.append(", fenced=").append(fenced);
         bld.append(", inControlledShutdown=").append(inControlledShutdown);
+        bld.append(", isMigratingZkBroker=").append(isMigratingZkBroker);

Review Comment:
   We need to update `BrokerRegistrationTest.testToString()` too



##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -81,6 +84,19 @@ object KafkaServer {
     clientConfig
   }
 
+  def zkClient(name: String, time: Time, config: KafkaConfig, zkClientConfig: ZKClientConfig): KafkaZkClient = {
+    val secureAclsEnabled = config.zkEnableSecureAcls
+    val isZkSecurityEnabled = JaasUtils.isZkSaslEnabled || KafkaConfig.zkTlsClientAuthEnabled(zkClientConfig)
+
+    if (secureAclsEnabled && !isZkSecurityEnabled)
+      throw new java.lang.SecurityException(s"${KafkaConfig.ZkEnableSecureAclsProp} is true, but ZooKeeper client TLS configuration identifying at least $KafkaConfig.ZkSslClientEnableProp, $KafkaConfig.ZkClientCnxnSocketProp, and $KafkaConfig.ZkSslKeyStoreLocationProp was not present and the " +

Review Comment:
   It's missing curly brackets around some variables so this would not print them correctly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org