[GitHub] [incubator-superset] john-bodley commented on a change in pull request #11066: fix: fix table existence validation function

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #11066:
URL: https://github.com/apache/incubator-superset/pull/11066#discussion_r496289193



##########
File path: superset/connectors/sqla/models.py
##########
@@ -453,7 +453,7 @@ class SqlaTable(  # pylint: disable=too-many-public-methods,too-many-instance-at
     owner_class = security_manager.user_model
 
     __tablename__ = "tables"
-    __table_args__ = (UniqueConstraint("database_id", "table_name"),)
+    __table_args__ = (UniqueConstraint("database_id", "schema", "table_name"),)

Review comment:
       This will not work per https://github.com/apache/incubator-superset/pull/5449.

##########
File path: superset/connectors/sqla/models.py
##########
@@ -453,7 +453,7 @@ class SqlaTable(  # pylint: disable=too-many-public-methods,too-many-instance-at
     owner_class = security_manager.user_model
 
     __tablename__ = "tables"
-    __table_args__ = (UniqueConstraint("database_id", "table_name"),)
+    __table_args__ = (UniqueConstraint("database_id", "schema", "table_name"),)

Review comment:
       @bkyryliuk this will not work per https://github.com/apache/incubator-superset/pull/5449.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org