You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2014/05/01 09:10:15 UTC
Review Request 20937: FLUME-2181. Optionally disable file channel fsyncs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20937/
-----------------------------------------------------------

Review request for Flume and Brock Noland.


Bugs: FLUME-2181
    https://issues.apache.org/jira/browse/FLUME-2181


Repository: flume-git


Description
-------

Patch that allows users to optionally disable file channel fsync per transaction, and does it only when required.


Diffs
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/CheckpointRebuilder.java 4388181 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java 5203ca1 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java e4bc879 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 579ee35 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java 26a24b1 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileFactory.java 9c98d8c 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV2.java f286c57 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java 38f6ecb 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/ReplayHandler.java e668c2e 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/TransactionEventRecord.java ea7f00c 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/encryption/AESCTRNoPaddingProvider.java d0a84fe 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/encryption/DecryptionFailureException.java PRE-CREATION 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestCheckpointRebuilder.java 621d445 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java 25765b5 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java d1f51fc 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLogFile.java e5d830e 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestUtils.java 0fb9bc2 
  flume-tools/src/main/java/org/apache/flume/tools/FileChannelIntegrityTool.java aa24fa5 
  flume-tools/src/test/java/org/apache/flume/tools/TestFileChannelIntegrityTool.java d328671 

Diff: https://reviews.apache.org/r/20937/diff/


Testing
-------

All current tests pass. New tests added for new feature.


Thanks,

Hari Shreedharan