You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Wei Huang (Jira)" <ji...@apache.org> on 2023/04/21 01:16:00 UTC
[jira] [Updated] (YUNIKORN-1703) testMode is hardcoded to false in NewShimSchedulerForPlugin()
[ https://issues.apache.org/jira/browse/YUNIKORN-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wei Huang updated YUNIKORN-1703:
--------------------------------
Description:
At [https://github.com/apache/yunikorn-k8shim/blob/36040b40c50776e2200f51a85acbfc80aecd99f1/pkg/shim/scheduler.go#L80,] testMode is hard-coded to false, I think it should honor the testMode value set in configs:
{{apiFactory := client.NewAPIFactory(scheduler, informerFactory, configs, configs.TestMode)}}
was:
At [https://github.com/apache/yunikorn-k8shim/blob/36040b40c50776e2200f51a85acbfc80aecd99f1/pkg/shim/scheduler.go#L80,] testMode is hard-coded to false, I think we should honor the testMode value in
configs:
{{apiFactory := client.NewAPIFactory(scheduler, informerFactory, configs, configs.TestMode)}}
> testMode is hardcoded to false in NewShimSchedulerForPlugin()
> -------------------------------------------------------------
>
> Key: YUNIKORN-1703
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1703
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: shim - kubernetes
> Reporter: Wei Huang
> Priority: Trivial
>
> At [https://github.com/apache/yunikorn-k8shim/blob/36040b40c50776e2200f51a85acbfc80aecd99f1/pkg/shim/scheduler.go#L80,] testMode is hard-coded to false, I think it should honor the testMode value set in configs:
>
> {{apiFactory := client.NewAPIFactory(scheduler, informerFactory, configs, configs.TestMode)}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org