You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-commits@hadoop.apache.org by bo...@apache.org on 2011/03/03 20:32:03 UTC

svn commit: r1076745 - in /hadoop/hdfs/branches/HDFS-1052: CHANGES.txt src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestOverReplicatedBlocks.java

Author: boryas
Date: Thu Mar  3 19:32:03 2011
New Revision: 1076745

URL: http://svn.apache.org/viewvc?rev=1076745&view=rev
Log:
HDFS-1712. when looking up datanode we should use machineNmae (in testOverReplicatedBlocks) 

Modified:
    hadoop/hdfs/branches/HDFS-1052/CHANGES.txt
    hadoop/hdfs/branches/HDFS-1052/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestOverReplicatedBlocks.java

Modified: hadoop/hdfs/branches/HDFS-1052/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hdfs/branches/HDFS-1052/CHANGES.txt?rev=1076745&r1=1076744&r2=1076745&view=diff
==============================================================================
--- hadoop/hdfs/branches/HDFS-1052/CHANGES.txt (original)
+++ hadoop/hdfs/branches/HDFS-1052/CHANGES.txt Thu Mar  3 19:32:03 2011
@@ -167,6 +167,9 @@ Trunk (unreleased changes)
 
     HDFS-1711. create method for updating machine name in DataNode.java (boryas)
 
+    HDFS-1712. when looking up datanode we should use machineNmae 
+    (in testOverReplicatedBlocks) (boryas)
+
   IMPROVEMENTS
 
     HDFS-1510. Added test-patch.properties required by test-patch.sh (nigel)

Modified: hadoop/hdfs/branches/HDFS-1052/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestOverReplicatedBlocks.java
URL: http://svn.apache.org/viewvc/hadoop/hdfs/branches/HDFS-1052/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestOverReplicatedBlocks.java?rev=1076745&r1=1076744&r2=1076745&view=diff
==============================================================================
--- hadoop/hdfs/branches/HDFS-1052/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestOverReplicatedBlocks.java (original)
+++ hadoop/hdfs/branches/HDFS-1052/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestOverReplicatedBlocks.java Thu Mar  3 19:32:03 2011
@@ -85,9 +85,9 @@ public class TestOverReplicatedBlocks ex
       synchronized (namesystem.heartbeats) {
         // set live datanode's remaining space to be 0 
         // so they will be chosen to be deleted when over-replication occurs
+        String corruptMachineName = corruptDataNode.getName();
         for (DatanodeDescriptor datanode : namesystem.heartbeats) {
-          // TODO:FEDERATION - when comparing we either compare bpregistration or machine name only
-          if (!corruptDataNode.equals(datanode)) {
+          if (!corruptMachineName.equals(datanode.getName())) {
             datanode.updateHeartbeat(100L, 100L, 0L, 100L, 0);
           }
         }