You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2025/02/05 15:23:48 UTC
[PR] AIP-38 Add logical date to trigger DagRun form [airflow]
pierrejeambrun opened a new pull request, #46471:
URL: https://github.com/apache/airflow/pull/46471
Closes: https://github.com/apache/airflow/issues/46189
Needs https://github.com/apache/airflow/pull/46390 (to fix linting issue + make the feature functional)
Logical date is optional in the form and will send `null` to the API. It can be specified to any arbitrary date otherwise:
## Example Logical Date not specified
## Example Logical Date specified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-38 Add logical date to trigger DagRun form [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #46471:
URL: https://github.com/apache/airflow/pull/46471#discussion_r1943424042
##########
airflow/ui/src/queries/useTrigger.ts:
##########
@@ -73,6 +73,8 @@ export const useTrigger = ({ dagId, onSuccessConfirm }: { dagId: string; onSucce
? new Date(dagRunRequestBody.dataIntervalEnd)
: undefined;
+ const LogicalDate = dagRunRequestBody.logicalDate ? new Date(dagRunRequestBody.logicalDate) : undefined;
Review Comment:
Oh I didn't catch this before but all of these variables should start with a lower case letter.
Do you mind fixing it here and for dataIntervalStart and dataIntervalEnd?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-38 Add logical date to trigger DagRun form [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #46471:
URL: https://github.com/apache/airflow/pull/46471#issuecomment-2651345598
> Can we have some frontend magic to help user fill the fields since they are related to each other most of the time? Say
> If data interval fields are empty, fill them with logical date if it’s filled
> If logical date field is empty, fill it with data interval end or start if available (in this order)
It appears that we want to completely get rid of the `dataIntervalStart` and `dataIntervalEnd` in the trigger form. Updated accordingly in my last commit.
cc: @cmarteepants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-38 Add logical date to trigger DagRun form [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #46471:
URL: https://github.com/apache/airflow/pull/46471#discussion_r1950699853
##########
airflow/ui/src/queries/useTrigger.ts:
##########
@@ -73,6 +73,8 @@ export const useTrigger = ({ dagId, onSuccessConfirm }: { dagId: string; onSucce
? new Date(dagRunRequestBody.dataIntervalEnd)
: undefined;
+ const LogicalDate = dagRunRequestBody.logicalDate ? new Date(dagRunRequestBody.logicalDate) : undefined;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-38 Add logical date to trigger DagRun form [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #46471:
URL: https://github.com/apache/airflow/pull/46471#discussion_r1944916543
##########
airflow/ui/src/queries/useTrigger.ts:
##########
@@ -73,6 +73,8 @@ export const useTrigger = ({ dagId, onSuccessConfirm }: { dagId: string; onSucce
? new Date(dagRunRequestBody.dataIntervalEnd)
: undefined;
+ const LogicalDate = dagRunRequestBody.logicalDate ? new Date(dagRunRequestBody.logicalDate) : undefined;
Review Comment:
ofc I'll do that. True that's weird :p I naively followed the convention, but lower case is more appropriate :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-38 Add logical date to trigger DagRun form and remove dataInterval [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #46471:
URL: https://github.com/apache/airflow/pull/46471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-38 Add logical date to trigger DagRun form [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #46471:
URL: https://github.com/apache/airflow/pull/46471#issuecomment-2647213300
Can we have some frontend magic to help user fill the fields since they are related to each other most of the time? Say
* If data interval fields are empty, fill them with logical date if it’s filled
* If logical date field is empty, fill it with data interval end or start if available (in this order)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org