You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/18 00:13:53 UTC

[GitHub] [arrow] kou commented on a change in pull request #12448: ARROW-15700: [C++] Compilation error on Ubuntu 18.04

kou commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r809574416



##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -359,10 +359,19 @@ foreach(_VERSION_ENTRY ${TOOLCHAIN_VERSIONS_TXT})
     continue()
   endif()
 
-  # For debugging
-  message(STATUS "${_VARIABLE_NAME}: ${_VARIABLE_VALUE}")
+  # Allow values to be overridden to test specific versions during development

Review comment:
       This feature will be useful when when we use custom `ARROW_XXX_URL` environment variable to use other version.
   But mixing environment variables and CMake variables confuses us. So another approach may be better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org