You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Appy (JIRA)" <ji...@apache.org> on 2017/09/28 23:52:02 UTC

[jira] [Comment Edited] (HBASE-17441) precommit test "hadoopcheck" not properly testing Hadoop 3 profile

    [ https://issues.apache.org/jira/browse/HBASE-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185123#comment-16185123 ] 

Appy edited comment on HBASE-17441 at 9/28/17 11:51 PM:
--------------------------------------------------------

Great! That makes sense.
Maybe put up a bogus patch to test?
Probably just the FixedRelativePathCopyListing file from HBASE-18843 overriding just one function which uses DistCpOptions.  Since it has been replaced by DistCpContext in 3.0, our hadoop checks for 2.* should pass but for 3.0.0 should fail..
I'd suggest adding it to hbase-common so that it fails fast.


was (Author: appy):
Great! That makes sense.
Maybe put up a bogus patch to test?
Probably just the FixedRelativePathCopyListing file from HBASE-18843 overriding just one function which uses DistCpOptions (replaced by DistCpContext in 3.0).
I'd suggest adding it to hbase-common so that it fails fast.

> precommit test "hadoopcheck" not properly testing Hadoop 3 profile
> ------------------------------------------------------------------
>
>                 Key: HBASE-17441
>                 URL: https://issues.apache.org/jira/browse/HBASE-17441
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 2.0.0
>            Reporter: Sean Busbey
>            Assignee: Josh Elser
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17441.001.branch-2.patch, HBASE-17441.0.patch
>
>
> HBASE-14061 made a change that caused building against hadoop 3 to fail, but the hadoopcheck precommit test gave the change a +1.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)