You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bh...@apache.org on 2013/07/28 13:04:37 UTC
[1/3] git commit: Fixed error when checking for required parms that
are part of a map
Updated Branches:
refs/heads/master 6d4d2261a -> 9232d7e74
Fixed error when checking for required parms that are part of a map
Project: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/commit/924554fa
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/tree/924554fa
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/diff/924554fa
Branch: refs/heads/master
Commit: 924554fa2507818b7d77144c70e6bf5387b33175
Parents: 6d4d226
Author: Carson Anderson <ca...@betterservers.com>
Authored: Thu Jul 25 15:50:14 2013 -0600
Committer: Rohit Yadav <bh...@apache.org>
Committed: Sun Jul 28 16:15:20 2013 +0530
----------------------------------------------------------------------
cloudmonkey/cloudmonkey.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/blob/924554fa/cloudmonkey/cloudmonkey.py
----------------------------------------------------------------------
diff --git a/cloudmonkey/cloudmonkey.py b/cloudmonkey/cloudmonkey.py
index 13f54ad..ead939c 100644
--- a/cloudmonkey/cloudmonkey.py
+++ b/cloudmonkey/cloudmonkey.py
@@ -288,7 +288,7 @@ class CloudMonkeyShell(cmd.Cmd, object):
missing = []
if verb in self.apicache and subject in self.apicache[verb]:
- missing = filter(lambda x: x not in args_dict.keys(),
+ missing = filter(lambda x: x not in args_dict.keys() + [parm.split('[')[0] for parm in args_dict.keys()],
self.apicache[verb][subject]['requiredparams'])
if len(missing) > 0:
[3/3] git commit: docs: Fix README and Makefile
Posted by bh...@apache.org.
docs: Fix README and Makefile
Signed-off-by: Rohit Yadav <bh...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/commit/9232d7e7
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/tree/9232d7e7
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/diff/9232d7e7
Branch: refs/heads/master
Commit: 9232d7e74c1dd1982951c3fd6ecb10e2dbcddf8d
Parents: 9a6b5a9
Author: Rohit Yadav <bh...@apache.org>
Authored: Sun Jul 28 16:33:55 2013 +0530
Committer: Rohit Yadav <bh...@apache.org>
Committed: Sun Jul 28 16:33:55 2013 +0530
----------------------------------------------------------------------
Makefile | 3 +++
README.md | 27 +++++++++++++++++++++------
2 files changed, 24 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/blob/9232d7e7/Makefile
----------------------------------------------------------------------
diff --git a/Makefile b/Makefile
index 20c080c..b34e482 100644
--- a/Makefile
+++ b/Makefile
@@ -24,6 +24,9 @@ build:
python setup.py build
python setup.py sdist
+check:
+ pep8 cloudmonkey/*.py
+
buildcache:
python cloudmonkey/cachemaker.py
http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/blob/9232d7e7/README.md
----------------------------------------------------------------------
diff --git a/README.md b/README.md
index 45e611d..731b38f 100644
--- a/README.md
+++ b/README.md
@@ -1,32 +1,39 @@
## CloudMonkey
`cloudmonkey` is a command line interface for [Apache CloudStack](http://cloudstack.apache.org).
+CloudMonkey can be use both as an interactive shell and as a command line tool
+which simplifies Apache CloudStack configuration and management. It can be used
+with Apache CloudStack 4.0-incubating and above.
Build:
- make build
+ $ make build
Build Precache:
- make buildcache
+ $ make buildcache
+
+Check changes, code styles:
+
+ $ make check
Clean:
- make clean
+ $ make clean
Install:
- make install
+ $ make install
### For users
Install:
- pip install cloudmonkey
+ $ pip install cloudmonkey
Upgrade:
- pip install --upgrade cloudmonkey
+ $ pip install --upgrade cloudmonkey
Please see the [CloudMonkey Wiki](https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+cloudmonkey+CLI) for usage.
@@ -42,6 +49,14 @@ Please see the [CloudMonkey Wiki](https://cwiki.apache.org/confluence/display/CL
[Marketing Mailing List](mailto:marketing-subscribe@cloudstack.apache.org)
+### Contributing
+
+Send your patches on Apache [Review Board](https://reviews.apache.org/groups/cloudstack/)
+for CloudStack CloudMonkey.
+
+Discuss features development on the `Dev` mailing lists.
+Report issues on the `User` mailing list and open issue on [JIRA](http://issues.apache.org/jira/browse/CLOUDSTACK).
+
### License
Licensed to the Apache Software Foundation (ASF) under one
[2/3] git commit: cloudmonkey: Simplify missing parameter check
Posted by bh...@apache.org.
cloudmonkey: Simplify missing parameter check
This simplifies Carson Anderson's previous patch. We simply split by [ and take
the first element, if [ was not present we get the string/key itself.
Signed-off-by: Rohit Yadav <bh...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/commit/9a6b5a99
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/tree/9a6b5a99
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/diff/9a6b5a99
Branch: refs/heads/master
Commit: 9a6b5a99978a21410b1e5dc61d2c33e973a2f4b0
Parents: 924554f
Author: Rohit Yadav <bh...@apache.org>
Authored: Sun Jul 28 16:32:33 2013 +0530
Committer: Rohit Yadav <bh...@apache.org>
Committed: Sun Jul 28 16:32:33 2013 +0530
----------------------------------------------------------------------
cloudmonkey/cloudmonkey.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/blob/9a6b5a99/cloudmonkey/cloudmonkey.py
----------------------------------------------------------------------
diff --git a/cloudmonkey/cloudmonkey.py b/cloudmonkey/cloudmonkey.py
index ead939c..b465bec 100644
--- a/cloudmonkey/cloudmonkey.py
+++ b/cloudmonkey/cloudmonkey.py
@@ -288,7 +288,8 @@ class CloudMonkeyShell(cmd.Cmd, object):
missing = []
if verb in self.apicache and subject in self.apicache[verb]:
- missing = filter(lambda x: x not in args_dict.keys() + [parm.split('[')[0] for parm in args_dict.keys()],
+ missing = filter(lambda x: x not in [key.split('[')[0]
+ for key in args_dict],
self.apicache[verb][subject]['requiredparams'])
if len(missing) > 0: