[jira] [Commented] (SOLR-8354) RecoveryStrategy retry timing is innaccurate

["Ishan Chattopadhyaya (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032748#comment-15032748 ] 

Ishan Chattopadhyaya commented on SOLR-8354:
--------------------------------------------

Should we not, instead, change the comment to reflect what current behavior is? If the existing timeouts are working well, I don't think we should change the behavior without a real reason.

> RecoveryStrategy retry timing is innaccurate
> --------------------------------------------
>
>                 Key: SOLR-8354
>                 URL: https://issues.apache.org/jira/browse/SOLR-8354
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mike Drob
>         Attachments: SOLR-8354.patch
>
>
> At the end of {{RecoveryStrategy::doRecovery}} there is a retry segment, with a comment that suggests the code will {{// start at 1 sec and work up to a min}}. The code will actually start at 10 seconds, and work up to 5 minutes. Additionally, the log statement incorrectly reports how long the next wait will be. Either the comment and log should be corrected or the logic adjusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org