You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Davanum Srinivas <di...@yahoo.com> on 2002/02/27 21:26:38 UTC

Re: [PATCH] Replacement for maybeupload

Jeroen,

Thanks for the contribution. Checked it in...Please cross-check. I took some liberty of
cleaning-up/reformatting of the code and adding a few javadoc tags etc. 

Can you please take a look at the CVS? Also please submit patches to bugzilla
(http://nagoya.apache.org) if you want any changes to the code.

Thanks,
dims

--- Jeroen ter Voorde <j....@home.nl> wrote:
> Hi,
> 
> I've modified the code to use Davanums's componentized request wrapper code.
> I also added support to directly save files to disk optionally overwriting or 
> renaming existing files. So now it functions exactly the same as MaybeUpload 
> and no existing files had to be modified.
> 
> The patch isn't really a patch, it's just a tgz to be unpacked in the
> src/scratchpad/src/org/apache/cocoon/components/request directory.
> 
> Set the request factory in web.xml to use MultipartRequestFactory to enable 
> it.
> 
> Jeroen

> ATTACHMENT part 2 application/x-gzip name=multipartupload.tgz
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org


=====
Davanum Srinivas - http://jguru.com/dims/

__________________________________________________
Do You Yahoo!?
Yahoo! Greetings - Send FREE e-cards for every occasion!
http://greetings.yahoo.com

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org

Re: [PATCH] Replacement for maybeupload

Posted by Jeroen ter Voorde <j....@home.nl>.
On Wednesday 27 February 2002 09:26 pm, you wrote:
> Jeroen,
>
> Thanks for the contribution. Checked it in...Please cross-check. I took
> some liberty of cleaning-up/reformatting of the code and adding a few
> javadoc tags etc.

Thanks!

> Can you please take a look at the CVS? Also please submit patches to
> bugzilla (http://nagoya.apache.org) if you want any changes to the code.
>

CVS looks ok. Should I just copy/paste patches into the bug report 
description? 

Do you have a suggestion to make the parameters configurable without
recompiling? We could attach them to the factory parameter in web.xml (url 
style).
Like: ...request.MultiUploadWrapper?saveToDisk=true&allowOverWrite=false...

Jeroen


> Thanks,
> dims
>
> --- Jeroen ter Voorde <j....@home.nl> wrote:
> > Hi,
> >
> > I've modified the code to use Davanums's componentized request wrapper
> > code. I also added support to directly save files to disk optionally
> > overwriting or renaming existing files. So now it functions exactly the
> > same as MaybeUpload and no existing files had to be modified.
> >
> > The patch isn't really a patch, it's just a tgz to be unpacked in the
> > src/scratchpad/src/org/apache/cocoon/components/request directory.
> >
> > Set the request factory in web.xml to use MultipartRequestFactory to
> > enable it.
> >
> > Jeroen
> >
> > ATTACHMENT part 2 application/x-gzip name=multipartupload.tgz
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > For additional commands, email: cocoon-dev-help@xml.apache.org
>
> =====
> Davanum Srinivas - http://jguru.com/dims/
>
> __________________________________________________
> Do You Yahoo!?
> Yahoo! Greetings - Send FREE e-cards for every occasion!
> http://greetings.yahoo.com

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org