You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/08 13:51:44 UTC
[GitHub] [incubator-doris] zbtzbtzbt opened a new pull request, #8933: [refactor] remove useless inline
zbtzbtzbt opened a new pull request, #8933:
URL: https://github.com/apache/incubator-doris/pull/8933
# Proposed changes
I found too much inline in doris, some are useless
so, this pr is for remove useless keyword `inline`
1. Member functions defined in a class are `inline` by default (implicitly), and do not need to be added
2. `inline` is a keyword used for **implementation**, which has no effect when placed before the function declaration
-----
A coding standard from LLVM coding ducument:
<img width="864" alt="inline1" src="https://user-images.githubusercontent.com/35688959/162446749-681a3fcf-4c5b-411c-a361-b1df8b3bd2a6.png">
Reference:
https://isocpp.org/wiki/faq/inline-functions#where-to-put-inline-keyword
https://stackoverflow.com/questions/7762731/whats-the-difference-between-static-and-static-inline-function
https://llvm.org/docs/CodingStandards.html
@morningman @yangzhg @HappenLee @caiconghui
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
4. Has document been added or modified: (Yes/No/No Need)
5. Does it need to update dependencies: (Yes/No)
6. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui merged pull request #8933: [refactor](code_style) remove useless inline
Posted by GitBox <gi...@apache.org>.
caiconghui merged PR #8933:
URL: https://github.com/apache/incubator-doris/pull/8933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8933: [refactor](code_style) remove useless inline
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8933:
URL: https://github.com/apache/incubator-doris/pull/8933#issuecomment-1093984529
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8933: [refactor](code_style) remove useless inline
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8933:
URL: https://github.com/apache/incubator-doris/pull/8933#issuecomment-1093984502
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org