You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/07/12 19:50:38 UTC

[GitHub] [tvm] comaniac commented on a change in pull request #8449: [Fix] Explicitly retain `__hash__` of `StringImm`

comaniac commented on a change in pull request #8449:
URL: https://github.com/apache/tvm/pull/8449#discussion_r668083296



##########
File path: python/tvm/tir/expr.py
##########
@@ -577,6 +577,8 @@ def __ne__(self, other):
             return self.value != other.value
         return self.value != other
 
+    __hash__ = PrimExpr.__hash__

Review comment:
       Better to be a method like `__eq__` and `__ne__`?
   ```suggestion
       def __hash__(self):
           return PrimExpr.__hash__(self)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org