You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/09/11 15:11:53 UTC

[GitHub] [calcite] asolimando commented on pull request #2506: [CALCITE-4754] Fixed wrong SQL generated for PIVOT queries on Redshift.

asolimando commented on pull request #2506:
URL: https://github.com/apache/calcite/pull/2506#issuecomment-917423078


   The changes LGTM, however, I find a bit weird that `IS TRUE` is mentioned all over the code but not featuring at all in the unit tests. Can you expand the test cases to cover it explicitly or elaborate on why you think it's not needed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org