[GitHub] [hbase] ndimiduk commented on a change in pull request #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…

[GitBox <gi...@apache.org>]

ndimiduk commented on a change in pull request #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…
URL: https://github.com/apache/hbase/pull/1374#discussion_r399483314
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientAsyncPrefetchScanner.java
 ##########
 @@ -80,13 +77,10 @@ void setPrefetchListener(Consumer<Boolean> prefetchListener) {
 
   @Override
   protected void initCache() {
-    // concurrent cache
-    maxCacheSize = resultSize2CacheSize(maxScannerResultSize);
+    // Override to put a different cache in place of the super's -- a concurrent one.
     cache = new LinkedBlockingQueue<>();
+    maxCacheSize = resultSize2CacheSize(maxScannerResultSize);
     cacheSizeInBytes = new AtomicLong(0);
-    exceptionsQueue = new ConcurrentLinkedQueue<>();
-    prefetcher = new Thread(new PrefetchRunnable());
 
 Review comment:
   We don't need to keep a handle on the spawned thread? It's a daemon so need to explicitly terminate it on shutdown?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services