You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/08/08 15:07:19 UTC
[GitHub] [incubator-pekko-grpc] mdedetrich opened a new pull request, #151: Add sbt-license-report
mdedetrich opened a new pull request, #151:
URL: https://github.com/apache/incubator-pekko-grpc/pull/151
Adds sbt license report
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #151: Add sbt-license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #151:
URL: https://github.com/apache/incubator-pekko-grpc/pull/151#discussion_r1287507785
##########
project/LicenseReport.scala:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import sbt._
+import sbtlicensereport.SbtLicenseReport
+import sbtlicensereport.SbtLicenseReport.autoImportImpl._
+import sbtlicensereport.license.{ DepModuleInfo, LicenseInfo, MarkDown }
+
+object LicenseReport extends AutoPlugin {
+
+ override lazy val projectSettings = Seq(
+ licenseReportTypes := Seq(MarkDown),
+ licenseReportMakeHeader := (language => language.header1("License Report")),
+ licenseConfigurations := Set("compile", "test", "provided"),
+ licenseDepExclusions := {
+ case DepModuleInfo("org.apache.pekko", _, _) => true // Inter pekko project dependencies are pointless
+ case DepModuleInfo(_, "scala-library", _) => true // Scala library is part of Scala language
+ case DepModuleInfo(_, "scala-reflect", _) => true // Scala reflect is part of Scala language
Review Comment:
Its probably better off to fix this by doing a master config in a hypothetical future `incubator-pekko-sbt-build` plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] He-Pin commented on a diff in pull request #151: Add sbt-license-report
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #151:
URL: https://github.com/apache/incubator-pekko-grpc/pull/151#discussion_r1287483016
##########
project/LicenseReport.scala:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import sbt._
+import sbtlicensereport.SbtLicenseReport
+import sbtlicensereport.SbtLicenseReport.autoImportImpl._
+import sbtlicensereport.license.{ DepModuleInfo, LicenseInfo, MarkDown }
+
+object LicenseReport extends AutoPlugin {
+
+ override lazy val projectSettings = Seq(
+ licenseReportTypes := Seq(MarkDown),
+ licenseReportMakeHeader := (language => language.header1("License Report")),
+ licenseConfigurations := Set("compile", "test", "provided"),
+ licenseDepExclusions := {
+ case DepModuleInfo("org.apache.pekko", _, _) => true // Inter pekko project dependencies are pointless
+ case DepModuleInfo(_, "scala-library", _) => true // Scala library is part of Scala language
+ case DepModuleInfo(_, "scala-reflect", _) => true // Scala reflect is part of Scala language
Review Comment:
Can those be a configurable set instead of three cases.
##########
project/LicenseReport.scala:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import sbt._
+import sbtlicensereport.SbtLicenseReport
+import sbtlicensereport.SbtLicenseReport.autoImportImpl._
+import sbtlicensereport.license.{ DepModuleInfo, LicenseInfo, MarkDown }
+
+object LicenseReport extends AutoPlugin {
+
+ override lazy val projectSettings = Seq(
+ licenseReportTypes := Seq(MarkDown),
+ licenseReportMakeHeader := (language => language.header1("License Report")),
+ licenseConfigurations := Set("compile", "test", "provided"),
+ licenseDepExclusions := {
+ case DepModuleInfo("org.apache.pekko", _, _) => true // Inter pekko project dependencies are pointless
+ case DepModuleInfo(_, "scala-library", _) => true // Scala library is part of Scala language
+ case DepModuleInfo(_, "scala-reflect", _) => true // Scala reflect is part of Scala language
+ },
+ licenseOverrides := {
+ case dep: DepModuleInfo if dep.organization.startsWith("javax") => LicenseInfo.CDDL_GPL
Review Comment:
Newer version will starts.with Jakarta
##########
scripts/link-validator.conf:
##########
@@ -24,7 +24,44 @@ site-link-validator {
"https://mvnrepository.com/artifact/"
# we haven't yet set up the gradle plugin on plugins.gradle.org
"https://plugins.gradle.org/plugin/org.apache.pekko.grpc.gradle"
+ # Github links generated by sbt-license-report
+ "http://pholser.github.com/jopt-simple"
+ "https://github.com/googleapis/java-iam/proto-google-common-protos"
+ "https://github.com/netty/netty-tcnative/netty-tcnative-boringssl-static"
+ # Other links generated by sbt-license-report
+ "http://lmax-exchange.github.com/disruptor"
+ # Occasionally returns a 500 Internal Server Error
+ "http://code.google.com/"
]
- non-https-whitelist = []
+ non-https-whitelist = [
+ # license report
+ "http://aopalliance.sourceforge.net",
+ "http://asm.ow2.io/",
+ "http://code.google.com/p/",
+ "http://commons.apache.org/proper/",
+ "http://findbugs.sourceforge.net/",
+ "http://fusesource.github.io/jansi",
+ "http://hc.apache.org/",
+ "http://hdrhistogram.github.io/HdrHistogram/",
+ "http://jcp.org/en/jsr/detail?id=250",
+ "http://junit.org",
+ "http://lmax-exchange.github.com/disruptor",
+ "http://openjdk.java.net/legal/gplv2+ce.html",
+ "http://opensource.org/licenses/",
+ "http://www.opensource.org/licenses/",
+ "http://parboiled.org",
+ "http://pholser.github.com/jopt-simple",
+ "http://source.android.com/",
+ "http://www.apache.org/licenses",
+ "http://www.eclipse.org/legal/",
+ "http://www.gnu.org/licenses/",
+ "http://www.jcraft.com/jsch/",
Review Comment:
Move to front, get the list sorted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #151: Add sbt-license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #151:
URL: https://github.com/apache/incubator-pekko-grpc/pull/151#discussion_r1287508598
##########
project/LicenseReport.scala:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import sbt._
+import sbtlicensereport.SbtLicenseReport
+import sbtlicensereport.SbtLicenseReport.autoImportImpl._
+import sbtlicensereport.license.{ DepModuleInfo, LicenseInfo, MarkDown }
+
+object LicenseReport extends AutoPlugin {
+
+ override lazy val projectSettings = Seq(
+ licenseReportTypes := Seq(MarkDown),
+ licenseReportMakeHeader := (language => language.header1("License Report")),
+ licenseConfigurations := Set("compile", "test", "provided"),
+ licenseDepExclusions := {
+ case DepModuleInfo("org.apache.pekko", _, _) => true // Inter pekko project dependencies are pointless
+ case DepModuleInfo(_, "scala-library", _) => true // Scala library is part of Scala language
+ case DepModuleInfo(_, "scala-reflect", _) => true // Scala reflect is part of Scala language
+ },
+ licenseOverrides := {
+ case dep: DepModuleInfo if dep.organization.startsWith("javax") => LicenseInfo.CDDL_GPL
Review Comment:
The point of these license overrides is to fix invalid urls that the licenses point to, newer versions with Jakarta have valid links.
In other words this is deliberate, its only for older licenses that it needs to be fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #151: Add sbt-license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #151:
URL: https://github.com/apache/incubator-pekko-grpc/pull/151#discussion_r1287508845
##########
scripts/link-validator.conf:
##########
@@ -24,7 +24,44 @@ site-link-validator {
"https://mvnrepository.com/artifact/"
# we haven't yet set up the gradle plugin on plugins.gradle.org
"https://plugins.gradle.org/plugin/org.apache.pekko.grpc.gradle"
+ # Github links generated by sbt-license-report
+ "http://pholser.github.com/jopt-simple"
+ "https://github.com/googleapis/java-iam/proto-google-common-protos"
+ "https://github.com/netty/netty-tcnative/netty-tcnative-boringssl-static"
+ # Other links generated by sbt-license-report
+ "http://lmax-exchange.github.com/disruptor"
+ # Occasionally returns a 500 Internal Server Error
+ "http://code.google.com/"
]
- non-https-whitelist = []
+ non-https-whitelist = [
+ # license report
+ "http://aopalliance.sourceforge.net",
+ "http://asm.ow2.io/",
+ "http://code.google.com/p/",
+ "http://commons.apache.org/proper/",
+ "http://findbugs.sourceforge.net/",
+ "http://fusesource.github.io/jansi",
+ "http://hc.apache.org/",
+ "http://hdrhistogram.github.io/HdrHistogram/",
+ "http://jcp.org/en/jsr/detail?id=250",
+ "http://junit.org",
+ "http://lmax-exchange.github.com/disruptor",
+ "http://openjdk.java.net/legal/gplv2+ce.html",
+ "http://opensource.org/licenses/",
+ "http://www.opensource.org/licenses/",
+ "http://parboiled.org",
+ "http://pholser.github.com/jopt-simple",
+ "http://source.android.com/",
+ "http://www.apache.org/licenses",
+ "http://www.eclipse.org/legal/",
+ "http://www.gnu.org/licenses/",
+ "http://www.jcraft.com/jsch/",
Review Comment:
This list is temporary, will be removed when more functionality will get added to a forked link-validator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich merged pull request #151: Add sbt-license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #151:
URL: https://github.com/apache/incubator-pekko-grpc/pull/151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org