You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "srowen (via GitHub)" <gi...@apache.org> on 2023/03/17 10:49:25 UTC
[GitHub] [spark] srowen commented on pull request #37738: add Support Java Class with circular references
srowen commented on PR #37738:
URL: https://github.com/apache/spark/pull/37738#issuecomment-1473647828
Still seems weird to me --
Does this happen to even be 'enough' for the protobuf case? Or does this extra unwanted descriptor field add other unneeded cols?
Is it 'too much' - Is it skipping real circular references that matter, but can't translate to tabular schemas?
Is it solvable by just subclassing the bean class and hiding the field that isn't desirable to begin with?
How does the circular ref arise in the avro case, different?
I get it just seems a bit too hacky as the 'right' solution. Sometimes hacks are worth it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org