You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/06/26 05:14:04 UTC
[Bug 4431] New: Add debugging info on whitelist/blacklist hits
http://bugzilla.spamassassin.org/show_bug.cgi?id=4431
Summary: Add debugging info on whitelist/blacklist hits
Product: Spamassassin
Version: unspecified
Platform: Other
OS/Version: other
Status: NEW
Severity: enhancement
Priority: P3
Component: Rules (Eval Tests)
AssignedTo: dev@spamassassin.apache.org
ReportedBy: lwilton@earthlink.net
This is related to bug 4425.
To ease debugging seemingly spurious whitelist/blacklist hits, the whitelist
and blacklist rules should have debug-level messages indicating what name hit,
and if possible what in the message it hit against.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4431] [review] Add debugging info on whitelist/blacklist hits
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4431
------- Additional Comments From spamassassin@dostech.ca 2005-07-07 16:17 -------
After sleeping on it, it doesn't make alot of sense to add a facility for only
two debug messages.
Any comments on using the "rules" facility instead of "wblist"?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4431] [review] Add debugging info on whitelist/blacklist hits
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4431
------- Additional Comments From jm@jmason.org 2005-07-07 16:28 -------
yeah, agreed about not adding a facility.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4431] Add debugging info on whitelist/blacklist hits
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4431
Bob@Menschel.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.1.1
------- Additional Comments From Bob@Menschel.net 2005-07-03 18:57 -------
Triage: Should be a simple enough enhancement to get into 3.1.1 (and would be a
big benefit to many people trying to figure out why a whitelist/blacklist entry
doesn't work, or why an email is surprisingly whitelisted/blacklisted).
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4431] Add debugging info on whitelist/blacklist hits
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4431
------- Additional Comments From Bob@Menschel.net 2005-07-06 20:57 -------
Created an attachment (id=2993)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2993&action=view)
Alternate patch
I like it. Works good. Minor enhancement, to include the matching regex in
the debug message.
Given these are so simple, any chance we can squeeze them into 3.1.0?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4431] [review] Add debugging info on whitelist/blacklist hits
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4431
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
------- Additional Comments From spamassassin@dostech.ca 2005-07-20 22:53 -------
Sending lib/Mail/SpamAssassin/EvalTests.pm
Transmitting file data .
Committed revision 219999.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4431] [review] Add debugging info on whitelist/blacklist hits
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4431
------- Additional Comments From spamassassin@dostech.ca 2005-07-06 21:25 -------
Subject: Re: [review] Add debugging info on whitelist/blacklist
hits
Yeah, I guess I was a little split brained when I did that one...
including the regexp in the whitelist_from_rcvd version but not the
plain white/blacklist version.
Are we happy with dbg("wblist:" ?
Shall I just add the $regexp to the end of the plain white/blacklist dbg
message?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4431] [review] Add debugging info on whitelist/blacklist hits
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4431
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dev@spamassassin.apache.org
Status Whiteboard| |needs review
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4431] [review] Add debugging info on whitelist/blacklist hits
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4431
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #2990 is|0 |1
obsolete| |
Attachment #2993 is|0 |1
obsolete| |
AssignedTo|dev@spamassassin.apache.org |spamassassin@dostech.ca
Status|NEW |ASSIGNED
------- Additional Comments From spamassassin@dostech.ca 2005-07-07 17:20 -------
Created an attachment (id=3009)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=3009&action=view)
updated patch
Sorry Bob, I didn't see that you had already posted a patch for what I
suggested in my last comment. Anyway, here's an updated patch using the rules
debug facility.
Note that this patch won't apply against 3.1.0-pre3 without the one character
addition from bug 4453.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4431] [review] Add debugging info on whitelist/blacklist hits
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4431
------- Additional Comments From jm@jmason.org 2005-07-08 18:27 -------
+1
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4431] [review] Add debugging info on whitelist/blacklist hits
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4431
------- Additional Comments From henry@stern.ca 2005-07-16 03:14 -------
+1
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4431] Add debugging info on whitelist/blacklist hits
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4431
------- Additional Comments From spamassassin@dostech.ca 2005-07-05 22:28 -------
Created an attachment (id=2990)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2990&action=view)
patch
Not sure how verbose the whitelist_from_rcvd dbg message should be, but here's
the two line patch for anyone who needs it.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4431] [review] Add debugging info on whitelist/blacklist hits
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4431
------- Additional Comments From parkerm@pobox.com 2005-07-06 21:29 -------
Subject: Re: [review] Add debugging info on whitelist/blacklist
hits
>Are we happy with dbg("wblist:" ?
>
>
>
Don't forget to update at least debug.t and any other place that looks
at facilities.
Michael
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4431] [review] Add debugging info on whitelist/blacklist hits
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4431
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Add debugging info on |[review] Add debugging info
|whitelist/blacklist hits |on whitelist/blacklist hits
Target Milestone|3.1.1 |3.1.0
------- Additional Comments From jm@jmason.org 2005-07-06 21:18 -------
can't see why not, it's a trivial patch (I'd lean towards Bob's minor addition btw.)
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.