You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/04/27 01:35:39 UTC
Review Request 66840: Added `libacl` into Dockerfiles for the
`mesos/mesos-build` image.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66840/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Bugs: MESOS-8809
https://issues.apache.org/jira/browse/MESOS-8809
Repository: mesos
Description
-------
Added `libacl` into Dockerfiles for the `mesos/mesos-build` image.
Diffs
-----
support/mesos-build/centos-7.dockerfile acdb44db281e9a156cbd684d2159ab4a5c65e8c4
support/mesos-build/ubuntu-16.04-arm.dockerfile 6d76090c466f84748df307888721d77a5f583290
support/mesos-build/ubuntu-16.04.dockerfile 0bbaa035f401c2c91e4e921cfe9abeb3953885a5
Diff: https://reviews.apache.org/r/66840/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 66840: Added `libacl` into a few Dockerfiles.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66840/#review202061
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On April 27, 2018, 10:30 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66840/
> -----------------------------------------------------------
>
> (Updated April 27, 2018, 10:30 a.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8809
> https://issues.apache.org/jira/browse/MESOS-8809
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit adds `libacl` into Dockerfiles for the images:
> 1. mesos/mesos-build
> 2. mesos/mesos-tidy
> 2. mesos/mesos-mini
>
>
> Diffs
> -----
>
> support/mesos-build/centos-7.dockerfile acdb44db281e9a156cbd684d2159ab4a5c65e8c4
> support/mesos-build/ubuntu-16.04-arm.dockerfile 6d76090c466f84748df307888721d77a5f583290
> support/mesos-build/ubuntu-16.04.dockerfile 0bbaa035f401c2c91e4e921cfe9abeb3953885a5
> support/mesos-tidy/Dockerfile f046a1410a3012509babb0558998f33b9e241c43
> support/packaging/centos/mesos.spec 752c2aa24fba3226d5b1efa0d97a182b723e26c4
>
>
> Diff: https://reviews.apache.org/r/66840/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 66840: Added `libacl` into a few Dockerfiles.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66840/
-----------------------------------------------------------
(Updated April 27, 2018, 4:30 p.m.)
Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Changes
-------
Addressed review comments.
Summary (updated)
-----------------
Added `libacl` into a few Dockerfiles.
Bugs: MESOS-8809
https://issues.apache.org/jira/browse/MESOS-8809
Repository: mesos
Description (updated)
-------
This commit adds `libacl` into Dockerfiles for the images:
1. mesos/mesos-build
2. mesos/mesos-tidy
2. mesos/mesos-mini
Diffs (updated)
-----
support/mesos-build/centos-7.dockerfile acdb44db281e9a156cbd684d2159ab4a5c65e8c4
support/mesos-build/ubuntu-16.04-arm.dockerfile 6d76090c466f84748df307888721d77a5f583290
support/mesos-build/ubuntu-16.04.dockerfile 0bbaa035f401c2c91e4e921cfe9abeb3953885a5
support/mesos-tidy/Dockerfile f046a1410a3012509babb0558998f33b9e241c43
support/packaging/centos/mesos.spec 752c2aa24fba3226d5b1efa0d97a182b723e26c4
Diff: https://reviews.apache.org/r/66840/diff/2/
Changes: https://reviews.apache.org/r/66840/diff/1-2/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 66840: Added `libacl` into Dockerfiles for the
`mesos/mesos-build` image.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66840/#review202052
-----------------------------------------------------------
support/mesos-build/centos-7.dockerfile
Line 1 (original), 1 (patched)
<https://reviews.apache.org/r/66840/#comment283711>
It seems we need to update some more Docker setups:
* `support/packaging/*.dockerfile`
* `support/mesos-tidy/Dockerfile`
The first is used by the image `mesos/mesos-mini` while the second one produces `mesos/mesos-tidy` on dockerhub. After merging this patch we should rebuild and republish them.
- Benjamin Bannier
On April 27, 2018, 3:35 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66840/
> -----------------------------------------------------------
>
> (Updated April 27, 2018, 3:35 a.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8809
> https://issues.apache.org/jira/browse/MESOS-8809
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `libacl` into Dockerfiles for the `mesos/mesos-build` image.
>
>
> Diffs
> -----
>
> support/mesos-build/centos-7.dockerfile acdb44db281e9a156cbd684d2159ab4a5c65e8c4
> support/mesos-build/ubuntu-16.04-arm.dockerfile 6d76090c466f84748df307888721d77a5f583290
> support/mesos-build/ubuntu-16.04.dockerfile 0bbaa035f401c2c91e4e921cfe9abeb3953885a5
>
>
> Diff: https://reviews.apache.org/r/66840/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 66840: Added `libacl` into Dockerfiles for the
`mesos/mesos-build` image.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66840/#review202049
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On April 26, 2018, 6:35 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66840/
> -----------------------------------------------------------
>
> (Updated April 26, 2018, 6:35 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8809
> https://issues.apache.org/jira/browse/MESOS-8809
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `libacl` into Dockerfiles for the `mesos/mesos-build` image.
>
>
> Diffs
> -----
>
> support/mesos-build/centos-7.dockerfile acdb44db281e9a156cbd684d2159ab4a5c65e8c4
> support/mesos-build/ubuntu-16.04-arm.dockerfile 6d76090c466f84748df307888721d77a5f583290
> support/mesos-build/ubuntu-16.04.dockerfile 0bbaa035f401c2c91e4e921cfe9abeb3953885a5
>
>
> Diff: https://reviews.apache.org/r/66840/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>