You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/31 13:18:29 UTC

[GitHub] [pulsar] StevenLuMT opened a new pull request, #19115: [fix][broker] change name limitSize to limitSizeInBytes

StevenLuMT opened a new pull request, #19115:
URL: https://github.com/apache/pulsar/pull/19115

   ### Motivation
   
   limitSize It's a confusing name, without the time unit, it is easy to cause bugs,
   so we should deprecate the old name limitSize and introduce a new one limitSizeInBytes
   
   ### Modifications
   change name limitSize to limitSizeInBytes
   
   ### Verifying this change
   - [ ] Make sure that the change passes the CI checks.
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   Check the box below or label this PR directly.
   
   Need to update docs?
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   PR in forked repository: https://github.com/StevenLuMT/pulsar/pull/2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] StevenLuMT commented on pull request #19115: [fix][broker] change name limitSize to limitSizeInBytes

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #19115:
URL: https://github.com/apache/pulsar/pull/19115#issuecomment-1368457650

   rerun the fail workflow


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] StevenLuMT closed pull request #19115: [fix][broker] change name limitSize to limitSizeInBytes

Posted by GitBox <gi...@apache.org>.
StevenLuMT closed pull request #19115: [fix][broker] change name limitSize to limitSizeInBytes
URL: https://github.com/apache/pulsar/pull/19115


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] StevenLuMT closed pull request #19115: [fix][broker] change name limitSize to limitSizeInBytes

Posted by GitBox <gi...@apache.org>.
StevenLuMT closed pull request #19115: [fix][broker] change name limitSize to limitSizeInBytes
URL: https://github.com/apache/pulsar/pull/19115


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] StevenLuMT closed pull request #19115: [fix][broker] change name limitSize to limitSizeInBytes

Posted by GitBox <gi...@apache.org>.
StevenLuMT closed pull request #19115: [fix][broker] change name limitSize to limitSizeInBytes
URL: https://github.com/apache/pulsar/pull/19115


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] StevenLuMT closed pull request #19115: [fix][broker] change name limitSize to limitSizeInBytes

Posted by GitBox <gi...@apache.org>.
StevenLuMT closed pull request #19115: [fix][broker] change name limitSize to limitSizeInBytes
URL: https://github.com/apache/pulsar/pull/19115


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] StevenLuMT commented on pull request #19115: [fix][broker] change name limitSize to limitSizeInBytes

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #19115:
URL: https://github.com/apache/pulsar/pull/19115#issuecomment-1368496798

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] StevenLuMT closed pull request #19115: [fix][broker] change name limitSize to limitSizeInBytes

Posted by GitBox <gi...@apache.org>.
StevenLuMT closed pull request #19115: [fix][broker] change name limitSize to limitSizeInBytes
URL: https://github.com/apache/pulsar/pull/19115


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org