You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Felix Knecht <fe...@apache.org> on 2007/03/30 15:42:23 UTC

Re: svn commit: r524080 - /cocoon/trunk/core/cocoon-thread/cocoon-thread-impl/src/main/java/org/apache/cocoon/components/thread/DefaultRunnableManager.java

Does exists a CodeStyle template for formatting I can load in Eclipse to
avoid needed reformatting?

I took the CodeStyle 'Java Conventions [built-in]' from Eclipse 3.2
supposing this is the same as metnioned
@http://cocoon.apache.org/community/committer.html (Sun Java Style Guide).

Felix


reinhard@apache.org schrieb:
> Author: reinhard
> Date: Fri Mar 30 06:29:52 2007
> New Revision: 524080
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=524080
> Log:
> formatting
>
> Modified:
>     cocoon/trunk/core/cocoon-thread/cocoon-thread-impl/src/main/java/org/apache/cocoon/components/thread/DefaultRunnableManager.java
>
>   


Re: svn commit: r524080 - /cocoon/trunk/core/cocoon-thread/cocoon-thread-impl/src/main/java/org/apache/cocoon/components/thread/DefaultRunnableManager.java

Posted by Felix Knecht <fe...@otego.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I had a deeper look into the given settings and it seems that a kind
of mix between spaces and tabs is given by default.

Sorry - I'll do my very best to upgrade myself ;-)

Felix
> Felix Knecht wrote:
>> Does exists a CodeStyle template for formatting I can load in
>> Eclipse to avoid needed reformatting?
>>
>> I took the CodeStyle 'Java Conventions [built-in]' from Eclipse
>> 3.2 supposing this is the same as metnioned
>> @http://cocoon.apache.org/community/committer.html (Sun Java
>> Style Guide).
>
> Don't know about eclipse but I noticed that you used tabs instead
> of spaces. Cocoon's standard for indentation is 4 spaces.
>
> Vadim
>
>
>> Felix
>>
>>
>> reinhard@apache.org schrieb:
>>> Author: reinhard Date: Fri Mar 30 06:29:52 2007 New Revision:
>>> 524080
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=524080 Log:
>>> formatting
>>>
>>> Modified:
>>>
>>>
cocoon/trunk/core/cocoon-thread/cocoon-thread-impl/src/main/java/org/apache/cocoon/components/thread/DefaultRunnableManager.java
>>>
>>>
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGDRii2lZVCB08qHERAkIuAJ4sJyxwjVJspAjr8QfZ3d8tmL56gACeOtzg
A4SWy/UH79Gxj2MViiUKdjI=
=8Tuy
-----END PGP SIGNATURE-----


Re: svn commit: r524080 - /cocoon/trunk/core/cocoon-thread/cocoon-thread-impl/src/main/java/org/apache/cocoon/components/thread/DefaultRunnableManager.java

Posted by Felix Knecht <fe...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I had a deeper look into the given settings and it seems that a kind
of mix between spaces and tabs is given by default.

Sorry - I'll do my very best to upgrade myself ;-)

Felix
> Felix Knecht wrote:
>> Does exists a CodeStyle template for formatting I can load in
>> Eclipse to avoid needed reformatting?
>>
>> I took the CodeStyle 'Java Conventions [built-in]' from Eclipse
>> 3.2 supposing this is the same as metnioned
>> @http://cocoon.apache.org/community/committer.html (Sun Java
>> Style Guide).
>
> Don't know about eclipse but I noticed that you used tabs instead
> of spaces. Cocoon's standard for indentation is 4 spaces.
>
> Vadim
>
>
>> Felix
>>
>>
>> reinhard@apache.org schrieb:
>>> Author: reinhard Date: Fri Mar 30 06:29:52 2007 New Revision:
>>> 524080
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=524080 Log:
>>> formatting
>>>
>>> Modified:
>>>
>>>
cocoon/trunk/core/cocoon-thread/cocoon-thread-impl/src/main/java/org/apache/cocoon/components/thread/DefaultRunnableManager.java
>>>
>>>
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGDRii2lZVCB08qHERAkIuAJ4sJyxwjVJspAjr8QfZ3d8tmL56gACeOtzg
A4SWy/UH79Gxj2MViiUKdjI=
=8Tuy
-----END PGP SIGNATURE-----


Re: svn commit: r524080 - /cocoon/trunk/core/cocoon-thread/cocoon-thread-impl/src/main/java/org/apache/cocoon/components/thread/DefaultRunnableManager.java

Posted by Vadim Gritsenko <va...@reverycodes.com>.
Felix Knecht wrote:
> Does exists a CodeStyle template for formatting I can load in Eclipse to
> avoid needed reformatting?
> 
> I took the CodeStyle 'Java Conventions [built-in]' from Eclipse 3.2
> supposing this is the same as metnioned
> @http://cocoon.apache.org/community/committer.html (Sun Java Style Guide).

Don't know about eclipse but I noticed that you used tabs instead of spaces. 
Cocoon's standard for indentation is 4 spaces.

Vadim


> Felix
> 
> 
> reinhard@apache.org schrieb:
>> Author: reinhard
>> Date: Fri Mar 30 06:29:52 2007
>> New Revision: 524080
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=524080
>> Log:
>> formatting
>>
>> Modified:
>>     cocoon/trunk/core/cocoon-thread/cocoon-thread-impl/src/main/java/org/apache/cocoon/components/thread/DefaultRunnableManager.java


Re: svn commit: r524080 - /cocoon/trunk/core/cocoon-thread/cocoon-thread-impl/src/main/java/org/apache/cocoon/components/thread/DefaultRunnableManager.java

Posted by Reinhard Poetz <re...@apache.org>.
Felix Knecht wrote:
> Does exists a CodeStyle template for formatting I can load in Eclipse to
> avoid needed reformatting?
> 
> I took the CodeStyle 'Java Conventions [built-in]' from Eclipse 3.2
> supposing this is the same as metnioned
> @http://cocoon.apache.org/community/committer.html (Sun Java Style Guide).

At least for me the line intention was totally funny and the code was unreadable.

I also use the Java Convetions by Eclipse and only set tabs as spaces only and 
the line width to 120 characters.

-- 
Reinhard Pötz           Independent Consultant, Trainer & (IT)-Coach 

{Software Engineering, Open Source, Web Applications, Apache Cocoon}

                                        web(log): http://www.poetz.cc
--------------------------------------------------------------------