You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <js...@apache.org> on 2016/04/04 01:49:02 UTC
Review Request 45661: Upgrade build tools.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45661/
-----------------------------------------------------------
Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
Repository: aurora
Description
-------
This brings Gradle to 2.12, release notes here:
https://docs.gradle.org/2.11/release-notes
https://docs.gradle.org/2.12/release-notes
Pants is upgraded to 0.0.80, release notes here:
http://pantsbuild.github.io/changelog.html
buildSrc/gradle.properties | 2 +-
gradle/wrapper/gradle-wrapper.properties | 2 +-
pants.ini | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
Diffs
-----
buildSrc/gradle.properties 7231dbadf677943a83c815bc634d255a4fe1b6cb
gradle/wrapper/gradle-wrapper.properties f70fc30fb22d183ef755dcbe97c163eaa0496587
pants.ini b1a42d1a7707e356aa25eac90d0052e3044ed813
Diff: https://reviews.apache.org/r/45661/diff/
Testing
-------
Locally green:
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
I also built a fresh IDEA project with `./gradlew idea` and
that project built green from within IDEA.
Thanks,
John Sirois
Re: Review Request 45661: Upgrade build tools.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45661/#review126860
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On April 3, 2016, 11:49 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45661/
> -----------------------------------------------------------
>
> (Updated April 3, 2016, 11:49 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This brings Gradle to 2.12, release notes here:
> https://docs.gradle.org/2.11/release-notes
> https://docs.gradle.org/2.12/release-notes
>
> Pants is upgraded to 0.0.80, release notes here:
> http://pantsbuild.github.io/changelog.html
>
> buildSrc/gradle.properties | 2 +-
> gradle/wrapper/gradle-wrapper.properties | 2 +-
> pants.ini | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
>
> Diffs
> -----
>
> buildSrc/gradle.properties 7231dbadf677943a83c815bc634d255a4fe1b6cb
> gradle/wrapper/gradle-wrapper.properties f70fc30fb22d183ef755dcbe97c163eaa0496587
> pants.ini b1a42d1a7707e356aa25eac90d0052e3044ed813
>
> Diff: https://reviews.apache.org/r/45661/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
> I also built a fresh IDEA project with `./gradlew idea` and
> that project built green from within IDEA.
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 45661: Upgrade build tools.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45661/#review126761
-----------------------------------------------------------
FYI: The corresponding aurora-packaging change is here: https://reviews.apache.org/r/45662/
- John Sirois
On April 3, 2016, 5:49 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45661/
> -----------------------------------------------------------
>
> (Updated April 3, 2016, 5:49 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This brings Gradle to 2.12, release notes here:
> https://docs.gradle.org/2.11/release-notes
> https://docs.gradle.org/2.12/release-notes
>
> Pants is upgraded to 0.0.80, release notes here:
> http://pantsbuild.github.io/changelog.html
>
> buildSrc/gradle.properties | 2 +-
> gradle/wrapper/gradle-wrapper.properties | 2 +-
> pants.ini | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
>
> Diffs
> -----
>
> buildSrc/gradle.properties 7231dbadf677943a83c815bc634d255a4fe1b6cb
> gradle/wrapper/gradle-wrapper.properties f70fc30fb22d183ef755dcbe97c163eaa0496587
> pants.ini b1a42d1a7707e356aa25eac90d0052e3044ed813
>
> Diff: https://reviews.apache.org/r/45661/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
> I also built a fresh IDEA project with `./gradlew idea` and
> that project built green from within IDEA.
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 45661: Upgrade build tools.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45661/#review126855
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On April 3, 2016, 4:49 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45661/
> -----------------------------------------------------------
>
> (Updated April 3, 2016, 4:49 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This brings Gradle to 2.12, release notes here:
> https://docs.gradle.org/2.11/release-notes
> https://docs.gradle.org/2.12/release-notes
>
> Pants is upgraded to 0.0.80, release notes here:
> http://pantsbuild.github.io/changelog.html
>
> buildSrc/gradle.properties | 2 +-
> gradle/wrapper/gradle-wrapper.properties | 2 +-
> pants.ini | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
>
> Diffs
> -----
>
> buildSrc/gradle.properties 7231dbadf677943a83c815bc634d255a4fe1b6cb
> gradle/wrapper/gradle-wrapper.properties f70fc30fb22d183ef755dcbe97c163eaa0496587
> pants.ini b1a42d1a7707e356aa25eac90d0052e3044ed813
>
> Diff: https://reviews.apache.org/r/45661/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
> I also built a fresh IDEA project with `./gradlew idea` and
> that project built green from within IDEA.
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 45661: Upgrade build tools.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45661/#review126768
-----------------------------------------------------------
Ship it!
Master (17ade11) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 3, 2016, 11:49 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45661/
> -----------------------------------------------------------
>
> (Updated April 3, 2016, 11:49 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This brings Gradle to 2.12, release notes here:
> https://docs.gradle.org/2.11/release-notes
> https://docs.gradle.org/2.12/release-notes
>
> Pants is upgraded to 0.0.80, release notes here:
> http://pantsbuild.github.io/changelog.html
>
> buildSrc/gradle.properties | 2 +-
> gradle/wrapper/gradle-wrapper.properties | 2 +-
> pants.ini | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
>
> Diffs
> -----
>
> buildSrc/gradle.properties 7231dbadf677943a83c815bc634d255a4fe1b6cb
> gradle/wrapper/gradle-wrapper.properties f70fc30fb22d183ef755dcbe97c163eaa0496587
> pants.ini b1a42d1a7707e356aa25eac90d0052e3044ed813
>
> Diff: https://reviews.apache.org/r/45661/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
> I also built a fresh IDEA project with `./gradlew idea` and
> that project built green from within IDEA.
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 45661: Upgrade build tools.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45661/#review126875
-----------------------------------------------------------
Jake - I'm going to go ahead and submit. I added you mainly as /cc in your role as 0.13.0 release manager.
- John Sirois
On April 3, 2016, 5:49 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45661/
> -----------------------------------------------------------
>
> (Updated April 3, 2016, 5:49 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This brings Gradle to 2.12, release notes here:
> https://docs.gradle.org/2.11/release-notes
> https://docs.gradle.org/2.12/release-notes
>
> Pants is upgraded to 0.0.80, release notes here:
> http://pantsbuild.github.io/changelog.html
>
> buildSrc/gradle.properties | 2 +-
> gradle/wrapper/gradle-wrapper.properties | 2 +-
> pants.ini | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
>
> Diffs
> -----
>
> buildSrc/gradle.properties 7231dbadf677943a83c815bc634d255a4fe1b6cb
> gradle/wrapper/gradle-wrapper.properties f70fc30fb22d183ef755dcbe97c163eaa0496587
> pants.ini b1a42d1a7707e356aa25eac90d0052e3044ed813
>
> Diff: https://reviews.apache.org/r/45661/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
> I also built a fresh IDEA project with `./gradlew idea` and
> that project built green from within IDEA.
>
>
> Thanks,
>
> John Sirois
>
>