You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/12/15 04:20:22 UTC

Re: Review Request 40102: Windows: Unified POSIX and Windows implementation of process.hpp.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40102/
-----------------------------------------------------------

(Updated Dec. 15, 2015, 3:20 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.


Bugs: MESOS-3860
    https://issues.apache.org/jira/browse/MESOS-3860


Repository: mesos


Description
-------

Windows: Unified POSIX and Windows implementation of process.hpp.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am a8c35c086ecae21701f6a720f25231c1b0d4e329 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/process.hpp ed28e663ff4bef3391e852f3938ff1a584a8c687 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp 4ed0c47c99ccc7c6f3036fd75dfb4676a9a2afca 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp 8dfd330f84b8e721a78722470e7c445ed3b87bec 

Diff: https://reviews.apache.org/r/40102/diff/


Testing
-------


Thanks,

Alex Clemmer


Re: Review Request 40102: Windows: Unified POSIX and Windows implementation of process.hpp.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40102/#review110518
-----------------------------------------------------------

Ship it!


did a diff and build to verify nothing changed.

- Joris Van Remoortere


On Dec. 15, 2015, 3:38 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40102/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 3:38 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3860
>     https://issues.apache.org/jira/browse/MESOS-3860
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Unified POSIX and Windows implementation of process.hpp.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am a8c35c086ecae21701f6a720f25231c1b0d4e329 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/process.hpp ed28e663ff4bef3391e852f3938ff1a584a8c687 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp 4ed0c47c99ccc7c6f3036fd75dfb4676a9a2afca 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp 8dfd330f84b8e721a78722470e7c445ed3b87bec 
> 
> Diff: https://reviews.apache.org/r/40102/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Re: Review Request 40102: Windows: Unified POSIX and Windows implementation of process.hpp.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40102/
-----------------------------------------------------------

(Updated Dec. 15, 2015, 3:38 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.


Bugs: MESOS-3860
    https://issues.apache.org/jira/browse/MESOS-3860


Repository: mesos


Description
-------

Windows: Unified POSIX and Windows implementation of process.hpp.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am a8c35c086ecae21701f6a720f25231c1b0d4e329 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/process.hpp ed28e663ff4bef3391e852f3938ff1a584a8c687 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp 4ed0c47c99ccc7c6f3036fd75dfb4676a9a2afca 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp 8dfd330f84b8e721a78722470e7c445ed3b87bec 

Diff: https://reviews.apache.org/r/40102/diff/


Testing
-------


Thanks,

Alex Clemmer