[GitHub] [servicecomb-java-chassis] wujimin commented on a change in pull request #2324: [SCB-2245]upgrade netty to 4.1.60 and vert.x to 4.0.3

[GitBox <gi...@apache.org>]

wujimin commented on a change in pull request #2324:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2324#discussion_r612267056



##########
File path: foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/client/tcp/TestNetClientWrapper.java
##########
@@ -78,18 +78,17 @@ public void connect(@Mocked NetSocket normalSocket, @Mocked NetSocket sslSocket)
     int port = 8000;
     String host = "localhost";
 
-    FutureFactoryImpl futureFactory = new FutureFactoryImpl();
     new MockUp<NetClient>(normalNetClient) {
       @Mock
       NetClient connect(int port, String host, Handler<AsyncResult<NetSocket>> connectHandler) {
-        connectHandler.handle(futureFactory.succeededFuture(normalSocket));
+        connectHandler.handle(new SucceededFuture<>(normalSocket));

Review comment:
       io.vertx.core.Future#succeededFuture(T)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org