You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/06/09 08:48:44 UTC

[GitHub] [spark] LuciferYang opened a new pull request, #41533: [DRAFT] Test remove `script`

LuciferYang opened a new pull request, #41533:
URL: https://github.com/apache/spark/pull/41533

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #41533: [SPARK-44023][SQL][TESTS] Add `System.gc` at `beforeEach` in `PruneFileSourcePartitionsSuite`

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #41533:
URL: https://github.com/apache/spark/pull/41533#issuecomment-1587216757

   https://github.com/apache/spark/pull/41552/files is making another try to add a new test group to the sql module to the workload of grouping 'sql others'
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #41533: [SPARK-44023][SQL][TESTS] Add `System.gc` at `beforeEach` in `PruneFileSourcePartitionsSuite`

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #41533: [SPARK-44023][SQL][TESTS] Add `System.gc` at `beforeEach` in `PruneFileSourcePartitionsSuite`
URL: https://github.com/apache/spark/pull/41533


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #41533: [SPARK-44023][SQL][TESTS] Add `System.gc` at `beforeEach` in `PruneFileSourcePartitionsSuite`

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #41533:
URL: https://github.com/apache/spark/pull/41533#issuecomment-1588274120

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] panbingkun commented on pull request #41533: [SPARK-44023][SQL][TESTS] Add `System.gc` at `beforeEach` in `PruneFileSourcePartitionsSuite`

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41533:
URL: https://github.com/apache/spark/pull/41533#issuecomment-1588401404

   > https://github.com/apache/spark/pull/41552/files is making another try, add a new test group to the sql module to alleviate the workload of group `sql others`
   
   Perhaps this is a good idea.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on a diff in pull request #41533: [DRAFT] Test remove `script`

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #41533:
URL: https://github.com/apache/spark/pull/41533#discussion_r1224031049


##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/application/ReplE2ESuite.scala:
##########
@@ -1,154 +0,0 @@
-/*

Review Comment:
   Because `shell: 'script -q -e -c "bash {0}"'` was deleted, this test will fail. Temporarily delete this file
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41533: [SPARK-44023][SQL][TESTS] Add `System.gc` at `beforeEach` in `PruneFileSourcePartitionsSuite`

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #41533:
URL: https://github.com/apache/spark/pull/41533#discussion_r1227357089


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/AlterTableRenamePartitionSuite.scala:
##########
@@ -17,13 +17,16 @@
 
 package org.apache.spark.sql.execution.command.v2
 
+import org.scalatest.Ignore
+
 import org.apache.spark.sql.Row
 import org.apache.spark.sql.execution.command
 
 /**
  * The class contains tests for the `ALTER TABLE .. RENAME PARTITION` command
  * to check V2 table catalogs.
  */
+@Ignore

Review Comment:
   Let's ignore it for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #41533: [SPARK-44023][SQL][TESTS] Add `System.gc` at `beforeEach` in `PruneFileSourcePartitionsSuite`

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #41533:
URL: https://github.com/apache/spark/pull/41533#issuecomment-1587149363

   Another frequently killed is `JavaRowSuite`, but I don't think there are any issues with it.
   
   How about downgrade sbt to 1.8.3 for more test?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on a diff in pull request #41533: [DRAFT] Test add `System.gc` to PruneFileSourcePartitionsSuite

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #41533:
URL: https://github.com/apache/spark/pull/41533#discussion_r1225737026


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitionsSuite.scala:
##########
@@ -36,6 +36,11 @@ import org.apache.spark.sql.types.StructType
 
 class PruneFileSourcePartitionsSuite extends PrunePartitionSuiteBase with SharedSparkSession {
 
+  override def beforeEach(): Unit = {

Review Comment:
   Let's check if this is really useful @HyukjinKwon @zhengruifeng 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zhengruifeng commented on pull request #41533: [SPARK-44023][SQL][TESTS] Add `System.gc` at `beforeEach` in `PruneFileSourcePartitionsSuite`

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #41533:
URL: https://github.com/apache/spark/pull/41533#issuecomment-1587082466

   it seems `sql - other` was already timeout,
   
   what about figuring out the problematic test suites to disable for now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #41533: [SPARK-44023][SQL][TESTS] Add `System.gc` at `beforeEach` in `PruneFileSourcePartitionsSuite`

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #41533:
URL: https://github.com/apache/spark/pull/41533#issuecomment-1587129174

   ```
   2023-06-12T07:47:10.5042643Z [info] AlterTableRenamePartitionSuite:
   2023-06-12T07:47:10.7210341Z [info] - ALTER TABLE .. RENAME PARTITION using V2 catalog V2 command: rename without explicitly specifying database (171 milliseconds)
   2023-06-12T07:47:10.7333258Z [info] - ALTER TABLE .. RENAME PARTITION using V2 catalog V2 command: table to alter does not exist (13 milliseconds)
   2023-06-12T07:47:10.7959978Z [info] - ALTER TABLE .. RENAME PARTITION using V2 catalog V2 command: partition to rename does not exist (62 milliseconds)
   2023-06-12T07:47:10.8771267Z [info] - ALTER TABLE .. RENAME PARTITION using V2 catalog V2 command: target partitions exist (80 milliseconds)
   2023-06-12T07:47:10.9971419Z [info] - ALTER TABLE .. RENAME PARTITION using V2 catalog V2 command: single part partition (119 milliseconds)
   2023-06-12T07:47:11.1922848Z [info] - ALTER TABLE .. RENAME PARTITION using V2 catalog V2 command: multi part partition (195 milliseconds)
   2023-06-12T07:47:11.3404610Z [info] - ALTER TABLE .. RENAME PARTITION using V2 catalog V2 command: partition spec in RENAME PARTITION should be case insensitive (147 milliseconds)
   ```
   
   hang at `org.apache.spark.sql.execution.command.v2.AlterTableRenamePartitionSuite`,  ignore it and re-testing
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #41533: [DRAFT] Test add `System.gc` to PruneFileSourcePartitionsSuite

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #41533:
URL: https://github.com/apache/spark/pull/41533#issuecomment-1586501394

   The latest rebase did not actually run GA test, let me trigger it again
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #41533: [SPARK-44023][SQL][TESTS] Add `System.gc` at `beforeEach` in `PruneFileSourcePartitionsSuite`

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #41533:
URL: https://github.com/apache/spark/pull/41533#issuecomment-1587110520

   The running one should be `org.apache.spark.sql.execution.command.v2.AlterTableRenamePartitionSuite`
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on a diff in pull request #41533: [SPARK-44023][SQL][TESTS] Add `System.gc` at `beforeEach` in `PruneFileSourcePartitionsSuite`

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #41533:
URL: https://github.com/apache/spark/pull/41533#discussion_r1226727363


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/AlterTableRenamePartitionSuite.scala:
##########
@@ -17,13 +17,16 @@
 
 package org.apache.spark.sql.execution.command.v2
 
+import org.scalatest.Ignore
+
 import org.apache.spark.sql.Row
 import org.apache.spark.sql.execution.command
 
 /**
  * The class contains tests for the `ALTER TABLE .. RENAME PARTITION` command
  * to check V2 table catalogs.
  */
+@Ignore

Review Comment:
   Although GA passed, I am not sure we really need ignore this case ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org