You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/09/09 08:26:43 UTC

[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #197: Remove verifier.getCliOptions().add( x ) pattern

michael-o commented on code in PR #197:
URL: https://github.com/apache/maven-integration-testing/pull/197#discussion_r966770751


##########
core-it-support/maven-it-helper/src/main/java/org/apache/maven/it/AbstractMavenIntegrationTestCase.java:
##########
@@ -592,7 +592,7 @@ protected Verifier newVerifier( String basedir, String settings, boolean debug )
             // Java7 TLS protocol
             if ( VersionRange.createFromVersionSpec( "(,1.8.0)" ).containsVersion( getJavaVersion() ) )

Review Comment:
   This is a good catch. Stuff like this can be removed from master because we have Java 8+



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org