[jira] Commented: (QPID-1522) Refactor Command classes so that more common code is shared.

["Rob Godfrey (JIRA)" <qp...@incubator.apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662308#action_12662308 ] 

Rob Godfrey commented on QPID-1522:
-----------------------------------

Comments on checkin r732306:

General Comment On Original Code: does not conform to coding standards ({ should be on new line), class and method names do not follow normal Upper/Lower-Camel conventions, member variables are not prefixed with _.  Also the classes seem to have a lot of auto-generated cruft ( "To change this template use File | Settings | File Templates") that should be removed

1. CommandImpl itself doesn't seem to be part of this checkin which presumably broke the build for a short time
2  Change to CommandExecusionEngine (which should have it's name fixed to CommandExecutionEngine):
       import changed from Command to CommandImpl, however no use of CommandImpl in the file - also it immediately follows an import commands.* which makes the changed import redundant.




> Refactor Command classes so that more common code is shared. 
> -------------------------------------------------------------
>
>                 Key: QPID-1522
>                 URL: https://issues.apache.org/jira/browse/QPID-1522
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Management : CLI Tool
>    Affects Versions: M4
>            Reporter: Aidan Skinner
>            Assignee: Aidan Skinner
>         Attachments: 0001-QPID-1522-Raname-Command-class-to-CommandImpl-and-m.patch, 0002-QPID-1522-Move-common-code-up-to-CommandImpl.-Renam.patch, 0003-QPID-1522-Fix-spelling-error-in-classname.patch, 0004-QPID-1522-Move-command-line-constants-to-individual.patch
>
>
> The Command subclasses have some duplicate code which could be shared. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.