You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by dawidwys <gi...@git.apache.org> on 2017/07/14 09:24:31 UTC
[GitHub] flink pull request #4335: [FLINK-7192] Activate checkstyle flink-java/test/o...
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/4335
[FLINK-7192] Activate checkstyle flink-java/test/operator
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dawidwys/flink checkstyle-java-test-operator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4335.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4335
----
commit 92b9db2df00defe309e89d07d80250ec5f888c97
Author: Dawid Wysakowicz <dw...@apache.org>
Date: 2017-07-14T08:41:50Z
[FLINK-7192] Activate checkstyle flink-java/test/operator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4335: [FLINK-7192] Activate checkstyle flink-java/test/o...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4335#discussion_r128278280
--- Diff: flink-java/src/test/java/org/apache/flink/api/java/operator/GroupingTest.java ---
@@ -593,33 +597,42 @@ public void testGroupAtomicTypeWithInvalid3() {
dataSet.groupBy("*");
}
-
+ /**
+ * Custom data type, for testing purposes.
+ */
public static class CustomType implements Serializable {
-
+
+ /**
+ * Custom nested data type, for testing purposes.
+ */
public static class Nest {
public int myInt;
}
+
private static final long serialVersionUID = 1L;
-
+
public int myInt;
public long myLong;
public String myString;
public Nest nested;
-
+
public CustomType() {}
public CustomType(int i, long l, String s) {
myInt = i;
myLong = l;
myString = s;
}
-
+
@Override
public String toString() {
- return myInt+","+myLong+","+myString;
+ return myInt + "," + myLong + "," + myString;
}
}
+ /**
+ * Another custom data type, for testing purposes.
--- End diff --
could reword this to "Custom non-nested data type, for testing purposes."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4335: [FLINK-7192] Activate checkstyle flink-java/test/o...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4335#discussion_r128278751
--- Diff: flink-java/src/test/java/org/apache/flink/api/java/operator/SortPartitionTest.java ---
@@ -251,32 +254,42 @@ public CustomType getKey(Tuple4<Integer, Long, CustomType, Long[]> value) throws
.sortPartition("f1", Order.ASCENDING);
}
+ /**
+ * Custom data type, for testing purposes.
+ */
public static class CustomType implements Serializable {
-
+
+ /**
+ * Custom nested data type, for testing purposes.
+ */
public static class Nest {
public int myInt;
}
+
private static final long serialVersionUID = 1L;
-
+
public int myInt;
public long myLong;
public String myString;
public Nest nested;
-
+
public CustomType() {}
public CustomType(int i, long l, String s) {
myInt = i;
myLong = l;
myString = s;
}
-
+
@Override
public String toString() {
- return myInt+","+myLong+","+myString;
+ return myInt + "," + myLong + "," + myString;
}
}
+ /**
+ * Another custom data type, for testing purposes.
--- End diff --
same as above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4335: [FLINK-7192] Activate checkstyle flink-java/test/operator
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4335
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4335: [FLINK-7192] Activate checkstyle flink-java/test/o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4335
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4335: [FLINK-7192] Activate checkstyle flink-java/test/operator
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4335
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4335: [FLINK-7192] Activate checkstyle flink-java/test/o...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4335#discussion_r129242316
--- Diff: flink-java/src/test/java/org/apache/flink/api/java/operator/SortPartitionTest.java ---
@@ -251,32 +254,42 @@ public CustomType getKey(Tuple4<Integer, Long, CustomType, Long[]> value) throws
.sortPartition("f1", Order.ASCENDING);
}
+ /**
+ * Custom data type, for testing purposes.
+ */
public static class CustomType implements Serializable {
-
+
+ /**
+ * Custom nested data type, for testing purposes.
+ */
public static class Nest {
public int myInt;
}
+
private static final long serialVersionUID = 1L;
-
+
public int myInt;
public long myLong;
public String myString;
public Nest nested;
-
+
public CustomType() {}
public CustomType(int i, long l, String s) {
myInt = i;
myLong = l;
myString = s;
}
-
+
@Override
public String toString() {
- return myInt+","+myLong+","+myString;
+ return myInt + "," + myLong + "," + myString;
}
}
+ /**
+ * Another custom data type, for testing purposes.
--- End diff --
I removed this class entirely as it was not used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---