[jira] [Commented] (TEZ-1758) TezClient should provide YARN diagnostics when the AM crashes

["Hitesh Shah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203547#comment-14203547 ] 

Hitesh Shah commented on TEZ-1758:
----------------------------------

Comments:

Mostly looks good.

Minor point related to:

{code}
-        throw new SessionNotRunning("TezSession has already shutdown");
+        throw new SessionNotRunning("TezSession has already shutdown. "
+            + ((diagnostics != null) ? diagnostics : ""));
{code}

Would it make sense to have the message contain the yarn app state as well as diagnostics? 

Also, there is a minor inconsistency:
   - in case for the above code, it uses "" when diagnostics is null
   - In TezClientUtils, it says "Cluster diagnostics not found" 

Is this because diagnostics is not set when state is FINISHED?

Also, the newly added unit test code has a lot of spurious whitespaces that needs cleaning up. 






> TezClient should provide YARN diagnostics when the AM crashes
> -------------------------------------------------------------
>
>                 Key: TEZ-1758
>                 URL: https://issues.apache.org/jira/browse/TEZ-1758
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.5.2
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: TEZ-1758.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)