You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by NormW <no...@bocnet.com.au> on 2005/01/25 22:22:52 UTC

Subversion on NetWare

Greetings All,
Putting the final touchs to a 'patch' for the SVN package that allows 
Subversion 1.1.3 to be built on a Windows box for the NetWare platform; 
is there any interest for this to be included in the SVN package, and if 
so can attachments (112k zip) be sent to the list for consideration?

TIA

Norm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Subversion on NetWare

Posted by Michael W Thelen <mi...@pietdepsi.com>.
NormW wrote:
> The changes to SVN coding are minimal but are given below; the rest of
> the patch comprises the same style NWGNUmakefile files as presently used
> in Apache2, with a directory structure under .\build\netware that
> emulates the rest of the package with a build file for each module.

Thank you for the patch, I've filed it as issue #2217:
http://subversion.tigris.org/issues/show_bug.cgi?id=2217

--
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams

Re: Subversion on NetWare

Posted by NormW <no...@bocnet.com.au>.
Garrett Rooney wrote:
>> --- ne_basic.h.orig    Mon Apr 19 18:08:22 2004
>> +++ ne_basic.h    Tue Apr 27 02:17:12 2004
>> @@ -23,6 +23,9 @@
>>  #define NE_BASIC_H
>>
>>  #include <sys/types.h> /* for time_t */
>> +#ifdef HAVE_TIME_H
>> +#include <time.h> /* for time_t */
>> +#endif
>>
>>  #include "ne_request.h"
>>  ------------------------------------------------
>> --- ne_utils.h.orig    Mon Apr 19 18:08:22 2004
>> +++ ne_utils.h    Fri Apr 30 11:35:04 2004
>> @@ -23,6 +23,9 @@
>>  #define NE_UTILS_H
>>
>>  #include <sys/types.h>
>> +#ifdef HAVE_TIME_H
>> +#include <time.h> /* for time_t */
>> +#endif
>>
>>  #include <stdarg.h>
>>  #include <stdio.h>
> 
> 
> These should be submitted to the Neon project, those files are not part 
> of Subversion itself.
> 
> -garrett
> 
> .
> 
Good morning Garrett,
Thanks for the feedback and will take these two up with the neon 
project, but for the time being then, the patches submitted here will 
need to be part of the total package, until such time as neon accepts 
the changes and they become available in the neon version used by SVN. 
The prebuild bat file presently installs these two patches but oviously 
this can be removed once neon is suitably patched.

Norm



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Subversion on NetWare

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
> --- ne_basic.h.orig    Mon Apr 19 18:08:22 2004
> +++ ne_basic.h    Tue Apr 27 02:17:12 2004
> @@ -23,6 +23,9 @@
>  #define NE_BASIC_H
> 
>  #include <sys/types.h> /* for time_t */
> +#ifdef HAVE_TIME_H
> +#include <time.h> /* for time_t */
> +#endif
> 
>  #include "ne_request.h"
>  ------------------------------------------------
> --- ne_utils.h.orig    Mon Apr 19 18:08:22 2004
> +++ ne_utils.h    Fri Apr 30 11:35:04 2004
> @@ -23,6 +23,9 @@
>  #define NE_UTILS_H
> 
>  #include <sys/types.h>
> +#ifdef HAVE_TIME_H
> +#include <time.h> /* for time_t */
> +#endif
> 
>  #include <stdarg.h>
>  #include <stdio.h>

These should be submitted to the Neon project, those files are not part 
of Subversion itself.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Subversion on NetWare

Posted by NormW <no...@bocnet.com.au>.
Good morning Justin, Julian
Apologies for the delay... our national day, timezones and social 
activity impinged..

The changes to SVN coding are minimal but are given below; the rest of 
the patch comprises the same style NWGNUmakefile files as presently used 
in Apache2, with a directory structure under .\build\netware that 
emulates the rest of the package with a build file for each module.

Presently there are some diff's required for the APR used, there's a 
readme for the build process, some import files, and optionally a patch 
for Berkeley DB 4.2.52 to use it under NetWare, although most of the 
testing that has been that I'm aware of has used the native file system 
approach.

Some of the diff's for APR might eventually disappear with the next LibC 
update but are presently needed with the October release.

The size of the make files might be reduced by a useful amount just by 
culling white space with a tab or two, but refinements of that nature as 
well as alternate ways of doing this are probably the second hurdle...

Norm

--- ne_basic.h.orig    Mon Apr 19 18:08:22 2004
+++ ne_basic.h    Tue Apr 27 02:17:12 2004
@@ -23,6 +23,9 @@
  #define NE_BASIC_H

  #include <sys/types.h> /* for time_t */
+#ifdef HAVE_TIME_H
+#include <time.h> /* for time_t */
+#endif

  #include "ne_request.h"
  ------------------------------------------------
--- ne_utils.h.orig    Mon Apr 19 18:08:22 2004
+++ ne_utils.h    Fri Apr 30 11:35:04 2004
@@ -23,6 +23,9 @@
  #define NE_UTILS_H

  #include <sys/types.h>
+#ifdef HAVE_TIME_H
+#include <time.h> /* for time_t */
+#endif

  #include <stdarg.h>
  #include <stdio.h>
-------------------------------------------------
--- fs.c.orig    Tue Aug 10 17:56:32 2004
+++ fs.c    Wed Oct 06 16:47:04 2004
@@ -55,6 +55,12 @@

  #include "../libsvn_fs/fs-loader.h"

+#ifdef NETWARE
+#define OTHER_FLAGS DB_PRIVATE
+#else
+#define OTHER_FLAGS 0
+#endif
+

  /* Checking for return values, and reporting errors.  */

@@ -556,7 +562,8 @@
                                         | DB_INIT_LOCK
                                         | DB_INIT_LOG
                                         | DB_INIT_MPOOL
-                                       | DB_INIT_TXN),
+                                       | DB_INIT_TXN
+                                       | OTHER_FLAGS),
                                        0666));
    if (svn_err) goto error;

@@ -639,7 +646,8 @@
                                         | DB_INIT_LOCK
                                         | DB_INIT_LOG
                                         | DB_INIT_MPOOL
-                                       | DB_INIT_TXN),
+                                       | DB_INIT_TXN
+                                       | OTHER_FLAGS),
                                        0666));
    if (svn_err) goto error;

@@ -713,7 +721,7 @@
    SVN_BDB_ERR (ec_baton, env->open (env, path_native,
                                      (DB_RECOVER | DB_CREATE | DB_INIT_LOCK
                                       | DB_INIT_LOG | DB_INIT_MPOOL
-                                     | DB_INIT_TXN | DB_PRIVATE),
+                                     | DB_INIT_TXN | OTHER_FLAGS),
                            0666));
    SVN_BDB_ERR (ec_baton, env->close (env, 0));

@@ -737,7 +745,7 @@
                                      (DB_RECOVER_FATAL | DB_CREATE
                                       | DB_INIT_LOCK | DB_INIT_LOG
                                       | DB_INIT_MPOOL | DB_INIT_TXN
-                                     | DB_PRIVATE),
+                                     | OTHER_FLAGS),
                            0666));
    SVN_BDB_ERR (ec_baton, env->close (env, 0));
----------------------------------------------------

Justin Erenkrantz wrote:
> --On Wednesday, January 26, 2005 9:22 AM +1100 NormW 
> <no...@bocnet.com.au> wrote:
> 
>> Greetings All,
>> Putting the final touchs to a 'patch' for the SVN package that allows
>> Subversion 1.1.3 to be built on a Windows box for the NetWare platform;
>> is there any interest for this to be included in the SVN package,
> 
> 
> Sure.  Or, at the very least, we should have the opportunity to decide 
> what to do with these changes by reviewing them.  =)
> 
>> and if
>> so can attachments (112k zip) be sent to the list for consideration?
> 
> 
> Are most of the changes related to the NetWare build system?  It might 
> be possible to add a Python generator that can produce the NetWare build 
> scripts automagically.  (All of the build system stuff is dynamically 
> produced from build.conf for both MSVC and Unix.)
> 
> If the changes aren't related to the build system, it would be best to 
> try to break the changes up into the smallest possible pieces so that 
> each chunk can be independently reviewed.  Since APR et. al. already 
> work on NetWare, I'd hope that the code changes would be fairly 
> minimal.  And, obviously, if there are fixes to the APR libraries, those 
> need to go to dev@apr.apache.org not here.
> 
> Thanks!  -- justin
> 
> .
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Subversion on NetWare

Posted by NormW <no...@bocnet.com.au>.
Good morning again,
To hopefully better see whwere this is heading, find attached a 
directory structure of what the proposal looks like presently. All 
output from the build process precently remains under the 
.\build\netware structure...

And yes, _very_ new here! Been around everywhere else too long tho..

Norm

Julian Foad wrote:

Re: Subversion on NetWare

Posted by Julian Foad <ju...@btopenworld.com>.
> --On Wednesday, January 26, 2005 9:22 AM +1100 NormW <no...@bocnet.com.au> wrote:
>> Putting the final touchs to a 'patch' for the SVN package that allows
>> Subversion 1.1.3 to be built on a Windows box for the NetWare platform;
>> is there any interest for this to be included in the SVN package,  and if
>> so can attachments (112k zip) be sent to the list for consideration?

Hi, Norm, and welcome.  (I'm guessing you're fairly new here.)

Well, a 112 kB zip is a bit too big for the mailing list really.  At a pinch, 
once in a while, maybe, if you have no way of putting it on a server and 
posting the URL instead.

BUT... What would be much more useful is a description of the changes.  When we 
write a patch we write a log message to go with it which says what the overall 
purpose of the patch is, and then, for each file modified, what was modified in 
that file (purpose and result, not coding details).

For example, here is the log message from a recent change to the build system:
[[[
Teach win-tests.py to fetch the lists of tests directly from build.conf,
rather than having hardcoded lists of its own.

* build.conf (test-scripts): List utf8_tests.py - it is Windows only, but the
     test list is now centralized.

* win-tests.py: Remove the hardcoded test lists, and use the build generator
     system to find the info from build.conf.

* build/generator/gen_win.py (GeneratorBase): New intermediate class between
     gen_base.GeneratorBase and gen_win.WinGeneratorBase, containing the
     _extension_map definition for Windows, but no more customizations.
     For use when a simple Windows-oriented parse of build.conf is desired,
     but the probing for dependency versions is not, i.e. in win-tests.py.
   (_extension_map): Remove the unused 'script' type.
]]]

Please read the file "HACKING" (in the root of the source code tree) if you 
haven't.

By all means post a URL to your patch file as well, so we can comment on it 
more specifically.


Justin Erenkrantz wrote:
> Are most of the changes related to the NetWare build system?  It might 
> be possible to add a Python generator that can produce the NetWare build 
> scripts automagically.  (All of the build system stuff is dynamically 
> produced from build.conf for both MSVC and Unix.)

It seems probable that most of the size of the patch is due to stuff which is 
or could be automatically generated, or imported from elsewhere, and there 
wouldn't be much point in showing us those parts.


Thanks for offering your work.  Please be prepared for some rounds of review 
and modification before we can use it, but if it was worth you writing it and 
doesn't impact too much on the rest of the system, then it might well be worth 
us including it.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Subversion on NetWare

Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Wednesday, January 26, 2005 9:22 AM +1100 NormW <no...@bocnet.com.au> 
wrote:

> Greetings All,
> Putting the final touchs to a 'patch' for the SVN package that allows
> Subversion 1.1.3 to be built on a Windows box for the NetWare platform;
> is there any interest for this to be included in the SVN package,

Sure.  Or, at the very least, we should have the opportunity to decide what 
to do with these changes by reviewing them.  =)

> and if
> so can attachments (112k zip) be sent to the list for consideration?

Are most of the changes related to the NetWare build system?  It might be 
possible to add a Python generator that can produce the NetWare build 
scripts automagically.  (All of the build system stuff is dynamically 
produced from build.conf for both MSVC and Unix.)

If the changes aren't related to the build system, it would be best to try 
to break the changes up into the smallest possible pieces so that each 
chunk can be independently reviewed.  Since APR et. al. already work on 
NetWare, I'd hope that the code changes would be fairly minimal.  And, 
obviously, if there are fixes to the APR libraries, those need to go to 
dev@apr.apache.org not here.

Thanks!  -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org