You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Brian Behlendorf <br...@hyperreal.org> on 1997/12/30 20:20:48 UTC
problem with DOS fix patch
hold on, don't release the patch yet, I'm getting problems with it; though
it could be something else that's been committed to CVS recently too. I'll
post more in a bit.
Brian
--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
"Optimism is a strategy for making brian@apache.org
a better future." - Noam Chomsky brian@hyperreal.org
Re: problem with DOS fix patch
Posted by Marc Slemko <ma...@worldgate.com>.
Too late, Dean already fixed it. <g>
May not be reflected on the anoncvs server yet though...
On Tue, 30 Dec 1997, Igor Tatarinov wrote:
> > Okay, the current CVS tree for 1.3 gives a 501 "Method not Implemented"
> > error, "can not do GE on /statu" when trying to access "/status", and
> > similar errors trying to access anything else. However, backing out the
> > DOS fix (reverting to rev 1.79 of util.c) doesn't fix the problem, so it
> > was something else committed to CVS recently which started causing this,
> > probably ap_cpystrn. So the DOS patch is probably okay, but we need to
> > look at ap_cpystrn again.
> >
> > Brian
>
> Seems like the problem is in getword_white. Here is a patch:
>
>
> Index: util.c
> ===================================================================
> RCS file: /cvs/apachen/src/main/util.c,v
> retrieving revision 1.80
> diff -c -r1.80 util.c
> *** util.c 1997/12/30 19:03:18 1.80
> --- util.c 1997/12/30 20:37:29
> ***************
> *** 540,546 ****
> }
>
> res = palloc(atrans, pos + 1);
> ! ap_cpystrn(res, *line, pos);
>
> while (isspace((*line)[pos]))
> ++pos;
> --- 540,546 ----
> }
>
> res = palloc(atrans, pos + 1);
> ! ap_cpystrn(res, *line, pos + 1);
>
> while (isspace((*line)[pos]))
> ++pos;
>
Re: problem with DOS fix patch
Posted by Igor Tatarinov <ta...@prairie.NoDak.edu>.
> Okay, the current CVS tree for 1.3 gives a 501 "Method not Implemented"
> error, "can not do GE on /statu" when trying to access "/status", and
> similar errors trying to access anything else. However, backing out the
> DOS fix (reverting to rev 1.79 of util.c) doesn't fix the problem, so it
> was something else committed to CVS recently which started causing this,
> probably ap_cpystrn. So the DOS patch is probably okay, but we need to
> look at ap_cpystrn again.
>
> Brian
Seems like the problem is in getword_white. Here is a patch:
Index: util.c
===================================================================
RCS file: /cvs/apachen/src/main/util.c,v
retrieving revision 1.80
diff -c -r1.80 util.c
*** util.c 1997/12/30 19:03:18 1.80
--- util.c 1997/12/30 20:37:29
***************
*** 540,546 ****
}
res = palloc(atrans, pos + 1);
! ap_cpystrn(res, *line, pos);
while (isspace((*line)[pos]))
++pos;
--- 540,546 ----
}
res = palloc(atrans, pos + 1);
! ap_cpystrn(res, *line, pos + 1);
while (isspace((*line)[pos]))
++pos;
Re: problem with DOS fix patch
Posted by Brian Behlendorf <br...@organic.com>.
At 11:20 AM 12/30/97 -0800, Brian Behlendorf wrote:
>hold on, don't release the patch yet, I'm getting problems with it; though
>it could be something else that's been committed to CVS recently too. I'll
>post more in a bit.
Okay, the current CVS tree for 1.3 gives a 501 "Method not Implemented"
error, "can not do GE on /statu" when trying to access "/status", and
similar errors trying to access anything else. However, backing out the
DOS fix (reverting to rev 1.79 of util.c) doesn't fix the problem, so it
was something else committed to CVS recently which started causing this,
probably ap_cpystrn. So the DOS patch is probably okay, but we need to
look at ap_cpystrn again.
Brian
--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
specialization is for insects brian@organic.com