You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ta...@apache.org on 2018/09/28 18:53:58 UTC
qpid-jms git commit: NO-JIRA Fix intermittent test failures due to
timing
Repository: qpid-jms
Updated Branches:
refs/heads/master 51cbfa258 -> 881e8f62d
NO-JIRA Fix intermittent test failures due to timing
On very fast machine the delay can be the exact value specified so a
check on greatThanOrEqualTo is needed to ensure no sporadic faulures
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/881e8f62
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/881e8f62
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/881e8f62
Branch: refs/heads/master
Commit: 881e8f62d582745b2dfe829b94076652c67b5955
Parents: 51cbfa2
Author: Timothy Bish <ta...@gmail.com>
Authored: Fri Sep 28 14:53:09 2018 -0400
Committer: Timothy Bish <ta...@gmail.com>
Committed: Fri Sep 28 14:53:19 2018 -0400
----------------------------------------------------------------------
.../qpid/jms/provider/failover/FailoverIntegrationTest.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/881e8f62/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/failover/FailoverIntegrationTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/failover/FailoverIntegrationTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/failover/FailoverIntegrationTest.java
index f6b1818..2a4034a 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/failover/FailoverIntegrationTest.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/failover/FailoverIntegrationTest.java
@@ -1975,7 +1975,7 @@ public class FailoverIntegrationTest extends QpidJmsTestCase {
producer.send(message2);
long elapsed = System.currentTimeMillis() - start;
- MatcherAssert.assertThat("Send call should have taken at least the disposition delay", elapsed, Matchers.greaterThan(delay));
+ MatcherAssert.assertThat("Send call should have taken at least the disposition delay", elapsed, Matchers.greaterThanOrEqualTo(delay));
connection.close();
@@ -2059,9 +2059,9 @@ public class FailoverIntegrationTest extends QpidJmsTestCase {
} catch (JMSException jmse) {
//Expected
long elapsed = System.currentTimeMillis() - start;
- MatcherAssert.assertThat("Send call should have taken at least the disposition delay", elapsed, Matchers.greaterThan(delay));
+ MatcherAssert.assertThat("Send call should have taken at least the disposition delay", elapsed, Matchers.greaterThanOrEqualTo(delay));
- if(inspectException) {
+ if (inspectException) {
assertTrue(jmse instanceof ResourceAllocationException);
assertTrue(jmse.getMessage().contains("RLE description"));
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org