You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bval.apache.org by "David J. M. Karlsen (JIRA)" <ji...@apache.org> on 2010/07/01 18:17:50 UTC
[jira] Commented: (BVAL-72) NPE when doing methodvalidation
[ https://issues.apache.org/jira/browse/BVAL-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884334#action_12884334 ]
David J. M. Karlsen commented on BVAL-72:
-----------------------------------------
Unfortunately I can't free the code.
I can however provide some debugging info:
{noformat}
MethodDescriptorImpl methodDescriptor =
(MethodDescriptorImpl) beanDesc.getConstraintsForMethod(method);
methodDescriptor is null so that the next line
return validateParameters(methodDescriptor.getMetaBean(),
methodDescriptor.getParameterDescriptors(), parameters, groupArray);
will NPE (maybe it should be more robust?)
{noformat}
The method object in the aspect is:
public abstract UserType com.edb.payment.pays.core.service.user.UserService.findUser(java.lang.String,java.lang.String,java.lang.String)
Which is the interface method (note the abstract - it's also missing the annotations).
Should the interface or the implementing class be annotated - or shouldn't it matter?
The before aspect:
(The target type is the actual class implementing the interface.)
{noformat}
@Before("anyPublicMethodExecution() && withinCoreLayer()")
public void validate( JoinPoint joinPoint )
throws ValidationException
{
MethodSignature methodSignature = (MethodSignature) joinPoint.getSignature();
MethodValidator methodValidator = getMethodValidator();
Class<?> clazz = joinPoint.getTarget().getClass();
Method method = methodSignature.getMethod();
Object[] args = joinPoint.getArgs();
logger.trace( "Validating method {} on target {} passed args {}", new Object[] { clazz, method, args } );
Set<? extends ConstraintViolation<?>> validationErrors = methodValidator.validateParameters( clazz, method,
args );
if ( !validationErrors.isEmpty() )
{
throw new ValidationException( validationErrors );
}
}
{noformat}
If you really need it I can create a case which looks the same but on code which can be freed - please ping back.
> NPE when doing methodvalidation
> -------------------------------
>
> Key: BVAL-72
> URL: https://issues.apache.org/jira/browse/BVAL-72
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.2-incubating
> Environment: JDK 1.5, spring 3.0.3
> Reporter: David J. M. Karlsen
>
> I get an npe when calling this annotated method (the annotations are on the implementation class - not on the interface):
> findUser( @Size( min=1 ) String param1,
> @NotNull String param2,
> @NotNull SomeClass param3 )
> It ends up not findin a MethodDescriptor, this it's null when attempting to call method validation.
> {noformat}
> java.lang.NullPointerException
> at org.apache.bval.jsr303.extensions.MethodValidatorImpl.validateParameters(MethodValidatorImpl.java:86)
> at com.edb.payment.pays.core.util.aop.validation.ValidationAspect.validate(ValidationAspect.java:67)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:592)
> at org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethodWithGivenArgs(AbstractAspectJAdvice.java:621)
> at org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethod(AbstractAspectJAdvice.java:603)
> at org.springframework.aop.aspectj.AspectJMethodBeforeAdvice.before(AspectJMethodBeforeAdvice.java:39)
> at org.springframework.aop.framework.adapter.MethodBeforeAdviceInterceptor.invoke(MethodBeforeAdviceInterceptor.java:49)
> at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
> at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:110)
> at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
> at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:89)
> at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
> at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202)
> at $Proxy21.findUser(Unknown Source)
> at com.edb.payment.pays.core.service.user.UserServiceImplTest.findUserThatExists(UserServiceImplTest.java:27)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:592)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
> at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
> at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
> at org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:74)
> at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:82)
> at org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:72)
> at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:240)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
> at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
> at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
> at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:180)
> at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:49)
> at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.