You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by richard zhou <ri...@intel.com> on 2015/02/06 03:16:19 UTC
Re: Review Request 30705: SQOOP-2079: SQOOP2: refactor default RBAC
implementation (remove useless function)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30705/
-----------------------------------------------------------
(Updated Feb. 6, 2015, 2:16 a.m.)
Review request for Sqoop.
Summary (updated)
-----------------
SQOOP-2079: SQOOP2: refactor default RBAC implementation (remove useless function)
Repository: sqoop-sqoop2
Description
-------
Remove useless functions, according to https://cwiki.apache.org/confluence/display/Hive/Hive+Default+Authorization+-+Legacy+Mode
Diffs
-----
core/src/main/java/org/apache/sqoop/security/AuthorizationAccessController.java 54fa556edc60622ac6d2e3bc9f7c010894451c22
core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java 5f3231be169ae0d42734628571b06da491ae5c64
core/src/main/java/org/apache/sqoop/security/AuthorizationValidator.java c6482fbe3e63c8c82da49e43a515b8998b6ab264
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationAccessController.java 02f8f3b129cd8f63cda937f5a7de1b3192624cf0
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java 8e63b86f03ff67af5bc59d61325d749f81fd2745
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationValidator.java bbde2816cd62235ee30fca99e10eaf65f34890b6
Diff: https://reviews.apache.org/r/30705/diff/
Testing
-------
Thanks,
richard zhou
Re: Review Request 30705: SQOOP-2079: SQOOP2: refactor default RBAC
implementation (remove useless function)
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30705/#review71364
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Feb. 6, 2015, 2:45 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30705/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2015, 2:45 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Remove useless functions, according to https://cwiki.apache.org/confluence/display/Hive/Hive+Default+Authorization+-+Legacy+Mode
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/model/MPrincipal.java 061ffe52e7e68db6edc86c2a78539978b0022cbe
> common/src/main/java/org/apache/sqoop/model/MPrivilege.java 7d656eca5da367517c59b19328f91ba068bd1a74
> common/src/main/java/org/apache/sqoop/model/MResource.java 8e519e5b2b559129800d3150e07b87eb1e549f4e
> common/src/main/java/org/apache/sqoop/model/MRole.java 359fa09b2444b2c0c9708645ad47663cc56fb579
> core/src/main/java/org/apache/sqoop/security/AuthorizationAccessController.java 54fa556edc60622ac6d2e3bc9f7c010894451c22
> core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java 5f3231be169ae0d42734628571b06da491ae5c64
> core/src/main/java/org/apache/sqoop/security/AuthorizationValidator.java c6482fbe3e63c8c82da49e43a515b8998b6ab264
> security/src/main/java/org/apache/sqoop/security/Authorization/AuthorizationEngine.java dbf6dd422839173eebf0ac6101450beefa0e1d7b
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationAccessController.java 02f8f3b129cd8f63cda937f5a7de1b3192624cf0
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java 8e63b86f03ff67af5bc59d61325d749f81fd2745
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationValidator.java bbde2816cd62235ee30fca99e10eaf65f34890b6
>
> Diff: https://reviews.apache.org/r/30705/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 30705: SQOOP-2079: SQOOP2: refactor default RBAC
implementation (remove useless function)
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30705/
-----------------------------------------------------------
(Updated Feb. 6, 2015, 2:45 a.m.)
Review request for Sqoop.
Changes
-------
1. add getAllRole function
2. add getRolesByPrincipal function
3. change role name to MRole object
4. remove parameter id in MRole, MResource, MPrincipal, MPrivilege, since it is useless
5. remove parameter name in MPrivilege, since it is useless
6. add @Override
7. change removeRole to dropRole in function name
Repository: sqoop-sqoop2
Description
-------
Remove useless functions, according to https://cwiki.apache.org/confluence/display/Hive/Hive+Default+Authorization+-+Legacy+Mode
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/model/MPrincipal.java 061ffe52e7e68db6edc86c2a78539978b0022cbe
common/src/main/java/org/apache/sqoop/model/MPrivilege.java 7d656eca5da367517c59b19328f91ba068bd1a74
common/src/main/java/org/apache/sqoop/model/MResource.java 8e519e5b2b559129800d3150e07b87eb1e549f4e
common/src/main/java/org/apache/sqoop/model/MRole.java 359fa09b2444b2c0c9708645ad47663cc56fb579
core/src/main/java/org/apache/sqoop/security/AuthorizationAccessController.java 54fa556edc60622ac6d2e3bc9f7c010894451c22
core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java 5f3231be169ae0d42734628571b06da491ae5c64
core/src/main/java/org/apache/sqoop/security/AuthorizationValidator.java c6482fbe3e63c8c82da49e43a515b8998b6ab264
security/src/main/java/org/apache/sqoop/security/Authorization/AuthorizationEngine.java dbf6dd422839173eebf0ac6101450beefa0e1d7b
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationAccessController.java 02f8f3b129cd8f63cda937f5a7de1b3192624cf0
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java 8e63b86f03ff67af5bc59d61325d749f81fd2745
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationValidator.java bbde2816cd62235ee30fca99e10eaf65f34890b6
Diff: https://reviews.apache.org/r/30705/diff/
Testing
-------
Thanks,
richard zhou