You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by DmytroShkvyra <gi...@git.apache.org> on 2017/04/21 17:49:44 UTC
[GitHub] flink pull request #3753: [FLINK-5476] Fail fast if trying to submit a job t...
GitHub user DmytroShkvyra opened a pull request:
https://github.com/apache/flink/pull/3753
[FLINK-5476] Fail fast if trying to submit a job to a non-existing Fl\u2026
\u2026ink cluster
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-5476] Fail fast if trying to submit a job to a non-existing Flink cluster")
- [ ] Documentation
- [ ] Tests & Build
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DmytroShkvyra/flink FLINK-5476
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3753.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3753
----
commit e6ca9d1fd2308a0be3e92e4fe59b0a3e98d3bf3d
Author: DmytroShkvyra <ds...@gmail.com>
Date: 2017-04-21T17:44:21Z
[FLINK-5476] Fail fast if trying to submit a job to a non-existing Flink cluster
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3753: [FLINK-5476] Fail fast if trying to submit a job to a non...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3753
Sorry for not coming back to you earlier. I will try to give it another round of review in the next days.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3753: [FLINK-5476] Fail fast if trying to submit a job t...
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra closed the pull request at:
https://github.com/apache/flink/pull/3753
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3753: [FLINK-5476] Fail fast if trying to submit a job to a non...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3753
The code does not seem to match the PR description @DmytroShkvyra. I don't see where you use different timeouts for the connection. The only thing which seems to be modified is that the `JobManager` now understands the `GetClusterStatus` message. Could you please clarify what this PR tries to achieve?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3753: [FLINK-5476] Fail fast if trying to submit a job to a non...
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra commented on the issue:
https://github.com/apache/flink/pull/3753
Was closed occasionally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3753: [FLINK-5476] Fail fast if trying to submit a job to a non...
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra commented on the issue:
https://github.com/apache/flink/pull/3753
Hi @tillrohrmann could you review this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3753: [FLINK-5476] Fail fast if trying to submit a job to a non...
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra commented on the issue:
https://github.com/apache/flink/pull/3753
New PR is https://github.com/apache/flink/pull/4001
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3753: [FLINK-5476] Fail fast if trying to submit a job to a non...
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra commented on the issue:
https://github.com/apache/flink/pull/3753
Hi @tillrohrmann,
The main idea of this PR is propagation of exception from `StandaloneClusterClient.getClusterStatus`, so if cluster non-existing it will throw `RuntimeExeption` with clear message and will not waiting for timeouts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---