You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/06/01 15:29:22 UTC

[GitHub] [camel-k] squakez opened a new pull request, #3325: feat(cli): environment promotion PoC

squakez opened a new pull request, #3325:
URL: https://github.com/apache/camel-k/pull/3325

With this PR the user can simply run:
```
kamel promote sample -n development --to production
```
in order to copy the Integration spec and the related container image from one environment to another. The idea is that the Operators share the same Image registry.

In the PR we already:

* Check compatibility version between source and dest operators
* Copy the Integration spec from namespace source to ns dest
* Set container.image trait on destination to reuse image from the source Integration

This is a PoC to collect feedback. As this was a very requested feature, we can provide some first approach in the meantime we come out with a more proper design.

Missing stuff we will have to work on before converting the draft:

* Verify namespaced resources (ie, mount traits) are present in dest namespace
* Verify the operators registries are the same
* Verify Kamelets are available in dest namespace

<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".

You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->

**Release Note**
```release-note
feat(cli): environment promotion PoC
```

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez commented on pull request #3325: feat(cli): environment promotion PoC

Posted by GitBox <gi...@apache.org>.

squakez commented on PR #3325:
URL: https://github.com/apache/camel-k/pull/3325#issuecomment-1144515725

   Thanks for the feedback, much appreciated!!
   
   >     * What if the dev namespace uses a local operator but the production depends on a cluster operator (or vice versa)?  Is such promotion not allowed?
   
   I think it still can be done. The idea is that we *copy* the Integration spec plus the container which was tested and validated in a previous stage. I think the destination operator should be still able to cope with that.
   
   >     * Do we need to check user's privileges for the target namespace?  Or is it ok to let it fail if they are not permitted?
   
   We may understand which is the best ux there. If I am not wrong, the client we use to interact with the cluster is inheriting privileges from the user who has performed the login. I guess in a very first iteration we can let it fail, and add a check for valid permission in a later stage if we want.
   
   >     * Users might want to transform some labels (or annotations) depending on the types of envs (namespaces). Should we provide such feature as well?
   
   Yeah, that is something we should analyze better. I've already thought we should check for various resources in the destination namespace. We should include also some parameter in order to transform the "typical" resources bound to an environment (annotations, envs, affininity/tolerations, etc...).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez merged pull request #3325: feat(cli): environment promotion

Posted by GitBox <gi...@apache.org>.

squakez merged PR #3325:
URL: https://github.com/apache/camel-k/pull/3325


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi commented on pull request #3325: feat(cli): environment promotion PoC

Posted by GitBox <gi...@apache.org>.

tadayosi commented on PR #3325:
URL: https://github.com/apache/camel-k/pull/3325#issuecomment-1144345949

   Looks great!  Here is my early feedback on the feature:
   - What if the dev namespace uses a local operator but the production depends on a cluster operator?  Is such promotion not allowed?
   - Do we need to check user's privileges for the target namespace?  Or is it ok to let it fail if they are not permitted?
   - Users might want to transform some labels (or annotations) depending on the types of envs (namespaces). Should we provide such feature as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org