[jira] Commented: (ORCHESTRA-24) conversationContext param in url is missing; this breaks orchestra completely

["Simon Kitching (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/ORCHESTRA-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594166#action_12594166 ] 

Simon Kitching commented on ORCHESTRA-24:
-----------------------------------------

The patch that broke orchestra actually happened a while ago. It was this one:

------------------------------------------------------------------------
r635942 | mmarinschek | 2008-03-11 15:31:25 +0100 (Di, 11 Mär 2008) | 1 line
Geänderte Pfade:
   A /myfaces/orchestra/trunk/core/src/main/java/org/apache/myfaces/orchestra/requestParameterProvider/jsf/ExternalContextWrapper.java
   A /myfaces/orchestra/trunk/core/src/main/java/org/apache/myfaces/orchestra/requestParameterProvider/jsf/FacesContextWrapper.java
   M /myfaces/orchestra/trunk/core/src/main/java/org/apache/myfaces/orchestra/requestParameterProvider/jsf/RequestParameterFacesContextFactory.java

fix for https://issues.apache.org/jira/browse/ORCHESTRA-17 (ORCHESTRA-17): RequestParameterFacesContextFactory only works with HttpServletResponse
------------------------------------------------------------------------

This patch has other bugs, as I noted on issue ORCHESTRA-17 at the time. 

> conversationContext param in url is missing; this breaks orchestra completely
> -----------------------------------------------------------------------------
>
>                 Key: ORCHESTRA-24
>                 URL: https://issues.apache.org/jira/browse/ORCHESTRA-24
>             Project: MyFaces Orchestra
>          Issue Type: Bug
>            Reporter: Simon Kitching
>
> In trunk (1.2-SNAPSHOT), some recent commit has completely broken orchestra.
> The URLs no longer have a conversationContext param inserted. That means that each http request runs in a different context, so no conversation-scoped objects can ever be found.
> Running the same test code with orchestra 1.1 release works fine.
> I'll try to track down the commit that caused it, but apache SVN is broken at the moment...(again)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.