You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "arturobernalg (via GitHub)" <gi...@apache.org> on 2023/08/25 10:14:22 UTC
[GitHub] [httpcomponents-core] arturobernalg opened a new pull request, #419: Refactor testConcurrentOperations to use AtomicBooleans for outcome v…
arturobernalg opened a new pull request, #419:
URL: https://github.com/apache/httpcomponents-core/pull/419
Refactor `testConcurrentOperations` to use `AtomicBooleans` for outcome verification, enhancing test determinism and reducing exception unpredictability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on pull request #419: Refactor testConcurrentOperations to use AtomicBooleans for outcome v…
Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg commented on PR #419:
URL: https://github.com/apache/httpcomponents-core/pull/419#issuecomment-1693359992
> @arturobernalg Interesting. Future callbacks are deterministic but the future itself is not?
@ok2c
With `` AtomicBoolean` ensures we can deterministically track which callback was invoked first. Maybe I'm wrong but BasicFuture operations are inherently non-deterministic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #419: Refactor testConcurrentOperations to use AtomicBooleans for outcome v…
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #419:
URL: https://github.com/apache/httpcomponents-core/pull/419#issuecomment-1693665913
> Maybe I'm wrong but BasicFuture operations are inherently non-deterministic
@arturobernalg It was not my intent when I initially built `BasicFuture` but this is likely how it turned out to be. Please go ahead and merge the change-set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg merged pull request #419: Refactor testConcurrentOperations to use AtomicBooleans for outcome v…
Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg merged PR #419:
URL: https://github.com/apache/httpcomponents-core/pull/419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org