[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38162: [SPARK-40677][CONNECT][FOLLOWUP] Refactor shade `relocation/rename` rules

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #38162:
URL: https://github.com/apache/spark/pull/38162#discussion_r990908713


##########
project/SparkBuild.scala:
##########
@@ -655,19 +655,47 @@ object SparkConnect {
 
     (assembly / logLevel) := Level.Info,
 
+    // Exclude `scala-library` from assembly.
+    (assembly / assemblyPackageScala / assembleArtifact) := false,
+
+    // Exclude `pmml-model-*.jar`, `scala-collection-compat_*.jar`,`jsr305-*.jar` and
+    // `unused-1.0.0.jar` from assembly.
+    (assembly / assemblyExcludedJars) := {
+      val cp = (assembly / fullClasspath).value
+      cp filter { v =>
+        val name = v.data.getName
+        name.startsWith("pmml-model-") || name.startsWith("scala-collection-compat_") ||

Review Comment:
   Is `scala-collection` picked up from Scala library itself? I remember there's an option to exclude this (e.g., `includeScala = False`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org