[tomcat] 03/05: Fix SpotBugs failures in JULI and naming

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 4467e6d8c95bb3037904ba4638eb26b2b15cbdce
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Nov 14 10:33:34 2019 +0000

    Fix SpotBugs failures in JULI and naming
---
 res/findbugs/filter-false-positives.xml | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/res/findbugs/filter-false-positives.xml b/res/findbugs/filter-false-positives.xml
index b2ed8f1..fd1b463 100644
--- a/res/findbugs/filter-false-positives.xml
+++ b/res/findbugs/filter-false-positives.xml
@@ -980,6 +980,18 @@
     <Bug code="Dm" />
   </Match>
   <Match>
+    <!-- As per the comment, FileSystems.getDefault() does have a
+         side-effect. -->
+    <Class name="org.apache.juli.logging.LogFactory"/>
+    <Method name="&lt;init&gt;"/>
+    <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT" />
+  </Match>
+  <Match>
+    <!-- Reference.equals() implementation correctly handles sub-classes -->
+    <Class name="org.apache.naming.ServiceRef" />
+    <Pattern code="EQ_DOESNT_OVERRIDE_EQUALS" />
+  </Match>
+  <Match>
     <!-- Simpler to catch Exception than to create dummy implementations of the
          necessary exception hierarchy -->
     <Class name="org.apache.naming.factory.SendMailFactory$1" />


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org